Skip to content

Addon-Docs: Add React as optimizeDeps entry#34176

Merged
valentinpalkovic merged 1 commit into
nextfrom
valentin/add-react-as-optimize-deps-to-addon-docs
Mar 17, 2026
Merged

Addon-Docs: Add React as optimizeDeps entry#34176
valentinpalkovic merged 1 commit into
nextfrom
valentin/add-react-as-optimize-deps-to-addon-docs

Conversation

@valentinpalkovic
Copy link
Copy Markdown
Contributor

@valentinpalkovic valentinpalkovic commented Mar 17, 2026

Closes #

What I did

Checklist for Contributors

Testing

The changes in this PR are covered in the following automated tests:

  • stories
  • unit tests
  • integration tests
  • end-to-end tests

Manual testing

Caution

This section is mandatory for all contributions. If you believe no manual test is necessary, please state so explicitly. Thanks!

Documentation

  • Add or update documentation reflecting your changes
  • If you are deprecating/removing a feature, make sure to update
    MIGRATION.MD

Checklist for Maintainers

  • When this PR is ready for testing, make sure to add ci:normal, ci:merged or ci:daily GH label to it to run a specific set of sandboxes. The particular set of sandboxes can be found in code/lib/cli-storybook/src/sandbox-templates.ts

  • Make sure this PR contains one of the labels below:

    Available labels
    • bug: Internal changes that fixes incorrect behavior.
    • maintenance: User-facing maintenance tasks.
    • dependencies: Upgrading (sometimes downgrading) dependencies.
    • build: Internal-facing build tooling & test updates. Will not show up in release changelog.
    • cleanup: Minor cleanup style change. Will not show up in release changelog.
    • documentation: Documentation only changes. Will not show up in release changelog.
    • feature request: Introducing a new feature.
    • BREAKING CHANGE: Changes that break compatibility in some way with current major version.
    • other: Changes that don't fit in the above categories.

🦋 Canary release

This pull request has been released as version 0.0.0-pr-34176-sha-e53219d4. Try it out in a new sandbox by running npx storybook@0.0.0-pr-34176-sha-e53219d4 sandbox or in an existing project with npx storybook@0.0.0-pr-34176-sha-e53219d4 upgrade.

More information
Published version 0.0.0-pr-34176-sha-e53219d4
Triggered by @valentinpalkovic
Repository storybookjs/storybook
Branch valentin/add-react-as-optimize-deps-to-addon-docs
Commit e53219d4
Datetime Tue Mar 17 09:53:10 UTC 2026 (1773741190)
Workflow run 23188360010

To request a new release of this pull request, mention the @storybookjs/core team.

core team members can create a new canary release here or locally with gh workflow run --repo storybookjs/storybook publish.yml --field pr=34176

Summary by CodeRabbit

Release Notes

  • Chores
    • Enhanced dependency optimization to improve build performance.

@github-actions
Copy link
Copy Markdown
Contributor

Fails
🚫 The "#### Manual testing" section must be filled in. Please describe how to test the changes you've made, step by step, so that reviewers can confirm your PR works as intended.

Generated by 🚫 dangerJS against e53219d

@nx-cloud
Copy link
Copy Markdown

nx-cloud Bot commented Mar 17, 2026

View your CI Pipeline Execution ↗ for commit e53219d

Command Status Duration Result
nx run-many -t compile -c production --parallel=1 ✅ Succeeded 5m 9s View ↗

☁️ Nx Cloud last updated this comment at 2026-03-17 10:04:13 UTC

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented Mar 17, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 48403f75-0416-402a-ad09-e61fe7d908c8

📥 Commits

Reviewing files that changed from the base of the PR and between 546aece and e53219d.

📒 Files selected for processing (1)
  • code/addons/docs/src/preset.ts

📝 Walkthrough

Walkthrough

Added 'react' to the optimizeViteDeps array in the docs addon Vite preset configuration. This is a single-line additive change that includes React in Vite's dependency optimization list without altering existing behavior.

Changes

Cohort / File(s) Summary
Vite Optimization Configuration
code/addons/docs/src/preset.ts
Added 'react' to the optimizeViteDeps array for Vite dependency optimization in the docs addon preset.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Possibly related PRs

  • storybookjs/storybook#32798 — Also modifies optimizeViteDeps in the same preset file but adds '@storybook/addon-docs/blocks' dependency.
  • storybookjs/storybook#33875 — Adds multiple React-related dependencies to optimizeViteDeps arrays across different preset files.
✨ Finishing Touches
  • 📝 Generate docstrings (stacked PR)
  • 📝 Generate docstrings (commit on current branch)
📝 Coding Plan
  • Generate coding plan for human review comments

Comment @coderabbitai help to get the list of available commands and usage tips.

Tip

CodeRabbit can scan for known vulnerabilities in your dependencies using OSV Scanner.

OSV Scanner will automatically detect and report security vulnerabilities in your project's dependencies. No additional configuration is required.

@valentinpalkovic valentinpalkovic merged commit 87bb33f into next Mar 17, 2026
127 of 134 checks passed
@valentinpalkovic valentinpalkovic deleted the valentin/add-react-as-optimize-deps-to-addon-docs branch March 17, 2026 12:05
@github-project-automation github-project-automation Bot moved this from In Progress to Done in Core Team Projects Mar 17, 2026
@github-actions github-actions Bot mentioned this pull request Mar 17, 2026
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

2 participants