Build: Gitignore MCPs#34157
Conversation
|
📝 WalkthroughWalkthroughThis PR removes MCP server configurations for "nx" from multiple editor/IDE configuration files and updates .gitignore to exclude MCP JSON configuration files from version control. Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes Possibly related PRs
📝 Coding Plan
Comment Tip You can disable sequence diagrams in the walkthrough.Disable the |
There was a problem hiding this comment.
🧹 Nitpick comments (1)
.gitignore (1)
79-81: LGTM! Appropriate to ignore MCP configuration files.These patterns correctly exclude user-specific MCP configuration files from version control, which is the right approach since they contain environment-specific tool configurations.
Optional consideration: If other editors/IDEs adopt MCP configurations in the future, you might consider a more general pattern like
**/mcp.jsonto catch them automatically. However, the current explicit approach is clearer and sufficient for the known use cases.🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In @.gitignore around lines 79 - 81, The .gitignore entries for MCP config (.cursor/mcp.json, .vscode/mcp.json, .mcp.json) are fine as-is; optionally, if you want to generically ignore any mcp.json anywhere, replace the explicit patterns with a single recursive pattern (e.g., use a glob like **/mcp.json) so any future editor-specific directories are automatically excluded—update the .gitignore by removing the three explicit lines and adding the recursive pattern if you choose the broader approach.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Nitpick comments:
In @.gitignore:
- Around line 79-81: The .gitignore entries for MCP config (.cursor/mcp.json,
.vscode/mcp.json, .mcp.json) are fine as-is; optionally, if you want to
generically ignore any mcp.json anywhere, replace the explicit patterns with a
single recursive pattern (e.g., use a glob like **/mcp.json) so any future
editor-specific directories are automatically excluded—update the .gitignore by
removing the three explicit lines and adding the recursive pattern if you choose
the broader approach.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: fd834fee-61cb-4d6a-b1dd-d2f1c08c57e0
📒 Files selected for processing (4)
.cursor/mcp.json.gitignore.mcp.json.vscode/mcp.json
💤 Files with no reviewable changes (3)
- .cursor/mcp.json
- .vscode/mcp.json
- .mcp.json
Closes #
What I did
Checklist for Contributors
Testing
The changes in this PR are covered in the following automated tests:
Manual testing
Caution
This section is mandatory for all contributions. If you believe no manual test is necessary, please state so explicitly. Thanks!
Documentation
MIGRATION.MD
Checklist for Maintainers
When this PR is ready for testing, make sure to add
ci:normal,ci:mergedorci:dailyGH label to it to run a specific set of sandboxes. The particular set of sandboxes can be found incode/lib/cli-storybook/src/sandbox-templates.tsMake sure this PR contains one of the labels below:
Available labels
bug: Internal changes that fixes incorrect behavior.maintenance: User-facing maintenance tasks.dependencies: Upgrading (sometimes downgrading) dependencies.build: Internal-facing build tooling & test updates. Will not show up in release changelog.cleanup: Minor cleanup style change. Will not show up in release changelog.documentation: Documentation only changes. Will not show up in release changelog.feature request: Introducing a new feature.BREAKING CHANGE: Changes that break compatibility in some way with current major version.other: Changes that don't fit in the above categories.🦋 Canary release
This PR does not have a canary release associated. You can request a canary release of this pull request by mentioning the
@storybookjs/coreteam here.core team members can create a canary release here or locally with
gh workflow run --repo storybookjs/storybook publish.yml --field pr=<PR_NUMBER>Summary by CodeRabbit