Skip to content

Build: Gitignore MCPs#34157

Merged
valentinpalkovic merged 2 commits into
nextfrom
valentin/gitignore-mcps
Mar 16, 2026
Merged

Build: Gitignore MCPs#34157
valentinpalkovic merged 2 commits into
nextfrom
valentin/gitignore-mcps

Conversation

@valentinpalkovic
Copy link
Copy Markdown
Contributor

@valentinpalkovic valentinpalkovic commented Mar 16, 2026

Closes #

What I did

Checklist for Contributors

Testing

The changes in this PR are covered in the following automated tests:

  • stories
  • unit tests
  • integration tests
  • end-to-end tests

Manual testing

Caution

This section is mandatory for all contributions. If you believe no manual test is necessary, please state so explicitly. Thanks!

Documentation

  • Add or update documentation reflecting your changes
  • If you are deprecating/removing a feature, make sure to update
    MIGRATION.MD

Checklist for Maintainers

  • When this PR is ready for testing, make sure to add ci:normal, ci:merged or ci:daily GH label to it to run a specific set of sandboxes. The particular set of sandboxes can be found in code/lib/cli-storybook/src/sandbox-templates.ts

  • Make sure this PR contains one of the labels below:

    Available labels
    • bug: Internal changes that fixes incorrect behavior.
    • maintenance: User-facing maintenance tasks.
    • dependencies: Upgrading (sometimes downgrading) dependencies.
    • build: Internal-facing build tooling & test updates. Will not show up in release changelog.
    • cleanup: Minor cleanup style change. Will not show up in release changelog.
    • documentation: Documentation only changes. Will not show up in release changelog.
    • feature request: Introducing a new feature.
    • BREAKING CHANGE: Changes that break compatibility in some way with current major version.
    • other: Changes that don't fit in the above categories.

🦋 Canary release

This PR does not have a canary release associated. You can request a canary release of this pull request by mentioning the @storybookjs/core team here.

core team members can create a canary release here or locally with gh workflow run --repo storybookjs/storybook publish.yml --field pr=<PR_NUMBER>

Summary by CodeRabbit

  • Chores
    • Removed development server integration configurations from editor setup files.
    • Updated version control settings to exclude configuration files from repository tracking.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Mar 16, 2026

Fails
🚫

PR is not labeled with one of: ["cleanup","BREAKING CHANGE","feature request","bug","documentation","maintenance","build","dependencies"]

🚫

PR is not labeled with one of: ["ci:normal","ci:merged","ci:daily","ci:docs"]

🚫 The "#### Manual testing" section must be filled in. Please describe how to test the changes you've made, step by step, so that reviewers can confirm your PR works as intended.

Generated by 🚫 dangerJS against 877834a

@valentinpalkovic valentinpalkovic changed the title Valentin/gitignore mcps Build gitignore MCPs Mar 16, 2026
@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented Mar 16, 2026

📝 Walkthrough

Walkthrough

This PR removes MCP server configurations for "nx" from multiple editor/IDE configuration files and updates .gitignore to exclude MCP JSON configuration files from version control.

Changes

Cohort / File(s) Summary
MCP Configuration Removals
.cursor/mcp.json, .mcp.json, .vscode/mcp.json
Deleted or removed "nx" MCP server entries (command: "npx", args: ["-y", "nx-mcp@latest"]) from cursor, root, and VSCode configuration files.
Version Control Configuration
.gitignore
Added ignore patterns for .cursor/mcp.json, .vscode/mcp.json, and .mcp.json files.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Possibly related PRs

📝 Coding Plan
  • Generate coding plan for human review comments

Comment @coderabbitai help to get the list of available commands and usage tips.

Tip

You can disable sequence diagrams in the walkthrough.

Disable the reviews.sequence_diagrams setting to disable sequence diagrams in the walkthrough.

Copy link
Copy Markdown
Contributor

@coderabbitai coderabbitai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧹 Nitpick comments (1)
.gitignore (1)

79-81: LGTM! Appropriate to ignore MCP configuration files.

These patterns correctly exclude user-specific MCP configuration files from version control, which is the right approach since they contain environment-specific tool configurations.

Optional consideration: If other editors/IDEs adopt MCP configurations in the future, you might consider a more general pattern like **/mcp.json to catch them automatically. However, the current explicit approach is clearer and sufficient for the known use cases.

🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.

In @.gitignore around lines 79 - 81, The .gitignore entries for MCP config
(.cursor/mcp.json, .vscode/mcp.json, .mcp.json) are fine as-is; optionally, if
you want to generically ignore any mcp.json anywhere, replace the explicit
patterns with a single recursive pattern (e.g., use a glob like **/mcp.json) so
any future editor-specific directories are automatically excluded—update the
.gitignore by removing the three explicit lines and adding the recursive pattern
if you choose the broader approach.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.

Nitpick comments:
In @.gitignore:
- Around line 79-81: The .gitignore entries for MCP config (.cursor/mcp.json,
.vscode/mcp.json, .mcp.json) are fine as-is; optionally, if you want to
generically ignore any mcp.json anywhere, replace the explicit patterns with a
single recursive pattern (e.g., use a glob like **/mcp.json) so any future
editor-specific directories are automatically excluded—update the .gitignore by
removing the three explicit lines and adding the recursive pattern if you choose
the broader approach.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: fd834fee-61cb-4d6a-b1dd-d2f1c08c57e0

📥 Commits

Reviewing files that changed from the base of the PR and between d522903 and 877834a.

📒 Files selected for processing (4)
  • .cursor/mcp.json
  • .gitignore
  • .mcp.json
  • .vscode/mcp.json
💤 Files with no reviewable changes (3)
  • .cursor/mcp.json
  • .vscode/mcp.json
  • .mcp.json

Copy link
Copy Markdown
Contributor

@Sidnioulz Sidnioulz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@valentinpalkovic valentinpalkovic merged commit 611f9c7 into next Mar 16, 2026
12 of 13 checks passed
@valentinpalkovic valentinpalkovic deleted the valentin/gitignore-mcps branch March 16, 2026 10:50
@valentinpalkovic valentinpalkovic changed the title Build gitignore MCPs Build: Gitignore MCPs Mar 16, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants