Build: Update internal Vitest dependencies to 4.1#34147
Build: Update internal Vitest dependencies to 4.1#34147valentinpalkovic wants to merge 3 commits into
Conversation
valentinpalkovic
added
build
|
View your CI Pipeline Execution ↗ for commit d9ef2de
☁️ Nx Cloud last updated this comment at |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (4)
✅ Files skipped from review due to trivial changes (2)
📝 WalkthroughWalkthroughReworks AGENTS.md to an agent-focused command reference (replacing legacy narratives with explicit agent-oriented commands and adding NX notes). Bumps Vitest-related packages from 4.0.x to 4.1.0 across multiple package.json files. Adds a new Changes
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Possibly related PRs
📝 Coding Plan
Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@AGENTS.md`:
- Line 230: Update the command example so it explicitly runs from the code/
workspace: change the coverage example that currently shows `yarn vitest run
--coverage <test-file> --reporter=agent` to run from the project’s code
directory by prefixing with `cd code &&` (so use `cd code && yarn vitest run
--coverage <test-file> --reporter=agent`), ensuring vitest resolves and tests
run with the correct root; update the AGENTS.md entry where that example string
appears.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: c0609197-e7b2-49ce-a701-a0de942c32bb
⛔ Files ignored due to path filters (1)
yarn.lockis excluded by!**/yarn.lock,!**/*.lock
📒 Files selected for processing (7)
AGENTS.mdcode/addons/vitest/package.jsoncode/lib/eslint-plugin/package.jsoncode/package.jsonscripts/package.jsontest-storybooks/portable-stories-kitchen-sink/react/package.jsontest-storybooks/yarn-pnp/package.json
| - Export functions that need direct tests | ||
| - Test real behavior, not just syntax patterns | ||
| - Use coverage when useful: `yarn vitest run --coverage <test-file>` | ||
| - Use coverage when useful: `yarn vitest run --coverage <test-file> --reporter=agent` |
There was a problem hiding this comment.
Make the coverage command explicitly run from the code/ workspace.
Line 230 omits cd code &&, which conflicts with the repo-root default and can fail when vitest isn’t resolved from root.
Suggested doc fix
-- Use coverage when useful: `yarn vitest run --coverage <test-file> --reporter=agent`
+- Use coverage when useful: `cd code && yarn vitest run --coverage <test-file> --reporter=agent`Based on learnings: Tests are located in the code/ directory with root directory for test execution at ./code/.
📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| - Use coverage when useful: `yarn vitest run --coverage <test-file> --reporter=agent` | |
| - Use coverage when useful: `cd code && yarn vitest run --coverage <test-file> --reporter=agent` |
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.
In `@AGENTS.md` at line 230, Update the command example so it explicitly runs from
the code/ workspace: change the coverage example that currently shows `yarn
vitest run --coverage <test-file> --reporter=agent` to run from the project’s
code directory by prefixing with `cd code &&` (so use `cd code && yarn vitest
run --coverage <test-file> --reporter=agent`), ensuring vitest resolves and
tests run with the correct root; update the AGENTS.md entry where that example
string appears.
|
Superseded by #34172 |
github-project-automation
Bot
moved this from In Progress
to Done
in Core Team Projects
1 participant
Closes #
What I did
Checklist for Contributors
Testing
The changes in this PR are covered in the following automated tests:
Manual testing
Caution
This section is mandatory for all contributions. If you believe no manual test is necessary, please state so explicitly. Thanks!
Documentation
MIGRATION.MD
Checklist for Maintainers
When this PR is ready for testing, make sure to add
ci:normal,ci:mergedorci:dailyGH label to it to run a specific set of sandboxes. The particular set of sandboxes can be found incode/lib/cli-storybook/src/sandbox-templates.tsMake sure this PR contains one of the labels below:
Available labels
bug: Internal changes that fixes incorrect behavior.maintenance: User-facing maintenance tasks.dependencies: Upgrading (sometimes downgrading) dependencies.build: Internal-facing build tooling & test updates. Will not show up in release changelog.cleanup: Minor cleanup style change. Will not show up in release changelog.documentation: Documentation only changes. Will not show up in release changelog.feature request: Introducing a new feature.BREAKING CHANGE: Changes that break compatibility in some way with current major version.other: Changes that don't fit in the above categories.🦋 Canary release
This PR does not have a canary release associated. You can request a canary release of this pull request by mentioning the
@storybookjs/coreteam here.core team members can create a canary release here or locally with
gh workflow run --repo storybookjs/storybook publish.yml --field pr=<PR_NUMBER>Summary by CodeRabbit
Chores
Documentation
New Features