Skip to content

fix(actions): fix state mutation and slice direction in ActionLogger #34129

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
saurav61091 wants to merge 2 commits into from
Closed

fix(actions): fix state mutation and slice direction in ActionLogger #34129

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4426694
fix(actions): fix state mutation and slice direction in ActionLogger
saurav61091 Mar 13, 2026
b0d193c
fix(actions): guard against non-positive limit values
saurav61091 Mar 13, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 9 additions & 6 deletions code/core/src/actions/containers/ActionLogger/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,15 +36,18 @@ export default function ActionLogger({ active, api }: ActionLoggerProps) {

const addAction = useCallback((action: ActionDisplay) => {
setActions((prevActions) => {
const newActions = [...prevActions];
const previous = newActions.length && newActions[newActions.length - 1];
const limit = Math.max(0, Number(action.options?.limit) || 0);
const previous = prevActions.length ? prevActions[prevActions.length - 1] : null;

if (previous && safeDeepEqual(previous.data, action.data)) {
previous.count++;
const updated = [...prevActions];
updated[updated.length - 1] = { ...previous, count: previous.count + 1 };
return limit > 0 ? updated.slice(-limit) : updated;
} else {
action.count = 1;
newActions.push(action);
const newAction = { ...action, count: 1 };
const newActions = [...prevActions, newAction];
return limit > 0 ? newActions.slice(-limit) : newActions;
}
return newActions.slice(0, action.options.limit);
});
}, []);

Expand Down