Skip to content

SvelteKit: Fix template stories using runes mode#34128

Merged
yannbf merged 1 commit into
nextfrom
jeppe/fix-svelte-kit-runes-mode
Mar 13, 2026
Merged

SvelteKit: Fix template stories using runes mode#34128
yannbf merged 1 commit into
nextfrom
jeppe/fix-svelte-kit-runes-mode

Conversation

@JReinhold
Copy link
Copy Markdown
Contributor

@JReinhold JReinhold commented Mar 13, 2026

Closes #

What I did

Recent release of sv enforced rune mode for all new SvelteKit apps. We had one component used in template stories that was not using runes, causing CI to fail building.

Checklist for Contributors

Testing

The changes in this PR are covered in the following automated tests:

  • stories
  • unit tests
  • integration tests
  • end-to-end tests

Manual testing

Documentation

  • Add or update documentation reflecting your changes
  • If you are deprecating/removing a feature, make sure to update
    MIGRATION.MD

Checklist for Maintainers

  • When this PR is ready for testing, make sure to add ci:normal, ci:merged or ci:daily GH label to it to run a specific set of sandboxes. The particular set of sandboxes can be found in code/lib/cli-storybook/src/sandbox-templates.ts

  • Make sure this PR contains one of the labels below:

    Available labels
    • bug: Internal changes that fixes incorrect behavior.
    • maintenance: User-facing maintenance tasks.
    • dependencies: Upgrading (sometimes downgrading) dependencies.
    • build: Internal-facing build tooling & test updates. Will not show up in release changelog.
    • cleanup: Minor cleanup style change. Will not show up in release changelog.
    • documentation: Documentation only changes. Will not show up in release changelog.
    • feature request: Introducing a new feature.
    • BREAKING CHANGE: Changes that break compatibility in some way with current major version.
    • other: Changes that don't fit in the above categories.

🦋 Canary release

This PR does not have a canary release associated. You can request a canary release of this pull request by mentioning the @storybookjs/core team here.

core team members can create a canary release here or locally with gh workflow run --repo storybookjs/storybook publish.yml --field pr=<PR_NUMBER>

Summary by CodeRabbit

  • Refactor
    • Updated Navigation component's internal prop handling mechanism for improved consistency.

@JReinhold JReinhold requested a review from Sidnioulz March 13, 2026 10:45
@JReinhold JReinhold self-assigned this Mar 13, 2026
@JReinhold JReinhold added build Internal-facing build tooling & test updates sveltekit labels Mar 13, 2026
@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented Mar 13, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 21c1de9b-312e-4d3d-a382-156bf55c8462

📥 Commits

Reviewing files that changed from the base of the PR and between c39e2e1 and 50f5c3c.

📒 Files selected for processing (1)
  • code/frameworks/sveltekit/template/stories_svelte-kit-skeleton-ts/modules/Navigation.svelte

📝 Walkthrough

Walkthrough

A Svelte component's prop declaration is refactored from using the exported let syntax to the new $props() rune syntax. The component receives afterNavigateFn as an internal destructured prop instead of as a public export, while maintaining the same downstream functionality with the afterNavigate() call.

Changes

Cohort / File(s) Summary
Svelte Component Props Refactoring
code/frameworks/sveltekit/template/stories_svelte-kit-skeleton-ts/modules/Navigation.svelte
Converts exported prop declaration from export let afterNavigateFn; to destructured prop using const { afterNavigateFn } = $props();. Updates component API surface while preserving functional behavior of navigation logic.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

📝 Coding Plan
  • Generate coding plan for human review comments

Comment @coderabbitai help to get the list of available commands and usage tips.

Tip

CodeRabbit can use your project's `biome` configuration to improve the quality of JS/TS/CSS/JSON code reviews.

Add a configuration file to your project to customize how CodeRabbit runs biome.

@yannbf yannbf added the ci:normal Run our default set of CI jobs (choose this for most PRs). label Mar 13, 2026
@yannbf yannbf merged commit 5917ecd into next Mar 13, 2026
18 of 28 checks passed
@yannbf yannbf deleted the jeppe/fix-svelte-kit-runes-mode branch March 13, 2026 11:41
@nx-cloud
Copy link
Copy Markdown

nx-cloud Bot commented Mar 13, 2026

View your CI Pipeline Execution ↗ for commit 50f5c3c

Command Status Duration Result
nx run-many -t compile,check,knip,test,pretty-d... ⛔ Cancelled 31m 9s View ↗

☁️ Nx Cloud last updated this comment at 2026-03-13 12:16:55 UTC

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

build Internal-facing build tooling & test updates ci:normal Run our default set of CI jobs (choose this for most PRs). sveltekit

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants