Skip to content

Maintenance: Support vite-plugin-svelte@7 which supports Vite 8#34115

Merged
valentinpalkovic merged 2 commits into
nextfrom
valentin/vite-plugin-svelte
Mar 12, 2026
Merged

Maintenance: Support vite-plugin-svelte@7 which supports Vite 8#34115
valentinpalkovic merged 2 commits into
nextfrom
valentin/vite-plugin-svelte

Conversation

@valentinpalkovic
Copy link
Copy Markdown
Contributor

@valentinpalkovic valentinpalkovic commented Mar 12, 2026

Closes #

What I did

Checklist for Contributors

Testing

The changes in this PR are covered in the following automated tests:

  • stories
  • unit tests
  • integration tests
  • end-to-end tests

Manual testing

Caution

This section is mandatory for all contributions. If you believe no manual test is necessary, please state so explicitly. Thanks!

Documentation

  • Add or update documentation reflecting your changes
  • If you are deprecating/removing a feature, make sure to update
    MIGRATION.MD

Checklist for Maintainers

  • When this PR is ready for testing, make sure to add ci:normal, ci:merged or ci:daily GH label to it to run a specific set of sandboxes. The particular set of sandboxes can be found in code/lib/cli-storybook/src/sandbox-templates.ts

  • Make sure this PR contains one of the labels below:

    Available labels
    • bug: Internal changes that fixes incorrect behavior.
    • maintenance: User-facing maintenance tasks.
    • dependencies: Upgrading (sometimes downgrading) dependencies.
    • build: Internal-facing build tooling & test updates. Will not show up in release changelog.
    • cleanup: Minor cleanup style change. Will not show up in release changelog.
    • documentation: Documentation only changes. Will not show up in release changelog.
    • feature request: Introducing a new feature.
    • BREAKING CHANGE: Changes that break compatibility in some way with current major version.
    • other: Changes that don't fit in the above categories.

🦋 Canary release

This PR does not have a canary release associated. You can request a canary release of this pull request by mentioning the @storybookjs/core team here.

core team members can create a canary release here or locally with gh workflow run --repo storybookjs/storybook publish.yml --field pr=<PR_NUMBER>

Summary by CodeRabbit

  • Chores
    • Updated to support newer versions of the Svelte Vite plugin, expanding compatibility range.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Mar 12, 2026

Fails
🚫 The "#### Manual testing" section must be filled in. Please describe how to test the changes you've made, step by step, so that reviewers can confirm your PR works as intended.

Generated by 🚫 dangerJS against 647a860

@nx-cloud
Copy link
Copy Markdown

nx-cloud Bot commented Mar 12, 2026

View your CI Pipeline Execution ↗ for commit 647a860

Command Status Duration Result
nx run-many -t compile -c production --parallel=1 ✅ Succeeded 6m 29s View ↗

☁️ Nx Cloud last updated this comment at 2026-03-12 15:24:36 UTC

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented Mar 12, 2026

📝 Walkthrough

Walkthrough

The pull request updates the peer dependency version constraint for @sveltejs/vite-plugin-svelte in a Svelte-Vite framework package to support version 7.0.0 and above.

Changes

Cohort / File(s) Summary
Dependency Version Update
code/frameworks/svelte-vite/package.json
Expands @sveltejs/vite-plugin-svelte peerDependencies version constraint to include ^7.0.0.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

📝 Coding Plan for PR comments
  • Generate coding plan

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Copy Markdown
Contributor

@coderabbitai coderabbitai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧹 Nitpick comments (1)
code/frameworks/svelte-vite/package.json (1)

62-62: PeerDependency change is correct, but devDependencies update suggestion is incompatible.

The peerDependency addition for @sveltejs/vite-plugin-svelte@^7.0.0 is valid. However, updating devDependencies to ^7.0.0 is not feasible as-is. The v7.0.0 release requires Vite ^8.0.0 as a peer dependency, but devDependencies currently pins Vite to ^7.0.4.

To test v7 support during development, you would need to update both devDependencies: Vite to ^8.0.0 and @sveltejs/vite-plugin-svelte to ^7.0.0 together.

🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.

In `@code/frameworks/svelte-vite/package.json` at line 62, The peerDependency
change adding "@sveltejs/vite-plugin-svelte@^7.0.0" is fine but the
devDependency bump for "@sveltejs/vite-plugin-svelte" must be done together with
upgrading Vite; update devDependencies so that both "vite" is bumped to "^8.0.0"
and "@sveltejs/vite-plugin-svelte" is bumped to "^7.0.0" for local testing, or
revert the devDependency change and keep only the peerDependency addition to
avoid the incompatible mix with the current "vite": "^7.0.4".
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.

Nitpick comments:
In `@code/frameworks/svelte-vite/package.json`:
- Line 62: The peerDependency change adding
"@sveltejs/vite-plugin-svelte@^7.0.0" is fine but the devDependency bump for
"@sveltejs/vite-plugin-svelte" must be done together with upgrading Vite; update
devDependencies so that both "vite" is bumped to "^8.0.0" and
"@sveltejs/vite-plugin-svelte" is bumped to "^7.0.0" for local testing, or
revert the devDependency change and keep only the peerDependency addition to
avoid the incompatible mix with the current "vite": "^7.0.4".

ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: baec93e6-c221-49d5-aeed-eee06fb9e15d

📥 Commits

Reviewing files that changed from the base of the PR and between 1ba2d07 and ebe3610.

⛔ Files ignored due to path filters (1)
  • yarn.lock is excluded by !**/yarn.lock, !**/*.lock
📒 Files selected for processing (1)
  • code/frameworks/svelte-vite/package.json

@storybook-app-bot
Copy link
Copy Markdown

Package Benchmarks

Commit: 647a860, ran on 12 March 2026 at 14:58:28 UTC

The following packages have significant changes to their size or dependencies:

@storybook/builder-webpack5

Before After Difference
Dependency count 185 185 0
Self size 76 KB 76 KB 🎉 -48 B 🎉
Dependency size 32.18 MB 32.19 MB 🚨 +14 KB 🚨
Bundle Size Analyzer Link Link

storybook

Before After Difference
Dependency count 49 49 0
Self size 20.21 MB 20.21 MB 🚨 +2 KB 🚨
Dependency size 16.52 MB 16.54 MB 🚨 +17 KB 🚨
Bundle Size Analyzer Link Link

@storybook/angular

Before After Difference
Dependency count 185 185 0
Self size 140 KB 140 KB 🎉 -54 B 🎉
Dependency size 30.39 MB 30.40 MB 🚨 +14 KB 🚨
Bundle Size Analyzer Link Link

@storybook/ember

Before After Difference
Dependency count 189 189 0
Self size 15 KB 15 KB 0 B
Dependency size 28.89 MB 28.91 MB 🚨 +14 KB 🚨
Bundle Size Analyzer Link Link

@storybook/nextjs

Before After Difference
Dependency count 534 534 0
Self size 650 KB 650 KB 0 B
Dependency size 59.89 MB 59.91 MB 🚨 +14 KB 🚨
Bundle Size Analyzer Link Link

@storybook/nextjs-vite

Before After Difference
Dependency count 92 92 0
Self size 1.12 MB 1.12 MB 0 B
Dependency size 22.45 MB 22.47 MB 🚨 +14 KB 🚨
Bundle Size Analyzer Link Link

@storybook/react-native-web-vite

Before After Difference
Dependency count 124 124 0
Self size 30 KB 30 KB 🎉 -18 B 🎉
Dependency size 23.74 MB 23.75 MB 🚨 +14 KB 🚨
Bundle Size Analyzer Link Link

@storybook/react-vite

Before After Difference
Dependency count 82 82 0
Self size 35 KB 35 KB 🚨 +18 B 🚨
Dependency size 20.24 MB 20.25 MB 🚨 +14 KB 🚨
Bundle Size Analyzer Link Link

@storybook/react-webpack5

Before After Difference
Dependency count 271 271 0
Self size 24 KB 24 KB 0 B
Dependency size 44.52 MB 44.53 MB 🚨 +14 KB 🚨
Bundle Size Analyzer Link Link

@storybook/server-webpack5

Before After Difference
Dependency count 197 197 0
Self size 16 KB 16 KB 0 B
Dependency size 33.44 MB 33.45 MB 🚨 +14 KB 🚨
Bundle Size Analyzer Link Link

@storybook/cli

Before After Difference
Dependency count 183 183 0
Self size 779 KB 779 KB 0 B
Dependency size 67.35 MB 67.38 MB 🚨 +33 KB 🚨
Bundle Size Analyzer Link Link

@storybook/codemod

Before After Difference
Dependency count 176 176 0
Self size 32 KB 32 KB 0 B
Dependency size 65.88 MB 65.91 MB 🚨 +33 KB 🚨
Bundle Size Analyzer Link Link

create-storybook

Before After Difference
Dependency count 50 50 0
Self size 1.04 MB 1.04 MB 0 B
Dependency size 36.73 MB 36.75 MB 🚨 +19 KB 🚨
Bundle Size Analyzer node node

@storybook/preset-react-webpack

Before After Difference
Dependency count 167 167 0
Self size 18 KB 18 KB 0 B
Dependency size 31.39 MB 31.40 MB 🚨 +14 KB 🚨
Bundle Size Analyzer Link Link

@storybook/react

Before After Difference
Dependency count 58 58 0
Self size 1.19 MB 1.19 MB 🚨 +6 B 🚨
Dependency size 13.19 MB 13.20 MB 🚨 +14 KB 🚨
Bundle Size Analyzer Link Link

@valentinpalkovic valentinpalkovic merged commit 1210a3a into next Mar 12, 2026
116 of 122 checks passed
@github-project-automation github-project-automation Bot moved this from In Progress to Done in Core Team Projects Mar 12, 2026
@valentinpalkovic valentinpalkovic deleted the valentin/vite-plugin-svelte branch March 12, 2026 15:22
@valentinpalkovic valentinpalkovic added the patch:yes Bugfix & documentation PR that need to be picked to main branch label Mar 13, 2026
@github-actions github-actions Bot mentioned this pull request Mar 13, 2026
6 tasks
valentinpalkovic added a commit that referenced this pull request Mar 13, 2026
Maintenance: Support vite-plugin-svelte@7 which supports Vite 8
(cherry picked from commit 1210a3a)
@github-actions github-actions Bot mentioned this pull request Mar 13, 2026
6 tasks
@github-actions github-actions Bot added the patch:done Patch/release PRs already cherry-picked to main/release branch label Mar 13, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci:normal maintenance User-facing maintenance tasks patch:done Patch/release PRs already cherry-picked to main/release branch patch:yes Bugfix & documentation PR that need to be picked to main branch svelte

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

2 participants