Skip to content

Build: Fix Nx cloud in sandbox generation#34095

Merged
yannbf merged 3 commits into
nextfrom
yann/fix-sandbox-generation-script
Mar 10, 2026
Merged

Build: Fix Nx cloud in sandbox generation#34095
yannbf merged 3 commits into
nextfrom
yann/fix-sandbox-generation-script

Conversation

@yannbf
Copy link
Copy Markdown
Member

@yannbf yannbf commented Mar 10, 2026

Closes #

What I did

The sandbox generation scripts were missing the Nx Cloud token, this PR adds it.

Checklist for Contributors

Testing

The changes in this PR are covered in the following automated tests:

  • stories
  • unit tests
  • integration tests
  • end-to-end tests

Manual testing

Caution

This section is mandatory for all contributions. If you believe no manual test is necessary, please state so explicitly. Thanks!

Documentation

  • Add or update documentation reflecting your changes
  • If you are deprecating/removing a feature, make sure to update
    MIGRATION.MD

Checklist for Maintainers

  • When this PR is ready for testing, make sure to add ci:normal, ci:merged or ci:daily GH label to it to run a specific set of sandboxes. The particular set of sandboxes can be found in code/lib/cli-storybook/src/sandbox-templates.ts

  • Make sure this PR contains one of the labels below:

    Available labels
    • bug: Internal changes that fixes incorrect behavior.
    • maintenance: User-facing maintenance tasks.
    • dependencies: Upgrading (sometimes downgrading) dependencies.
    • build: Internal-facing build tooling & test updates. Will not show up in release changelog.
    • cleanup: Minor cleanup style change. Will not show up in release changelog.
    • documentation: Documentation only changes. Will not show up in release changelog.
    • feature request: Introducing a new feature.
    • BREAKING CHANGE: Changes that break compatibility in some way with current major version.
    • other: Changes that don't fit in the above categories.

🦋 Canary release

This PR does not have a canary release associated. You can request a canary release of this pull request by mentioning the @storybookjs/core team here.

core team members can create a canary release here or locally with gh workflow run --repo storybookjs/storybook publish.yml --field pr=<PR_NUMBER>

Summary by CodeRabbit

  • Chores
    • Updated internal sandbox generation workflow: improved scheduling format, standardized environment variable handling, added cloud access token support, and clarified Node version setup for more reliable sandbox builds.

@yannbf yannbf self-assigned this Mar 10, 2026
@yannbf yannbf added the build Internal-facing build tooling & test updates label Mar 10, 2026
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Mar 10, 2026

Fails
🚫

PR is not labeled with one of: ["ci:normal","ci:merged","ci:daily","ci:docs"]

Generated by 🚫 dangerJS against 577a872

@nx-cloud
Copy link
Copy Markdown

nx-cloud Bot commented Mar 10, 2026

View your CI Pipeline Execution ↗ for commit 824d5d7

Command Status Duration Result
nx run-many -t compile -c production --parallel=1 ✅ Succeeded 7m 44s View ↗

☁️ Nx Cloud last updated this comment at 2026-03-10 16:05:06 UTC

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented Mar 10, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 5425a2cf-e8a3-4304-b586-6d257c2c5915

📥 Commits

Reviewing files that changed from the base of the PR and between 824d5d7 and 577a872.

📒 Files selected for processing (1)
  • .github/workflows/generate-sandboxes.yml
🚧 Files skipped from review as they are similar to previous changes (1)
  • .github/workflows/generate-sandboxes.yml

📝 Walkthrough

Walkthrough

Update to the GitHub Actions workflow .github/workflows/generate-sandboxes.yml that normalizes quoting (cron, env booleans, node-version-file), and adds the NX_CLOUD_ACCESS_TOKEN environment variable.

Changes

Cohort / File(s) Summary
Sandbox workflow
.github/workflows/generate-sandboxes.yml
Changed cron and string quoting from double to single quotes, updated env boolean values to single-quoted 'false'/'true', added NX_CLOUD_ACCESS_TOKEN to env, and standardized node-version-file references to single-quoted '.nvmrc'.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Possibly related PRs

Tip

Try Coding Plans. Let us write the prompt for your AI agent so you can ship faster (with fewer bugs).
Share your feedback on Discord.


Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Copy Markdown
Contributor

@coderabbitai coderabbitai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.

Inline comments:
In @.github/workflows/generate-sandboxes.yml:
- Around line 9-11: Revert the temporary branch override that hardcodes
push.branches to "yann/fix-sandbox-generation-script" and restore the original
branch filters and scheduled-run behavior so the workflow targets the intended
branches (e.g., main/next) instead of the temporary branch; update the
push.branches entry and the scheduled cron trigger (the lines referenced around
the cron and the other overrides) and ensure the sandbox publishing jobs (look
for job names like publish_sandbox or publish) use the real branch context (or a
matrix) rather than the hardcoded temp branch so artifact publishing and
scheduled runs use the correct refs once merged.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 681f7ed1-c955-4606-8b35-508c11600496

📥 Commits

Reviewing files that changed from the base of the PR and between 7b9d207 and 824d5d7.

📒 Files selected for processing (1)
  • .github/workflows/generate-sandboxes.yml

Comment thread .github/workflows/generate-sandboxes.yml Outdated
This reverts commit 824d5d7.
@yannbf yannbf merged commit 4feaa45 into next Mar 10, 2026
11 of 12 checks passed
@yannbf yannbf deleted the yann/fix-sandbox-generation-script branch March 10, 2026 16:20
@github-actions github-actions Bot mentioned this pull request Mar 10, 2026
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

build Internal-facing build tooling & test updates

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants