Skip to content

Build: Restore portable story jobs for Svelte and Next.js#34090

Merged
kasperpeulen merged 2 commits into
nextfrom
kasper/restore-svelte-portable-ci
Mar 10, 2026
Merged

Build: Restore portable story jobs for Svelte and Next.js#34090
kasperpeulen merged 2 commits into
nextfrom
kasper/restore-svelte-portable-ci

Conversation

@kasperpeulen
Copy link
Copy Markdown
Member

@kasperpeulen kasperpeulen commented Mar 10, 2026

Closes #

What I did

Restore the portable story CircleCI jobs for svelte and nextjs so they run again alongside the existing react and vue3 jobs.

Checklist for Contributors

Testing

The changes in this PR are covered in the following automated tests:

  • stories
  • unit tests
  • integration tests
  • end-to-end tests

Manual testing

Caution

This section is mandatory for all contributions. If you believe no manual test is necessary, please state so explicitly. Thanks!

  1. Run yarn workspaces focus @storybook/scripts from the repo root.
  2. Run yarn workspace @storybook/scripts jiti ./ci/main.ts --workflow=normal.
  3. Confirm the generated config includes test-storybooks-portable-svelte and test-storybooks-portable-nextjs.
  4. Run yarn workspace @storybook/scripts jiti ./ci/main.ts --workflow=merged.
  5. Confirm the generated config still includes test-storybooks-portable-svelte, test-storybooks-portable-nextjs, and test-storybooks-portable-vitest3.

Documentation

  • Add or update documentation reflecting your changes
  • If you are deprecating/removing a feature, make sure to update
    MIGRATION.MD

Checklist for Maintainers

  • When this PR is ready for testing, make sure to add ci:normal, ci:merged or ci:daily GH label to it to run a specific set of sandboxes. The particular set of sandboxes can be found in code/lib/cli-storybook/src/sandbox-templates.ts

  • Make sure this PR contains one of the labels below:

    Available labels
    • bug: Internal changes that fixes incorrect behavior.
    • maintenance: User-facing maintenance tasks.
    • dependencies: Upgrading (sometimes downgrading) dependencies.
    • build: Internal-facing build tooling & test updates. Will not show up in release changelog.
    • cleanup: Minor cleanup style change. Will not show up in release changelog.
    • documentation: Documentation only changes. Will not show up in release changelog.
    • feature request: Introducing a new feature.
    • BREAKING CHANGE: Changes that break compatibility in some way with current major version.
    • other: Changes that don't fit in the above categories.

🦋 Canary release

This PR does not have a canary release associated. You can request a canary release of this pull request by mentioning the @storybookjs/core team here.

core team members can create a canary release here or locally with gh workflow run --repo storybookjs/storybook publish.yml --field pr=<PR_NUMBER>

@yannbf yannbf added build Internal-facing build tooling & test updates ci:daily Run the CI jobs that normally run in the daily job. labels Mar 10, 2026
@nx-cloud
Copy link
Copy Markdown

nx-cloud Bot commented Mar 10, 2026

View your CI Pipeline Execution ↗ for commit f27420b

Command Status Duration Result
nx run-many -t compile,check,knip,test,pretty-d... ✅ Succeeded 4m 54s View ↗

☁️ Nx Cloud last updated this comment at 2026-03-10 10:10:30 UTC

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented Mar 10, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: e0c527c0-28e0-4892-bb52-4f048e5d7f48

📥 Commits

Reviewing files that changed from the base of the PR and between 349a45d and d96456f.

📒 Files selected for processing (1)
  • scripts/ci/test-storybooks.ts

📝 Walkthrough

Walkthrough

The getTestStorybooks function in the test CI script was extended to include additional portable storybook test targets. The predefined test targets array was expanded from ['react', 'vue3'] to ['react', 'vue3', 'svelte', 'nextjs'], with no changes to function signatures or control flow logic.

Changes

Cohort / File(s) Summary
Test Target Expansion
scripts/ci/test-storybooks.ts
Extended the portable storybook test targets list to include Svelte and Next.js frameworks alongside React and Vue 3.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

✨ Finishing Touches
  • 📝 Generate docstrings (stacked PR)
  • 📝 Generate docstrings (commit on current branch)

Tip

Try Coding Plans. Let us write the prompt for your AI agent so you can ship faster (with fewer bugs).
Share your feedback on Discord.


Comment @coderabbitai help to get the list of available commands and usage tips.

@kasperpeulen kasperpeulen changed the title Restore portable story CI jobs for Svelte and Next.js CI: Restore portable story jobs for Svelte and Next.js Mar 10, 2026
@kasperpeulen kasperpeulen marked this pull request as draft March 10, 2026 09:41
@kasperpeulen kasperpeulen changed the title CI: Restore portable story jobs for Svelte and Next.js Build: Restore portable story jobs for Svelte and Next.js Mar 10, 2026
@kasperpeulen kasperpeulen added ci:normal and removed ci:daily Run the CI jobs that normally run in the daily job. labels Mar 10, 2026
@kasperpeulen kasperpeulen marked this pull request as ready for review March 10, 2026 10:03
@kasperpeulen kasperpeulen enabled auto-merge March 10, 2026 10:03
@kasperpeulen kasperpeulen disabled auto-merge March 10, 2026 10:10
@kasperpeulen kasperpeulen merged commit 7b9d207 into next Mar 10, 2026
141 of 227 checks passed
@kasperpeulen kasperpeulen deleted the kasper/restore-svelte-portable-ci branch March 10, 2026 10:10
@github-actions github-actions Bot mentioned this pull request Mar 10, 2026
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

build Internal-facing build tooling & test updates ci:normal

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants