Skip to content

Build: Remove vite 8 resolutions#34087

Closed
yannbf wants to merge 2 commits into
nextfrom
yann/remove-vite8-resolutions
Closed

Build: Remove vite 8 resolutions#34087
yannbf wants to merge 2 commits into
nextfrom
yann/remove-vite8-resolutions

Conversation

@yannbf
Copy link
Copy Markdown
Member

@yannbf yannbf commented Mar 10, 2026

Closes #

What I did

This PR removes the Vite 8 resolutions to help us track potential dependency issues.

Checklist for Contributors

Testing

The changes in this PR are covered in the following automated tests:

  • stories
  • unit tests
  • integration tests
  • end-to-end tests

Manual testing

Caution

This section is mandatory for all contributions. If you believe no manual test is necessary, please state so explicitly. Thanks!

Documentation

  • Add or update documentation reflecting your changes
  • If you are deprecating/removing a feature, make sure to update
    MIGRATION.MD

Checklist for Maintainers

  • When this PR is ready for testing, make sure to add ci:normal, ci:merged or ci:daily GH label to it to run a specific set of sandboxes. The particular set of sandboxes can be found in code/lib/cli-storybook/src/sandbox-templates.ts

  • Make sure this PR contains one of the labels below:

    Available labels
    • bug: Internal changes that fixes incorrect behavior.
    • maintenance: User-facing maintenance tasks.
    • dependencies: Upgrading (sometimes downgrading) dependencies.
    • build: Internal-facing build tooling & test updates. Will not show up in release changelog.
    • cleanup: Minor cleanup style change. Will not show up in release changelog.
    • documentation: Documentation only changes. Will not show up in release changelog.
    • feature request: Introducing a new feature.
    • BREAKING CHANGE: Changes that break compatibility in some way with current major version.
    • other: Changes that don't fit in the above categories.

🦋 Canary release

This PR does not have a canary release associated. You can request a canary release of this pull request by mentioning the @storybookjs/core team here.

core team members can create a canary release here or locally with gh workflow run --repo storybookjs/storybook publish.yml --field pr=<PR_NUMBER>

Summary by CodeRabbit

  • Chores
    • Removed Vite beta version workaround for sandbox builds, allowing standard dependency resolution.

@yannbf yannbf self-assigned this Mar 10, 2026
@yannbf yannbf added build Internal-facing build tooling & test updates ci:daily Run the CI jobs that normally run in the daily job. labels Mar 10, 2026
@nx-cloud
Copy link
Copy Markdown

nx-cloud Bot commented Mar 10, 2026

View your CI Pipeline Execution ↗ for commit 66fa745

Command Status Duration Result
nx run-many -t compile -c production --parallel=1 ✅ Succeeded 6m 14s View ↗

☁️ Nx Cloud last updated this comment at 2026-03-19 23:18:13 UTC

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented Mar 10, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: dd7ac2b1-7a0c-40ab-9c8b-064cdc417ba3

📥 Commits

Reviewing files that changed from the base of the PR and between 09ce99c and 335af94.

📒 Files selected for processing (1)
  • scripts/utils/yarn.ts
💤 Files with no reviewable changes (1)
  • scripts/utils/yarn.ts

📝 Walkthrough

Walkthrough

Removes automatic vite dependency version override for Vite-based sandboxes in the yarn workaround resolutions logic, eliminating 7 lines of code that conditionally set vite to version 8.0.0-beta.18.

Changes

Cohort / File(s) Summary
Yarn Workaround Resolutions
scripts/utils/yarn.ts
Removed conditional logic that automatically set vite to 8.0.0-beta.18 for Vite-based sandbox environments in addWorkaroundResolutions function.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Possibly related PRs

✨ Finishing Touches
  • 📝 Generate docstrings (stacked PR)
  • 📝 Generate docstrings (commit on current branch)

Tip

Try Coding Plans. Let us write the prompt for your AI agent so you can ship faster (with fewer bugs).
Share your feedback on Discord.


Comment @coderabbitai help to get the list of available commands and usage tips.

@yannbf yannbf marked this pull request as draft March 11, 2026 09:14
@yannbf yannbf closed this Mar 23, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

build Internal-facing build tooling & test updates ci:daily Run the CI jobs that normally run in the daily job.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants