Skip to content

Build: Bump node in .nvmrc file#34079

Merged
valentinpalkovic merged 1 commit into
nextfrom
valentin/bump-node-version-for-generating-sandboxes
Mar 9, 2026
Merged

Build: Bump node in .nvmrc file#34079
valentinpalkovic merged 1 commit into
nextfrom
valentin/bump-node-version-for-generating-sandboxes

Conversation

@valentinpalkovic
Copy link
Copy Markdown
Contributor

@valentinpalkovic valentinpalkovic commented Mar 9, 2026

Closes #

What I did

Fixing generating sandboxes since Angular prerelease sandboxes require 22.22.x.

Checklist for Contributors

Testing

The changes in this PR are covered in the following automated tests:

  • stories
  • unit tests
  • integration tests
  • end-to-end tests

Manual testing

Caution

This section is mandatory for all contributions. If you believe no manual test is necessary, please state so explicitly. Thanks!

Documentation

  • Add or update documentation reflecting your changes
  • If you are deprecating/removing a feature, make sure to update
    MIGRATION.MD

Checklist for Maintainers

  • When this PR is ready for testing, make sure to add ci:normal, ci:merged or ci:daily GH label to it to run a specific set of sandboxes. The particular set of sandboxes can be found in code/lib/cli-storybook/src/sandbox-templates.ts

  • Make sure this PR contains one of the labels below:

    Available labels
    • bug: Internal changes that fixes incorrect behavior.
    • maintenance: User-facing maintenance tasks.
    • dependencies: Upgrading (sometimes downgrading) dependencies.
    • build: Internal-facing build tooling & test updates. Will not show up in release changelog.
    • cleanup: Minor cleanup style change. Will not show up in release changelog.
    • documentation: Documentation only changes. Will not show up in release changelog.
    • feature request: Introducing a new feature.
    • BREAKING CHANGE: Changes that break compatibility in some way with current major version.
    • other: Changes that don't fit in the above categories.

🦋 Canary release

This PR does not have a canary release associated. You can request a canary release of this pull request by mentioning the @storybookjs/core team here.

core team members can create a canary release here or locally with gh workflow run --repo storybookjs/storybook publish.yml --field pr=<PR_NUMBER>

Summary by CodeRabbit

Release Notes

  • Chores
    • Updated Node.js version requirement to 22.22.1.

@valentinpalkovic valentinpalkovic self-assigned this Mar 9, 2026
@valentinpalkovic valentinpalkovic added ci:normal build Internal-facing build tooling & test updates labels Mar 9, 2026
@nx-cloud
Copy link
Copy Markdown

nx-cloud Bot commented Mar 9, 2026

View your CI Pipeline Execution ↗ for commit 4f47d56

Command Status Duration Result
nx run-many -t compile -c production --parallel=1 ✅ Succeeded 5m 1s View ↗

☁️ Nx Cloud last updated this comment at 2026-03-09 14:38:07 UTC

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Mar 9, 2026

Fails
🚫 The "#### Manual testing" section must be filled in. Please describe how to test the changes you've made, step by step, so that reviewers can confirm your PR works as intended.

Generated by 🚫 dangerJS against 4f47d56

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented Mar 9, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: c92ac4ac-5d43-46bd-80b5-41ad738c0d1d

📥 Commits

Reviewing files that changed from the base of the PR and between f700486 and 4f47d56.

📒 Files selected for processing (1)
  • .nvmrc

📝 Walkthrough

Walkthrough

Node.js version is updated in .nvmrc from 22.21.1 to 22.22.1. This is a minor version bump requiring a single line modification to the version configuration file.

Changes

Cohort / File(s) Summary
Node.js Version Configuration
.nvmrc
Bumped Node.js version from 22.21.1 to 22.22.1.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes


Comment @coderabbitai help to get the list of available commands and usage tips.

@valentinpalkovic valentinpalkovic merged commit 8a09a9d into next Mar 9, 2026
126 of 137 checks passed
@valentinpalkovic valentinpalkovic deleted the valentin/bump-node-version-for-generating-sandboxes branch March 9, 2026 15:03
@github-actions github-actions Bot mentioned this pull request Mar 9, 2026
11 tasks
@yannbf yannbf added the patch:yes Bugfix & documentation PR that need to be picked to main branch label Mar 10, 2026
@github-actions github-actions Bot mentioned this pull request Mar 10, 2026
5 tasks
yannbf pushed a commit that referenced this pull request Mar 13, 2026
…-for-generating-sandboxes

Build: Bump node in .nvmrc file
(cherry picked from commit 8a09a9d)
@github-actions github-actions Bot mentioned this pull request Mar 13, 2026
5 tasks
@github-actions github-actions Bot added the patch:done Patch/release PRs already cherry-picked to main/release branch label Mar 13, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

build Internal-facing build tooling & test updates ci:normal patch:done Patch/release PRs already cherry-picked to main/release branch patch:yes Bugfix & documentation PR that need to be picked to main branch

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants