Skip to content

Add agentic workflow code-simplifier #34058

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
valentinpalkovic merged 3 commits into from
Mar 7, 2026
Merged

Add agentic workflow code-simplifier #34058

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
555b135
Add agentic workflow code-simplifier
valentinpalkovic Mar 7, 2026
40325a8
Refactor code simplifier workflow to enhance clarity and consistency …
valentinpalkovic Mar 7, 2026
bd8ec13
Update lock file
valentinpalkovic Mar 7, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion .gitattributes
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,2 +1,4 @@
/**/.yarn/** linguist-generated
* -text
* -text

@coderabbitai coderabbitai Bot Mar 7, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟠 Major

🧩 Analysis chain

🏁 Script executed:

#!/bin/bash
# Check if there was a previous .gitattributes rule and what it covered
git log -p --follow -1 -- .gitattributes 2>/dev/null | head -50 || echo "No git history available"

# Check for other text-related gitattributes in the repo
cat .gitattributes 2>/dev/null

Repository: storybookjs/storybook

Length of output: 169

Justify the global * -text setting or use more targeted patterns.

The * -text rule disables Git's automatic line ending normalization for all files in the repository. This is a broad setting that could cause inconsistent line endings across different operating systems (Windows vs. Linux/macOS) for contributors.

If this is intentional, add a comment explaining the rationale. If it's meant to apply only to specific file types (e.g., binary files or generated workflows), replace it with more targeted patterns instead.

🤖 Prompt for AI Agents 
Verify each finding against the current code and only fix it if needed.

In @.gitattributes at line 2, The global rule "* -text" in .gitattributes
disables Git's EOL normalization for every file; either add a clear comment
above that line explaining why global disabling is required (e.g., repository
contains mixed binary/generated files that must preserve native line endings) or
replace the broad rule with targeted patterns (e.g., list specific binary or
generated file globs such as *.png, *.jar, build/**, generated/** with "-text")
so only those file types are excluded from normalization; update the single "*
-text" entry accordingly and include a short rationale comment if you decide to
keep a global rule.


.github/workflows/*.lock.yml linguist-generated=true merge=ours
Loading
Loading