Skip to content

Core: Update default allowed hosts in host validation middleware #34045

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ghengeveld merged 1 commit into from
Mar 6, 2026
+4 −6
Merged

Core: Update default allowed hosts in host validation middleware #34045

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 3 additions & 4 deletions code/core/src/core-server/utils/__tests__/getHostValidationMiddleware.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -155,10 +155,9 @@ describe('isValidHost', () => {
expect(isValidHost('127.0.0.1:6006', options)).toBe(true);
});

// TODO: Change default to [] in SB11
it('when allowedHosts is undefined (default true), allows any host', () => {
expect(isValidHost('malicious-site.com', options)).toBe(true);
expect(isValidHost('any-origin.example.com', options)).toBe(true);
it('when allowedHosts is undefined (default []), rejects foreign hosts', () => {
expect(isValidHost('malicious-site.com', options)).toBe(false);
expect(isValidHost('any-origin.example.com', options)).toBe(false);
});

it('when allowedHosts is true, allows any host', () => {
Expand Down
3 changes: 1 addition & 2 deletions code/core/src/core-server/utils/getHostValidationMiddleware.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,8 +4,7 @@ import { isHostAllowed } from 'host-validation-middleware';

import type { Middleware } from '../../types';

// TODO: Change to `[]` in SB11 to change from opt-in to opt-out
export const DEFAULT_ALLOWED_HOSTS: string[] | true = true;
export const DEFAULT_ALLOWED_HOSTS: string[] | true = [];

export type HostValidationOptions = {
host?: string;
Expand Down
Loading