Build: Upgrade husky from v4 to v9#34027
Merged
Merged
Conversation
Contributor
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (4)
💤 Files with no reviewable changes (2)
📝 WalkthroughWalkthroughThis PR consolidates Husky Git hooks configuration from subdirectory package.json files to the root level. It removes husky from code/ and scripts/ package.json files, adds husky as a devDependency to the root package.json with a prepare script, and introduces a new .husky/pre-commit hook that conditionally runs lint-staged. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~12 minutes Comment |
bd11a6b to
78601a6
Compare
Husky v4 configured hooks via package.json and used husky.local.sh for path resolution, which broke in git worktrees (the monorepo cd path got overwritten on every yarn install). Husky v9 uses plain shell scripts in .husky/ and sets core.hooksPath, which works correctly across worktrees without any postinstall hacks. - Replace package.json husky config with .husky/pre-commit script - Add prepare script and husky dependency to root package.json - Run lint-staged in both code/ and scripts/ directories - Preserve SKIP_STORYBOOK_GIT_HOOKS escape hatch - Remove husky v4 from code/ and scripts/ package.json
78601a6 to
2621d24
Compare
|
View your CI Pipeline Execution ↗ for commit 2621d24
☁️ Nx Cloud last updated this comment at |
This was referenced Mar 5, 2026
8 tasks
8 tasks
8 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What I did
Upgraded husky from v4 to v9 to fix git hooks breaking in worktrees.
Husky v4 configured hooks via
package.jsonand usedhusky.local.shfor path resolution, which got overwritten on everyyarn installin a worktree (the monorepocdpath was wrong).Husky v9 uses plain shell scripts in
.husky/andcore.hooksPath, which works correctly across worktrees.package.jsonhusky config with.husky/pre-commitshell scriptpreparescript and husky dependency to rootpackage.jsonlint-stagedin bothcode/andscripts/directoriesSKIP_STORYBOOK_GIT_HOOKSescape hatchcode/andscripts/package.jsonChecklist for Contributors
Testing
The changes in this PR are covered in the following automated tests:
Manual testing
Caution
This section is mandatory for all contributions. If you believe no manual test is necessary, please state so explicitly. Thanks!
yarn installat the repo root — verifygit config core.hooksPathis.husky/_SKIP_STORYBOOK_GIT_HOOKS=1— verify hooks are skippedDocumentation
MIGRATION.MD
Checklist for Maintainers
When this PR is ready for testing, make sure to add
ci:normal,ci:mergedorci:dailyGH label to it to run a specific set of sandboxes. The particular set of sandboxes can be found incode/lib/cli-storybook/src/sandbox-templates.tsMake sure this PR contains one of the labels below:
Available labels
bug: Internal changes that fixes incorrect behavior.maintenance: User-facing maintenance tasks.dependencies: Upgrading (sometimes downgrading) dependencies.build: Internal-facing build tooling & test updates. Will not show up in release changelog.cleanup: Minor cleanup style change. Will not show up in release changelog.documentation: Documentation only changes. Will not show up in release changelog.feature request: Introducing a new feature.BREAKING CHANGE: Changes that break compatibility in some way with current major version.other: Changes that don't fit in the above categories.🦋 Canary release
This PR does not have a canary release associated. You can request a canary release of this pull request by mentioning the
@storybookjs/coreteam here.core team members can create a canary release here or locally with
gh workflow run --repo storybookjs/storybook publish.yml --field pr=<PR_NUMBER>