Skip to content

Test: Update @testing-library/jest-dom#33928

Merged
valentinpalkovic merged 1 commit intonextfrom
valentin/update-testing-library-jest-dom
Feb 26, 2026
Merged

Test: Update @testing-library/jest-dom#33928
valentinpalkovic merged 1 commit intonextfrom
valentin/update-testing-library-jest-dom

Conversation

@valentinpalkovic
Copy link
Copy Markdown
Contributor

@valentinpalkovic valentinpalkovic commented Feb 25, 2026

Closes #33921

What I did

Checklist for Contributors

Testing

The changes in this PR are covered in the following automated tests:

  • stories
  • unit tests
  • integration tests
  • end-to-end tests

Manual testing

Caution

This section is mandatory for all contributions. If you believe no manual test is necessary, please state so explicitly. Thanks!

  1. Run a sandbox for template, e.g. yarn task --task sandbox --start-from auto --template react-vite/default-ts
  2. Open Storybook in your browser
  3. Access a story which uses play functions and testing library-like assertions
  4. They should work as intended, both in Storybook and in Vitest

Documentation

  • Add or update documentation reflecting your changes
  • If you are deprecating/removing a feature, make sure to update
    MIGRATION.MD

Checklist for Maintainers

  • When this PR is ready for testing, make sure to add ci:normal, ci:merged or ci:daily GH label to it to run a specific set of sandboxes. The particular set of sandboxes can be found in code/lib/cli-storybook/src/sandbox-templates.ts

  • Make sure this PR contains one of the labels below:

    Available labels
    • bug: Internal changes that fixes incorrect behavior.
    • maintenance: User-facing maintenance tasks.
    • dependencies: Upgrading (sometimes downgrading) dependencies.
    • build: Internal-facing build tooling & test updates. Will not show up in release changelog.
    • cleanup: Minor cleanup style change. Will not show up in release changelog.
    • documentation: Documentation only changes. Will not show up in release changelog.
    • feature request: Introducing a new feature.
    • BREAKING CHANGE: Changes that break compatibility in some way with current major version.
    • other: Changes that don't fit in the above categories.

🦋 Canary release

This PR does not have a canary release associated. You can request a canary release of this pull request by mentioning the @storybookjs/core team here.

core team members can create a canary release here or locally with gh workflow run --repo storybookjs/storybook publish.yml --field pr=<PR_NUMBER>

Summary by CodeRabbit

  • Chores
    • Updated testing library dependency to the latest compatible version across all project packages.

@nx-cloud
Copy link
Copy Markdown

nx-cloud bot commented Feb 25, 2026

View your CI Pipeline Execution ↗ for commit c5631da

Command Status Duration Result
nx run-many -t compile,check,knip,test,pretty-d... ❌ Failed 11m 5s View ↗

☁️ Nx Cloud last updated this comment at 2026-02-25 14:57:49 UTC

@storybook-app-bot
Copy link
Copy Markdown

Package Benchmarks

Commit: c5631da, ran on 25 February 2026 at 15:00:39 UTC

The following packages have significant changes to their size or dependencies:

storybook

Before After Difference
Dependency count 49 49 0
Self size 20.42 MB 20.19 MB 🎉 -227 KB 🎉
Dependency size 16.52 MB 16.52 MB 0 B
Bundle Size Analyzer Link Link

@storybook/cli

Before After Difference
Dependency count 183 183 0
Self size 779 KB 779 KB 🎉 -84 B 🎉
Dependency size 67.65 MB 67.42 MB 🎉 -227 KB 🎉
Bundle Size Analyzer Link Link

@storybook/codemod

Before After Difference
Dependency count 176 176 0
Self size 32 KB 32 KB 0 B
Dependency size 66.17 MB 65.95 MB 🎉 -227 KB 🎉
Bundle Size Analyzer Link Link

create-storybook

Before After Difference
Dependency count 50 50 0
Self size 1.04 MB 1.04 MB 🎉 -72 B 🎉
Dependency size 36.94 MB 36.72 MB 🎉 -227 KB 🎉
Bundle Size Analyzer node node

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai bot commented Feb 25, 2026

📝 Walkthrough

Walkthrough

Updates the @testing-library/jest-dom dependency from version ^6.6.3 to ^6.9.1 across three package.json files in the code/core, code, and scripts directories.

Changes

Cohort / File(s) Summary
Dependency Version Bumps
code/core/package.json, code/package.json, scripts/package.json
Updated @testing-library/jest-dom from ^6.6.3 to ^6.9.1 across all three package.json files.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Tip

Try Coding Plans. Let us write the prompt for your AI agent so you can ship faster (with fewer bugs).
Share your feedback on Discord.


Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Copy Markdown
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

♻️ Duplicate comments (2)
code/package.json (1)

113-113: Same verification as above applies to this bump.

No additional concerns specific to Line 113 beyond the shared lockfile-resolution and lint verification already requested.

🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.

In `@code/package.json` at line 113, Bump of "@testing-library/jest-dom" must be
verified the same way as the previous dependency bump: update the lockfile by
running your package manager install (npm install or yarn install) so
package-lock.json / yarn.lock reflects the change, run the test suite and
linting (including any CI lint/format checks) to ensure no regressions, and
commit the updated lockfile alongside the package.json change; reference the
dependency name "@testing-library/jest-dom" when confirming the lockfile was
updated and include the lint/test verification in your PR description or CI run
results.
code/core/package.json (1)

233-233: Same verification as above applies to this bump.

No additional concerns specific to Line 233 beyond the shared lockfile-resolution and lint verification already requested.

🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.

In `@code/core/package.json` at line 233, This dependency version bump for
"@testing-library/jest-dom" needs the same verification as the other bumps:
update the lockfile and ensure lint/CI pass. Run the package manager install
(e.g., npm install or pnpm install) so package-lock.json / pnpm-lock.yaml is
updated, commit the updated lockfile alongside the package.json change, and run
the lint/test CI locally (or via your project's lint script) to confirm no new
lint or dependency issues before pushing; reference the
"@testing-library/jest-dom" entry in package.json when locating the change.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.

Duplicate comments:
In `@code/core/package.json`:
- Line 233: This dependency version bump for "@testing-library/jest-dom" needs
the same verification as the other bumps: update the lockfile and ensure lint/CI
pass. Run the package manager install (e.g., npm install or pnpm install) so
package-lock.json / pnpm-lock.yaml is updated, commit the updated lockfile
alongside the package.json change, and run the lint/test CI locally (or via your
project's lint script) to confirm no new lint or dependency issues before
pushing; reference the "@testing-library/jest-dom" entry in package.json when
locating the change.

In `@code/package.json`:
- Line 113: Bump of "@testing-library/jest-dom" must be verified the same way as
the previous dependency bump: update the lockfile by running your package
manager install (npm install or yarn install) so package-lock.json / yarn.lock
reflects the change, run the test suite and linting (including any CI
lint/format checks) to ensure no regressions, and commit the updated lockfile
alongside the package.json change; reference the dependency name
"@testing-library/jest-dom" when confirming the lockfile was updated and include
the lint/test verification in your PR description or CI run results.

ℹ️ Review info

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 22eff0e and c5631da.

⛔ Files ignored due to path filters (1)
  • yarn.lock is excluded by !**/yarn.lock, !**/*.lock
📒 Files selected for processing (3)
  • code/core/package.json
  • code/package.json
  • scripts/package.json

@valentinpalkovic valentinpalkovic merged commit 6c85f9b into next Feb 26, 2026
129 of 142 checks passed
@valentinpalkovic valentinpalkovic deleted the valentin/update-testing-library-jest-dom branch February 26, 2026 08:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: downgrade in @testing-library/jest-dom in Storybook 10.2.x causes Invalid Chai property: toBePressed

2 participants