Test: Update @testing-library/jest-dom#33928
Conversation
|
View your CI Pipeline Execution ↗ for commit c5631da
☁️ Nx Cloud last updated this comment at |
Package BenchmarksCommit: The following packages have significant changes to their size or dependencies:
|
| Before | After | Difference | |
|---|---|---|---|
| Dependency count | 49 | 49 | 0 |
| Self size | 20.42 MB | 20.19 MB | 🎉 -227 KB 🎉 |
| Dependency size | 16.52 MB | 16.52 MB | 0 B |
| Bundle Size Analyzer | Link | Link |
@storybook/cli
| Before | After | Difference | |
|---|---|---|---|
| Dependency count | 183 | 183 | 0 |
| Self size | 779 KB | 779 KB | 🎉 -84 B 🎉 |
| Dependency size | 67.65 MB | 67.42 MB | 🎉 -227 KB 🎉 |
| Bundle Size Analyzer | Link | Link |
@storybook/codemod
| Before | After | Difference | |
|---|---|---|---|
| Dependency count | 176 | 176 | 0 |
| Self size | 32 KB | 32 KB | 0 B |
| Dependency size | 66.17 MB | 65.95 MB | 🎉 -227 KB 🎉 |
| Bundle Size Analyzer | Link | Link |
create-storybook
| Before | After | Difference | |
|---|---|---|---|
| Dependency count | 50 | 50 | 0 |
| Self size | 1.04 MB | 1.04 MB | 🎉 -72 B 🎉 |
| Dependency size | 36.94 MB | 36.72 MB | 🎉 -227 KB 🎉 |
| Bundle Size Analyzer | node | node |
📝 WalkthroughWalkthroughUpdates the Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes Tip Try Coding Plans. Let us write the prompt for your AI agent so you can ship faster (with fewer bugs). Comment |
There was a problem hiding this comment.
♻️ Duplicate comments (2)
code/package.json (1)
113-113: Same verification as above applies to this bump.No additional concerns specific to Line 113 beyond the shared lockfile-resolution and lint verification already requested.
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@code/package.json` at line 113, Bump of "@testing-library/jest-dom" must be verified the same way as the previous dependency bump: update the lockfile by running your package manager install (npm install or yarn install) so package-lock.json / yarn.lock reflects the change, run the test suite and linting (including any CI lint/format checks) to ensure no regressions, and commit the updated lockfile alongside the package.json change; reference the dependency name "@testing-library/jest-dom" when confirming the lockfile was updated and include the lint/test verification in your PR description or CI run results.code/core/package.json (1)
233-233: Same verification as above applies to this bump.No additional concerns specific to Line 233 beyond the shared lockfile-resolution and lint verification already requested.
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@code/core/package.json` at line 233, This dependency version bump for "@testing-library/jest-dom" needs the same verification as the other bumps: update the lockfile and ensure lint/CI pass. Run the package manager install (e.g., npm install or pnpm install) so package-lock.json / pnpm-lock.yaml is updated, commit the updated lockfile alongside the package.json change, and run the lint/test CI locally (or via your project's lint script) to confirm no new lint or dependency issues before pushing; reference the "@testing-library/jest-dom" entry in package.json when locating the change.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Duplicate comments:
In `@code/core/package.json`:
- Line 233: This dependency version bump for "@testing-library/jest-dom" needs
the same verification as the other bumps: update the lockfile and ensure lint/CI
pass. Run the package manager install (e.g., npm install or pnpm install) so
package-lock.json / pnpm-lock.yaml is updated, commit the updated lockfile
alongside the package.json change, and run the lint/test CI locally (or via your
project's lint script) to confirm no new lint or dependency issues before
pushing; reference the "@testing-library/jest-dom" entry in package.json when
locating the change.
In `@code/package.json`:
- Line 113: Bump of "@testing-library/jest-dom" must be verified the same way as
the previous dependency bump: update the lockfile by running your package
manager install (npm install or yarn install) so package-lock.json / yarn.lock
reflects the change, run the test suite and linting (including any CI
lint/format checks) to ensure no regressions, and commit the updated lockfile
alongside the package.json change; reference the dependency name
"@testing-library/jest-dom" when confirming the lockfile was updated and include
the lint/test verification in your PR description or CI run results.
ℹ️ Review info
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
⛔ Files ignored due to path filters (1)
yarn.lockis excluded by!**/yarn.lock,!**/*.lock
📒 Files selected for processing (3)
code/core/package.jsoncode/package.jsonscripts/package.json
Closes #33921
What I did
Checklist for Contributors
Testing
The changes in this PR are covered in the following automated tests:
Manual testing
Caution
This section is mandatory for all contributions. If you believe no manual test is necessary, please state so explicitly. Thanks!
yarn task --task sandbox --start-from auto --template react-vite/default-tsDocumentation
MIGRATION.MD
Checklist for Maintainers
When this PR is ready for testing, make sure to add
ci:normal,ci:mergedorci:dailyGH label to it to run a specific set of sandboxes. The particular set of sandboxes can be found incode/lib/cli-storybook/src/sandbox-templates.tsMake sure this PR contains one of the labels below:
Available labels
bug: Internal changes that fixes incorrect behavior.maintenance: User-facing maintenance tasks.dependencies: Upgrading (sometimes downgrading) dependencies.build: Internal-facing build tooling & test updates. Will not show up in release changelog.cleanup: Minor cleanup style change. Will not show up in release changelog.documentation: Documentation only changes. Will not show up in release changelog.feature request: Introducing a new feature.BREAKING CHANGE: Changes that break compatibility in some way with current major version.other: Changes that don't fit in the above categories.🦋 Canary release
This PR does not have a canary release associated. You can request a canary release of this pull request by mentioning the
@storybookjs/coreteam here.core team members can create a canary release here or locally with
gh workflow run --repo storybookjs/storybook publish.yml --field pr=<PR_NUMBER>Summary by CodeRabbit