Skip to content

Build: Use HTTP check instead of detect-port for service readiness to prevent EADDRINUSE #33924

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
valentinpalkovic merged 2 commits into from
Feb 25, 2026
+12 −4
Merged

Build: Use HTTP check instead of detect-port for service readiness to prevent EADDRINUSE #33924

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
029f36d
Initial plan
Copilot Feb 25, 2026
810c15c
fix: use HTTP check instead of detect-port for dev/serve ready() to p…
Copilot Feb 25, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions scripts/tasks/dev.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,3 @@
import detectFreePort from 'detect-port';
import waitOn from 'wait-on';

import type { AllTemplatesKey } from '../../code/lib/cli-storybook/src/sandbox-templates';
Expand All @@ -21,7 +20,12 @@ export const dev: Task = {
dependsOn: ['sandbox'],
async ready({ key }) {
const port = getDevPort(key);
return (await detectFreePort(port)) !== port;
try {
await fetch(`http://localhost:${port}/iframe.html`, { signal: AbortSignal.timeout(1000) });
return true;
} catch {
return false;
}
},
async run({ sandboxDir, key, selectedTask }, { dryRun, debug }) {
const controller = new AbortController();
Expand Down
8 changes: 6 additions & 2 deletions scripts/tasks/serve.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,3 @@
import detectFreePort from 'detect-port';
import waitOn from 'wait-on';

import type { AllTemplatesKey } from '../../code/lib/cli-storybook/src/sandbox-templates';
Expand All @@ -21,7 +20,12 @@ export const serve: Task = {
dependsOn: ['build'],
async ready({ key }) {
const port = getServePort(key);
return (await detectFreePort(port)) !== port;
try {
await fetch(`http://localhost:${port}/iframe.html`, { signal: AbortSignal.timeout(1000) });
return true;
} catch {
return false;
}
},
async run({ builtSandboxDir, key }, { debug, dryRun }) {
const port = getServePort(key);
Expand Down
Loading