Skip to content

Core: Storybook failed to load iframe.html when publishing #33896

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
valentinpalkovic merged 2 commits into from
Mar 3, 2026
Merged

Core: Storybook failed to load iframe.html when publishing #33896

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ed5064e
fix(manager-api): correctly resolve iframe.html URL when hosted at a …
Feb 21, 2026
601bd11
Merge branch 'next' into fix/issue-33848
valentinpalkovic Feb 25, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion code/core/src/manager-api/modules/url.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -254,7 +254,8 @@ export const init: ModuleFn<SubAPI, SubState> = (moduleArgs) => {
base === 'origin' ? originAddress : base === 'network' ? networkAddress : pathname;
const previewBase = refId
? refs[refId].url + '/iframe.html'
: global.PREVIEW_URL || `${managerBase.replace(/\/[^/]*$/, '/')}iframe.html`;
: global.PREVIEW_URL ||
`${managerBase.replace(/\/[^/]*\.html$/, '').replace(/\/?$/, '/')}iframe.html`;

const refParam = refId ? `&refId=${encodeURIComponent(refId)}` : '';
const { args = '', globals = '', ...otherParams } = queryParams;
Expand Down
45 changes: 45 additions & 0 deletions code/core/src/manager-api/tests/url.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -486,4 +486,49 @@ describe('getStoryHrefs', () => {
expect(managerHref).toEqual('/index.html?path=/story/test--story');
expect(previewHref).toEqual('/iframe.html?id=test--story&viewMode=story');
});

it('correctly links when hosted at a subpath without trailing slash', () => {
const { api, state } = initURL({
store,
provider: { channel: new EventEmitter() },
state: { location: { pathname: '/design-system', search: '' } },
navigate: vi.fn(),
fullAPI: { getCurrentStoryData: () => ({ id: 'test--story' }) },
});
store.setState(state);

const { managerHref, previewHref } = api.getStoryHrefs('test--story');
expect(managerHref).toEqual('/design-system?path=/story/test--story');
expect(previewHref).toEqual('/design-system/iframe.html?id=test--story&viewMode=story');
});

it('correctly links when hosted at a subpath with trailing slash', () => {
const { api, state } = initURL({
store,
provider: { channel: new EventEmitter() },
state: { location: { pathname: '/design-system/', search: '' } },
navigate: vi.fn(),
fullAPI: { getCurrentStoryData: () => ({ id: 'test--story' }) },
});
store.setState(state);

const { managerHref, previewHref } = api.getStoryHrefs('test--story');
expect(managerHref).toEqual('/design-system/?path=/story/test--story');
expect(previewHref).toEqual('/design-system/iframe.html?id=test--story&viewMode=story');
});

it('correctly links when hosted at a subpath with index.html', () => {
const { api, state } = initURL({
store,
provider: { channel: new EventEmitter() },
state: { location: { pathname: '/design-system/index.html', search: '' } },
navigate: vi.fn(),
fullAPI: { getCurrentStoryData: () => ({ id: 'test--story' }) },
});
store.setState(state);

const { managerHref, previewHref } = api.getStoryHrefs('test--story');
expect(managerHref).toEqual('/design-system/index.html?path=/story/test--story');
expect(previewHref).toEqual('/design-system/iframe.html?id=test--story&viewMode=story');
});
});
Loading