Skip to content

Disable highly flakey test#33882

Merged
valentinpalkovic merged 1 commit into
nextfrom
valentin/remove-flaky-e2e-test
Feb 20, 2026
Merged

Disable highly flakey test#33882
valentinpalkovic merged 1 commit into
nextfrom
valentin/remove-flaky-e2e-test

Conversation

@valentinpalkovic
Copy link
Copy Markdown
Contributor

@valentinpalkovic valentinpalkovic commented Feb 20, 2026

Closes #

What I did

Checklist for Contributors

Testing

The changes in this PR are covered in the following automated tests:

  • stories
  • unit tests
  • integration tests
  • end-to-end tests

Manual testing

Caution

This section is mandatory for all contributions. If you believe no manual test is necessary, please state so explicitly. Thanks!

Documentation

  • Add or update documentation reflecting your changes
  • If you are deprecating/removing a feature, make sure to update
    MIGRATION.MD

Checklist for Maintainers

  • When this PR is ready for testing, make sure to add ci:normal, ci:merged or ci:daily GH label to it to run a specific set of sandboxes. The particular set of sandboxes can be found in code/lib/cli-storybook/src/sandbox-templates.ts

  • Make sure this PR contains one of the labels below:

    Available labels
    • bug: Internal changes that fixes incorrect behavior.
    • maintenance: User-facing maintenance tasks.
    • dependencies: Upgrading (sometimes downgrading) dependencies.
    • build: Internal-facing build tooling & test updates. Will not show up in release changelog.
    • cleanup: Minor cleanup style change. Will not show up in release changelog.
    • documentation: Documentation only changes. Will not show up in release changelog.
    • feature request: Introducing a new feature.
    • BREAKING CHANGE: Changes that break compatibility in some way with current major version.
    • other: Changes that don't fit in the above categories.

🦋 Canary release

This PR does not have a canary release associated. You can request a canary release of this pull request by mentioning the @storybookjs/core team here.

core team members can create a canary release here or locally with gh workflow run --repo storybookjs/storybook publish.yml --field pr=<PR_NUMBER>

Summary by CodeRabbit

  • Tests
    • Temporarily disabled a flaky e2e test for preview API rendering behavior to prevent unreliable test results. The test will be re-enabled once the underlying issue is resolved.

@valentinpalkovic valentinpalkovic self-assigned this Feb 20, 2026
@valentinpalkovic valentinpalkovic added the build Internal-facing build tooling & test updates label Feb 20, 2026
@valentinpalkovic valentinpalkovic moved this to In Progress in Core Team Projects Feb 20, 2026
@github-actions
Copy link
Copy Markdown
Contributor

Fails
🚫

PR is not labeled with one of: ["ci:normal","ci:merged","ci:daily","ci:docs"]

🚫 PR title must be in the format of "Area: Summary", With both Area and Summary starting with a capital letter Good examples: - "Docs: Describe Canvas Doc Block" - "Svelte: Support Svelte v4" Bad examples: - "add new api docs" - "fix: Svelte 4 support" - "Vue: improve docs"
🚫 The "#### Manual testing" section must be filled in. Please describe how to test the changes you've made, step by step, so that reviewers can confirm your PR works as intended.

Generated by 🚫 dangerJS against c37fa17

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented Feb 20, 2026

📝 Walkthrough

Walkthrough

A single E2E test in preview-api.spec.ts is marked as skipped with a comment indicating a flakiness issue requires resolution before re-enabling. The test body remains unchanged.

Changes

Cohort / File(s) Summary
Test Skip
code/e2e-tests/preview-api.spec.ts
Marked "should only render once at a time when rapidly changing args" test as skipped (it.skip) with comment noting flake must be fixed before re-enabling.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Possibly related PRs

  • E2E: Fix flakey test #33683: Also addresses the same flaky "should only render once at a time when rapidly changing args" test by modifying input simulation strategy with pressSequentially, creating complementary approaches to the same flakiness issue.
✨ Finishing Touches
  • 📝 Generate docstrings (stacked PR)
  • 📝 Generate docstrings (commit on current branch)

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Copy Markdown
Contributor

@coderabbitai coderabbitai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧹 Nitpick comments (1)
code/e2e-tests/preview-api.spec.ts (1)

57-60: Add a tracking reference for the skip.

To prevent this from becoming a permanent skip, consider linking a GitHub issue/PR (or adding a target re-enable date) in the TODO so it’s actionable.

💡 Suggested update
-  // TODO: ENABLE again once the flake is fixed
+  // TODO(`#ISSUE_ID`): Re-enable once the flake is fixed (target: YYYY-MM-DD)
  test.skip('should only render once at a time when rapidly changing args', async ({ page }) => {
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.

In `@code/e2e-tests/preview-api.spec.ts` around lines 57 - 60, Update the skipped
test declaration so the TODO includes a tracking reference: find the test marked
via test.skip('should only render once at a time when rapidly changing args',
...) and update the surrounding TODO/comment to include a GitHub issue or PR
link (or a target re-enable date) so the skip is actionable and traceable; keep
the skip in place but add the reference directly next to the TODO and include a
short rationale string so reviewers can find and close the skip later.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.

Nitpick comments:
In `@code/e2e-tests/preview-api.spec.ts`:
- Around line 57-60: Update the skipped test declaration so the TODO includes a
tracking reference: find the test marked via test.skip('should only render once
at a time when rapidly changing args', ...) and update the surrounding
TODO/comment to include a GitHub issue or PR link (or a target re-enable date)
so the skip is actionable and traceable; keep the skip in place but add the
reference directly next to the TODO and include a short rationale string so
reviewers can find and close the skip later.

@valentinpalkovic valentinpalkovic merged commit 3f68d91 into next Feb 20, 2026
13 of 17 checks passed
@github-project-automation github-project-automation Bot moved this from In Progress to Done in Core Team Projects Feb 20, 2026
@valentinpalkovic valentinpalkovic deleted the valentin/remove-flaky-e2e-test branch February 20, 2026 12:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

build Internal-facing build tooling & test updates

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

1 participant