Disable highly flakey test#33882
Merged
Merged
Conversation
Contributor
|
Contributor
📝 WalkthroughWalkthroughA single E2E test in Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Possibly related PRs
✨ Finishing Touches
Comment |
Contributor
There was a problem hiding this comment.
🧹 Nitpick comments (1)
code/e2e-tests/preview-api.spec.ts (1)
57-60: Add a tracking reference for the skip.To prevent this from becoming a permanent skip, consider linking a GitHub issue/PR (or adding a target re-enable date) in the TODO so it’s actionable.
💡 Suggested update
- // TODO: ENABLE again once the flake is fixed + // TODO(`#ISSUE_ID`): Re-enable once the flake is fixed (target: YYYY-MM-DD) test.skip('should only render once at a time when rapidly changing args', async ({ page }) => {🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@code/e2e-tests/preview-api.spec.ts` around lines 57 - 60, Update the skipped test declaration so the TODO includes a tracking reference: find the test marked via test.skip('should only render once at a time when rapidly changing args', ...) and update the surrounding TODO/comment to include a GitHub issue or PR link (or a target re-enable date) so the skip is actionable and traceable; keep the skip in place but add the reference directly next to the TODO and include a short rationale string so reviewers can find and close the skip later.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Nitpick comments:
In `@code/e2e-tests/preview-api.spec.ts`:
- Around line 57-60: Update the skipped test declaration so the TODO includes a
tracking reference: find the test marked via test.skip('should only render once
at a time when rapidly changing args', ...) and update the surrounding
TODO/comment to include a GitHub issue or PR link (or a target re-enable date)
so the skip is actionable and traceable; keep the skip in place but add the
reference directly next to the TODO and include a short rationale string so
reviewers can find and close the skip later.
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #
What I did
Checklist for Contributors
Testing
The changes in this PR are covered in the following automated tests:
Manual testing
Caution
This section is mandatory for all contributions. If you believe no manual test is necessary, please state so explicitly. Thanks!
Documentation
MIGRATION.MD
Checklist for Maintainers
When this PR is ready for testing, make sure to add
ci:normal,ci:mergedorci:dailyGH label to it to run a specific set of sandboxes. The particular set of sandboxes can be found incode/lib/cli-storybook/src/sandbox-templates.tsMake sure this PR contains one of the labels below:
Available labels
bug: Internal changes that fixes incorrect behavior.maintenance: User-facing maintenance tasks.dependencies: Upgrading (sometimes downgrading) dependencies.build: Internal-facing build tooling & test updates. Will not show up in release changelog.cleanup: Minor cleanup style change. Will not show up in release changelog.documentation: Documentation only changes. Will not show up in release changelog.feature request: Introducing a new feature.BREAKING CHANGE: Changes that break compatibility in some way with current major version.other: Changes that don't fit in the above categories.🦋 Canary release
This PR does not have a canary release associated. You can request a canary release of this pull request by mentioning the
@storybookjs/coreteam here.core team members can create a canary release here or locally with
gh workflow run --repo storybookjs/storybook publish.yml --field pr=<PR_NUMBER>Summary by CodeRabbit