Skip to content

Core: Revert Pull Request #33420 from Maelryn/fix/copy-button-overlap#33877

Merged
Sidnioulz merged 1 commit intonextfrom
sidnioulz/revert-copy-button-overflow-pr
Feb 20, 2026
Merged

Core: Revert Pull Request #33420 from Maelryn/fix/copy-button-overlap#33877
Sidnioulz merged 1 commit intonextfrom
sidnioulz/revert-copy-button-overflow-pr

Conversation

@Sidnioulz
Copy link
Copy Markdown
Member

@Sidnioulz Sidnioulz commented Feb 20, 2026

This reverts commit ecc7fa8, reversing changes made to 518c70c.

The PR's latest commits introduced UI layout regressions I failed to catch. Let's revert it and I'll write another PR without the regressions.

Summary by CodeRabbit

  • Refactor

    • Simplified layout styling in preview and code syntax highlighter components by removing flex constraints and width limitations for more flexible rendering.
    • Standardized action bar component implementation across components.
  • Style

    • Adjusted horizontal padding in code syntax highlighting for improved visual balance.

@Sidnioulz Sidnioulz added maintenance User-facing maintenance tasks ci:normal labels Feb 20, 2026
@Sidnioulz Sidnioulz changed the title Revert "Merge pull request #33420 from Maelryn/fix/copy-button-overlap" Revert: Pull Request #33420 from Maelryn/fix/copy-button-overlap Feb 20, 2026
@nx-cloud
Copy link
Copy Markdown

nx-cloud bot commented Feb 20, 2026

View your CI Pipeline Execution ↗ for commit 48f3d08

Command Status Duration Result
nx run-many -t compile,check,knip,test,pretty-d... ❌ Failed 3m 6s View ↗

☁️ Nx Cloud last updated this comment at 2026-02-20 09:33:35 UTC

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai bot commented Feb 20, 2026

No actionable comments were generated in the recent review. 🎉


📝 Walkthrough

Walkthrough

Two files simplify UI layouts by removing flex and width constraints, and consolidate action bar components by replacing custom RelativeActionBar styled components with a shared ActionBar component. Layout properties and constraints are eliminated for more flexible styling.

Changes

Cohort / File(s) Summary
Layout and ActionBar Refactoring
code/addons/docs/src/blocks/components/Preview.tsx, code/core/src/components/components/syntaxhighlighter/syntaxhighlighter.tsx
Removed flex layout properties (display, flexWrap, gap) and width constraints from styled components. Eliminated custom RelativeActionBar styled components and replaced with shared ActionBar component. Added paddingRight to Code component for balanced padding.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Possibly related PRs

  • storybookjs/storybook#33420: Modifies the same files (syntaxhighlighter.tsx and Preview.tsx) with related layout and ActionBar component changes.
✨ Finishing Touches
  • 📝 Generate docstrings (stacked PR)
  • 📝 Generate docstrings (commit on current branch)

Comment @coderabbitai help to get the list of available commands and usage tips.

@Sidnioulz Sidnioulz changed the title Revert: Pull Request #33420 from Maelryn/fix/copy-button-overlap Core: Revert Pull Request #33420 from Maelryn/fix/copy-button-overlap Feb 20, 2026
@Sidnioulz Sidnioulz merged commit 839a253 into next Feb 20, 2026
126 of 132 checks passed
@Sidnioulz Sidnioulz deleted the sidnioulz/revert-copy-button-overflow-pr branch February 20, 2026 10:08
@github-actions github-actions bot mentioned this pull request Feb 20, 2026
11 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci:normal maintenance User-facing maintenance tasks

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants