Skip to content

Adjust release GitHub workflow for v8 #33843

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
valentinpalkovic merged 21 commits into from
Feb 17, 2026
Merged

Adjust release GitHub workflow for v8 #33843

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
21 commits
Select commit Hold shift + click to select a range
faae460
Adjust release GitHub workflow for v8
valentinpalkovic Feb 13, 2026
7db6b80
add missing action
yannbf Feb 13, 2026
1b0bb68
add node setup action
yannbf Feb 13, 2026
5ad86ec
Merge branch 'v8-release-fixes' of github.com:storybookjs/storybook i…
yannbf Feb 13, 2026
6577c95
cleanup
yannbf Feb 13, 2026
9fcd598
add missing env
yannbf Feb 13, 2026
79e5bb5
Fix publish.yml
valentinpalkovic Feb 16, 2026
1cb5db5
Update npmrc
valentinpalkovic Feb 16, 2026
d31bb8f
Update yarn
valentinpalkovic Feb 16, 2026
6c2ca00
Set new yarn version
valentinpalkovic Feb 16, 2026
df25ab6
Retrigger canary
valentinpalkovic Feb 16, 2026
b5b9b38
Retrigger canary
valentinpalkovic Feb 16, 2026
438a474
bump & sync yarn versions
ndelangen Feb 16, 2026
8c647f3
bump node version and activate corepack
ndelangen Feb 16, 2026
7dfaa12
ran `npx update-browserslist-db@latest`
ndelangen Feb 16, 2026
a211b96
Update versions to be compatible with Storybook 8
yannbf Feb 17, 2026
99db7e4
adjust experimental nextjs vite sandbox to use vite 6
yannbf Feb 17, 2026
93b04b9
Remove IS_PRERELEASE parameter from GitHub Actions publish workflow
valentinpalkovic Feb 17, 2026
d6419e0
Update publish workflow to include CHANGELOG entry for new version
valentinpalkovic Feb 17, 2026
010d8c2
Bump deferred version
valentinpalkovic Feb 17, 2026
978b552
Update CHANGELOG for version 8.6.16: No-op release with no changes.
valentinpalkovic Feb 17, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 5 additions & 3 deletions .circleci/config.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ executors:
default: "small"
working_directory: /tmp/storybook
docker:
- image: cimg/node:22.13.1
- image: cimg/node:22.22.0
environment:
NODE_OPTIONS: --max_old_space_size=6144
resource_class: <<parameters.class>>
Expand All @@ -51,7 +51,7 @@ executors:
default: "small"
working_directory: /tmp/storybook
docker:
- image: cimg/node:22.13.1-browsers
- image: cimg/node:22.22.0-browsers
environment:
NODE_OPTIONS: --max_old_space_size=6144
resource_class: <<parameters.class>>
Expand Down Expand Up @@ -384,7 +384,9 @@ jobs:
at: .
- run:
name: Enable Corepack
command: sudo corepack enable yarn
command: |
corepack enable
corepack prepare yarn@4.12.0 --activate
- run:
name: Starting Event Collector
command: yarn jiti ./event-log-collector.ts
Expand Down
42 changes: 42 additions & 0 deletions .github/actions/setup-node-and-install/action.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,42 @@
name: 'Setup Node.js and Install Dependencies'
description: 'Sets up Node.js, caches dependencies, and installs packages for Storybook'

inputs:
install-code-deps:
description: 'Whether to install code dependencies in addition to script dependencies'
required: false
default: 'false'

runs:
using: 'composite'
steps:
- name: Setup Node.js
uses: actions/setup-node@v4
with:
node-version-file: '.nvmrc'

- name: Update npm to latest
shell: bash
run: npm install -g npm@latest

- name: Cache dependencies
uses: actions/cache@v4
with:
path: |
~/.yarn/berry/cache
key: yarn-v1-${{ hashFiles('scripts/yarn.lock') }}-${{ hashFiles('code/yarn.lock') }}
restore-keys: |
yarn-v1-${{ hashFiles('scripts/yarn.lock') }}-${{ hashFiles('code/yarn.lock') }}
yarn-v1-${{ hashFiles('scripts/yarn.lock') }}
yarn-v1
Comment on lines +22 to +31

@coderabbitai coderabbitai Bot Feb 13, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟡 Minor

Redundant restore-key on line 29.

The first restore-key is identical to the primary key. Restore-keys are only consulted when the primary key doesn't match exactly, so this entry is never used.

Proposed fix 
       key: yarn-v1-${{ hashFiles('scripts/yarn.lock') }}-${{ hashFiles('code/yarn.lock') }}
       restore-keys: |
-        yarn-v1-${{ hashFiles('scripts/yarn.lock') }}-${{ hashFiles('code/yarn.lock') }}
         yarn-v1-${{ hashFiles('scripts/yarn.lock') }}
         yarn-v1
📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
- name: Cache dependencies
uses: actions/cache@v4
with:
path: |
~/.yarn/berry/cache
key: yarn-v1-${{ hashFiles('scripts/yarn.lock') }}-${{ hashFiles('code/yarn.lock') }}
restore-keys: |
yarn-v1-${{ hashFiles('scripts/yarn.lock') }}-${{ hashFiles('code/yarn.lock') }}
yarn-v1-${{ hashFiles('scripts/yarn.lock') }}
yarn-v1
- name: Cache dependencies
uses: actions/cache@v4
with:
path: |
~/.yarn/berry/cache
key: yarn-v1-${{ hashFiles('scripts/yarn.lock') }}-${{ hashFiles('code/yarn.lock') }}
restore-keys: |
yarn-v1-${{ hashFiles('scripts/yarn.lock') }}
yarn-v1
🤖 Prompt for AI Agents 
In @.github/actions/setup-node-and-install/action.yml around lines 22 - 31, The
restore-keys list in the "Cache dependencies" step for actions/cache@v4 contains
a redundant first entry identical to the primary key; remove that duplicate
restore-key so only the fallback restore-keys remain (the lines starting with
yarn-v1-${{ hashFiles('scripts/yarn.lock') }} and yarn-v1). Edit the
restore-keys block in the Cache dependencies step to drop the entry matching the
primary key while keeping the other, more general fallback keys to allow proper
cache fallback behavior.


- name: Install script dependencies
shell: bash
working-directory: scripts
run: yarn install

- name: Install code dependencies
if: inputs.install-code-deps == 'true'
shell: bash
working-directory: code
run: yarn install
14 changes: 14 additions & 0 deletions .github/workflows/publish.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,14 @@
# Releasing previous major release

## Preparation

1. `git checkout v8`
2. `git pull`
3. `git checkout -b hotfix/v<next-patch-release-version>`
4. Apply necessary hotfixes
5. `cd scripts && yarn release:version --deferred --release-type patch --verbose && cd .. && git add . && git commit -m "Bump deferred version"`
6. Add a new entry for the new version to the `CHANGELOG.md` file
7. Trigger canary release via dispatching the workflow for `publish-canary`
8. Test the canary release
9. Merge `hotfix/v<next-patch-release-version>` into `v8`
10. Observe the `publish-normal` job
Loading