-
-
Notifications
You must be signed in to change notification settings - Fork 10.1k
Adjust release GitHub workflow for v9 #33838
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
ca8f52d
fc291b5
f5c96e1
b57b88d
df15fc7
ab35828
a80d9f0
84d84d7
5d4da95
04e87fb
4755a95
e42f476
0d79463
e839d07
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,19 @@ | ||
| # Releasing previous major release | ||
|
|
||
| ## Preparation | ||
|
|
||
| 1. `git checkout v9` | ||
| 2. `git pull` | ||
| 3. `git checkout -b hotfix/v<next-patch-release-version>` | ||
| 4. Apply necessary hotfixes | ||
| 5. `cd scripts && yarn release:version --deferred --release-type patch --verbose && cd .. && git add . && git commit -m "Bump deferred version"` | ||
| 6. Add a new entry for the new version to the `CHANGELOG.md` file | ||
| 7. Trigger canary release via dispatching the workflow for `publish-canary` | ||
| 8. Test the canary release | ||
| 9. Merge `hotfix/v<next-patch-release-version>` into `v9` | ||
| 10. Observe the `publish-normal` job | ||
|
|
||
|
|
||
| ## Prepare major release branch for publishing | ||
|
|
||
| 1. Go to `https://github.com/storybookjs/storybook/settings/environments/1012979736/edit` (release environment) and add the major release branch (e.g. v9) |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -45,10 +45,10 @@ const SUPPORTED_PROJECTS: Record<string, SupportedProject> = { | |
| language: 'TS', | ||
| }, | ||
| createScript: { | ||
| npm: 'npm create next-app . -- --turbopack --typescript --use-npm --eslint --tailwind --no-app --import-alias="@/*" --src-dir --no-react-compiler', | ||
| npm: 'npm create next-app@16.0.1 . -- --turbopack --typescript --use-npm --eslint --tailwind --no-app --import-alias="@/*" --src-dir --no-react-compiler', | ||
| // yarn doesn't support version ranges, so we have to use npx | ||
| yarn: 'npx create-next-app . --turbopack --typescript --use-yarn --eslint --tailwind --no-app --import-alias="@/*" --src-dir --no-react-compiler', | ||
| pnpm: 'pnpm create next-app . --turbopack --typescript --use-pnpm --eslint --tailwind --no-app --import-alias="@/*" --src-dir --no-react-compiler', | ||
| yarn: 'npx create-next-app@16.0.1 . --turbopack --typescript --use-yarn --eslint --tailwind --no-app --import-alias="@/*" --src-dir --no-react-compiler', | ||
| pnpm: 'pnpm create next-app@16.0.1 . --turbopack --typescript --use-pnpm --eslint --tailwind --no-app --import-alias="@/*" --src-dir --no-react-compiler', | ||
|
Comment on lines
+48
to
+51
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 🧩 Analysis chain🏁 Script executed: #!/bin/bash
# Verify create-next-app@16.0.1 exists on npm and check available CLI options
echo "=== Checking create-next-app@16.0.1 ==="
npm view create-next-app@16.0.1 version 2>&1
echo -e "\n=== Checking available 16.x versions ==="
npm view create-next-app versions --json 2>&1 | grep -o '"16\.[^"]*"' | head -20
echo -e "\n=== Checking CLI help for create-next-app@16.0.1 ==="
npx create-next-app@16.0.1 --help 2>&1 | head -60Repository: storybookjs/storybook Length of output: 3326 Fix undocumented CLI flags that may cause the scaffold command to fail. Version 16.0.1 is valid and most flags are supported. However, Verify these flags work with version 16.0.1, or replace them with documented equivalents or omit them if the defaults are already correct. 🤖 Prompt for AI Agents |
||
| }, | ||
| }, | ||
| 'vue-vite-ts': { | ||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Avoid duplicate Chromatic addon specs when users already provide one.
If
options.extraAddonsalready contains@chromatic-com/storybook(with or without a version), pushing@chromatic-com/storybook@^4creates two specs for the same package. Because de-duping later is string-based, this can lead to conflicting installs or nondeterministic version selection. Consider guarding by base package name before adding.💡 Suggested fix
if (features.includes('test')) { - extraAddons.push('@chromatic-com/storybook@^4'); + const chromaticPkg = '@chromatic-com/storybook'; + const hasChromatic = extraAddons.some( + (addon) => getPackageDetails(addon)[0] === chromaticPkg + ); + if (!hasChromatic) { + extraAddons.push(`${chromaticPkg}@^4`); + } }🤖 Prompt for AI Agents