Viewport: Skip viewport validation before parameters load#33794
Merged
valentinpalkovic merged 1 commit intoFeb 9, 2026
Merged
Conversation
…event race condition
Contributor
📝 WalkthroughWalkthroughUpdates a viewport hook to prevent processing when a parameter has not yet loaded, adding a guard condition and extending the dependency array to avoid race conditions with default values. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~8 minutes ✨ Finishing touches
Comment |
valentinpalkovic
approved these changes
Feb 9, 2026
This was referenced Feb 9, 2026
8 tasks
8 tasks
Merged
1 task
This was referenced Mar 18, 2026
Merged
1 task
This was referenced Mar 18, 2026
This was referenced Mar 18, 2026
1 task
This was referenced Apr 27, 2026
1 task
This was referenced May 3, 2026
1 task
This was referenced May 10, 2026
1 task
This was referenced May 16, 2026
1 task
This was referenced May 28, 2026
Closed
Closed
Closed
Closed
Closed
1 task
This was referenced Jun 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #33777
What I did
Skip viewport validation when
parameteris not yet available to prevent premature resetsWhy
initialGlobals.viewport.valueis validated beforeINITIAL_VIEWPORTSis loaded, causing valid viewports to be treated as invalid and reset.Checklist for Contributors
Testing
The changes in this PR are covered in the following automated tests:
Manual testing
Add the configuration to
preview.ts:PS
If
initialGlobals.viewport.valueis not present inparameters.viewport.options, it is silently reset without warning or error.Documentation
MIGRATION.MD
Checklist for Maintainers
When this PR is ready for testing, make sure to add
ci:normal,ci:mergedorci:dailyGH label to it to run a specific set of sandboxes. The particular set of sandboxes can be found incode/lib/cli-storybook/src/sandbox-templates.tsMake sure this PR contains one of the labels below:
Available labels
bug: Internal changes that fixes incorrect behavior.maintenance: User-facing maintenance tasks.dependencies: Upgrading (sometimes downgrading) dependencies.build: Internal-facing build tooling & test updates. Will not show up in release changelog.cleanup: Minor cleanup style change. Will not show up in release changelog.documentation: Documentation only changes. Will not show up in release changelog.feature request: Introducing a new feature.BREAKING CHANGE: Changes that break compatibility in some way with current major version.other: Changes that don't fit in the above categories.🦋 Canary release
This PR does not have a canary release associated. You can request a canary release of this pull request by mentioning the
@storybookjs/coreteam here.core team members can create a canary release here or locally with
gh workflow run --repo storybookjs/storybook publish.yml --field pr=<PR_NUMBER>Summary by CodeRabbit