Skip to content

Build: Fix test#33780

Merged
valentinpalkovic merged 1 commit into
nextfrom
valentin/fix-unit-test
Feb 5, 2026
Merged

Build: Fix test#33780
valentinpalkovic merged 1 commit into
nextfrom
valentin/fix-unit-test

Conversation

@valentinpalkovic
Copy link
Copy Markdown
Contributor

@valentinpalkovic valentinpalkovic commented Feb 5, 2026

Closes #

What I did

Checklist for Contributors

Testing

The changes in this PR are covered in the following automated tests:

  • stories
  • unit tests
  • integration tests
  • end-to-end tests

Manual testing

Caution

This section is mandatory for all contributions. If you believe no manual test is necessary, please state so explicitly. Thanks!

Documentation

  • Add or update documentation reflecting your changes
  • If you are deprecating/removing a feature, make sure to update
    MIGRATION.MD

Checklist for Maintainers

  • When this PR is ready for testing, make sure to add ci:normal, ci:merged or ci:daily GH label to it to run a specific set of sandboxes. The particular set of sandboxes can be found in code/lib/cli-storybook/src/sandbox-templates.ts

  • Make sure this PR contains one of the labels below:

    Available labels
    • bug: Internal changes that fixes incorrect behavior.
    • maintenance: User-facing maintenance tasks.
    • dependencies: Upgrading (sometimes downgrading) dependencies.
    • build: Internal-facing build tooling & test updates. Will not show up in release changelog.
    • cleanup: Minor cleanup style change. Will not show up in release changelog.
    • documentation: Documentation only changes. Will not show up in release changelog.
    • feature request: Introducing a new feature.
    • BREAKING CHANGE: Changes that break compatibility in some way with current major version.
    • other: Changes that don't fit in the above categories.

🦋 Canary release

This PR does not have a canary release associated. You can request a canary release of this pull request by mentioning the @storybookjs/core team here.

core team members can create a canary release here or locally with gh workflow run --repo storybookjs/storybook publish.yml --field pr=<PR_NUMBER>

Summary by CodeRabbit

  • Tests
    • Updated test template configuration reference to reflect current file naming conventions.

@valentinpalkovic valentinpalkovic self-assigned this Feb 5, 2026
@valentinpalkovic valentinpalkovic added the build Internal-facing build tooling & test updates label Feb 5, 2026
@valentinpalkovic valentinpalkovic merged commit 01fc452 into next Feb 5, 2026
8 of 9 checks passed
@valentinpalkovic valentinpalkovic deleted the valentin/fix-unit-test branch February 5, 2026 10:10
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Feb 5, 2026

Fails
🚫

PR is not labeled with one of: ["ci:normal","ci:merged","ci:daily","ci:docs"]

🚫 The "#### Manual testing" section must be filled in. Please describe how to test the changes you've made, step by step, so that reviewers can confirm your PR works as intended.

Generated by 🚫 dangerJS against fecb2ef

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented Feb 5, 2026

Caution

Review failed

The pull request is closed.

📝 Walkthrough

Walkthrough

A template file reference in a test file was updated to remove the .ts extension from the filename. The loadTemplate call now references vitest.config.3.2.template instead of vitest.config.3.2.template.ts. This is a single-line modification with no logic changes.

Changes

Cohort / File(s) Summary
Test Template Reference
code/addons/vitest/src/updateVitestFile.test.ts
Updated template filename reference in loadTemplate call, removing .ts extension from vitest.config.3.2.template.ts to vitest.config.3.2.template.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

✨ Finishing touches
  • 📝 Generate docstrings

Comment @coderabbitai help to get the list of available commands and usage tips.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

build Internal-facing build tooling & test updates

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant