Build: No dts-mapper files during dev#33759
Merged
Merged
Conversation
|
View your CI Pipeline Execution ↗ for commit e8d4488
☁️ Nx Cloud last updated this comment at |
Contributor
📝 WalkthroughWalkthroughThis pull request systematically adds "code" export fields to package.json files across the codebase, pointing to TypeScript source files. Accompanying build changes update export map generation and remove the type mapper utility that is no longer needed with the new export structure. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~12 minutes Possibly related PRs
✨ Finishing touches
Important Action Needed: IP Allowlist UpdateIf your organization protects your Git platform with IP whitelisting, please add the new CodeRabbit IP address to your allowlist:
Failure to add the new IP will result in interrupted reviews. Comment |
valentinpalkovic
approved these changes
Feb 3, 2026
This was referenced Feb 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What I did
We can use this functionality:
https://www.typescriptlang.org/tsconfig/#customConditions
To skip on generating the dts mapper files we had.
It might eliminate a race-condition we had at compile very occasionally, example:
https://app.circleci.com/pipelines/github/storybookjs/storybook/114019/workflows/4466ed1c-e3b6-4e91-990d-12a24fd4518d/jobs/1067742
Checklist for Contributors
Testing
The changes in this PR are covered in the following automated tests:
Manual testing
import { Button, Link, SyntaxHighlighter } from 'storybook/internal/components';retains it's type-safely, and allows you to jump to source/definitions (they should now be the same thing)Documentation
MIGRATION.MD
Checklist for Maintainers
When this PR is ready for testing, make sure to add
ci:normal,ci:mergedorci:dailyGH label to it to run a specific set of sandboxes. The particular set of sandboxes can be found incode/lib/cli-storybook/src/sandbox-templates.tsMake sure this PR contains one of the labels below:
Available labels
bug: Internal changes that fixes incorrect behavior.maintenance: User-facing maintenance tasks.dependencies: Upgrading (sometimes downgrading) dependencies.build: Internal-facing build tooling & test updates. Will not show up in release changelog.cleanup: Minor cleanup style change. Will not show up in release changelog.documentation: Documentation only changes. Will not show up in release changelog.feature request: Introducing a new feature.BREAKING CHANGE: Changes that break compatibility in some way with current major version.other: Changes that don't fit in the above categories.🦋 Canary release
This PR does not have a canary release associated. You can request a canary release of this pull request by mentioning the
@storybookjs/coreteam here.core team members can create a canary release here or locally with
gh workflow run --repo storybookjs/storybook publish.yml --field pr=<PR_NUMBER>Summary by CodeRabbit