Skip to content

Revert "Vue: Make globals reactive in decorators"#33744

Merged
valentinpalkovic merged 1 commit into
nextfrom
revert-33562-sidnioulz/issue-23655
Feb 2, 2026
Merged

Revert "Vue: Make globals reactive in decorators"#33744
valentinpalkovic merged 1 commit into
nextfrom
revert-33562-sidnioulz/issue-23655

Conversation

@valentinpalkovic
Copy link
Copy Markdown
Contributor

@valentinpalkovic valentinpalkovic commented Feb 2, 2026

Reverts #33562

Summary by CodeRabbit

  • Refactor

    • Simplified the updateArgs method signature in the Vue 3 renderer
    • Removed reactive globals support from the Vue 3 renderer
  • Tests

    • Removed Vue 3 end-to-end test suite for decorator functionality
  • Documentation

    • Removed Vue 3-specific decorator documentation and examples featuring reactive globals and updateArgs

@valentinpalkovic valentinpalkovic merged commit fca0cd5 into next Feb 2, 2026
7 checks passed
@valentinpalkovic valentinpalkovic deleted the revert-33562-sidnioulz/issue-23655 branch February 2, 2026 15:34
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Feb 2, 2026

Fails
🚫

PR is not labeled with one of: ["cleanup","BREAKING CHANGE","feature request","bug","documentation","maintenance","build","dependencies"]

🚫

PR is not labeled with one of: ["ci:normal","ci:merged","ci:daily","ci:docs"]

🚫 PR description is missing the mandatory "#### Manual testing" section. Please add it so that reviewers know how to manually test your changes.

Generated by 🚫 dangerJS against 07f07ec

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented Feb 2, 2026

Caution

Review failed

The pull request is closed.

📝 Walkthrough

Walkthrough

This PR removes reactive globals support and simplifies the updateArgs API in the Vue 3 renderer by eliminating generic type parameters, removing reactiveGlobals from public map exports, and deleting associated test cases, story examples, and documentation snippets.

Changes

Cohort / File(s) Summary
Core Vue 3 Renderer
code/renderers/vue3/src/render.ts, code/renderers/vue3/src/render.test.ts
Simplified updateArgs API by removing generic type parameter; removed reactiveGlobals property from public map value; eliminated reactive globals handling from storyContext and appState; updated test cases to reflect simplified API signature.
Story Templates
code/renderers/vue3/template/stories_vue3-vite-default-ts/decorators.stories.ts
Removed UpdateArgs and ReactiveGlobalDecorator story exports; removed useArgs import, updateArgsDecorator, localeDecorator, and getCaptionForLocale helper function.
Documentation Snippets
docs/_snippets/decorator-with-reactive-globals.md, docs/_snippets/decorator-with-updateArgs.md
Removed example code blocks demonstrating Vue 3 decorators using reactive globals and updateArgs patterns.
Documentation Guides
docs/writing-stories/decorators.mdx
Removed entire Vue-specific decorator guidance section covering reactive globals, CodeSnippets references, and Preview API hooks.
E2E Tests
code/e2e-tests/framework-vue3.spec.ts
Removed entire Vue 3 Playwright test suite including tests for updateArgs in decorators and reactive globals integration.

Estimated code review effort

🎯 4 (Complex) | ⏱️ ~40 minutes

Possibly related PRs

  • storybookjs/storybook#33562: Directly related as it introduces reactiveGlobals and generic updateArgs signature that this PR removes, representing a feature reversal or cleanup of previously added reactive globals support.
✨ Finishing touches
  • 📝 Generate docstrings

Comment @coderabbitai help to get the list of available commands and usage tips.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant