Skip to content

Core: Register CORS middleware before index.json route #33728

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
valentinpalkovic merged 1 commit into from
Feb 2, 2026
Merged

Core: Register CORS middleware before index.json route #33728

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 11 additions & 9 deletions code/core/src/core-server/dev-server.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,24 +46,26 @@ export async function storybookDevServer(options: Options) {
const storyIndexGeneratorPromise =
options.presets.apply<StoryIndexGenerator>('storyIndexGenerator');

registerIndexJsonRoute({
app,
storyIndexGeneratorPromise,
normalizedStories,
serverChannel,
workingDir,
configDir,
});

app.use(compression({ level: 1 }));

if (typeof options.extendServer === 'function') {
options.extendServer(server);
}

// CORS middleware must be registered BEFORE route handlers to ensure all routes
// (including /index.json) receive proper CORS headers for Storybook Composition
app.use(getAccessControlMiddleware(core?.crossOriginIsolated ?? false));
app.use(getCachingMiddleware());

registerIndexJsonRoute({
app,
storyIndexGeneratorPromise,
normalizedStories,
serverChannel,
workingDir,
configDir,
});

(await getMiddleware(options.configDir))(app);

// Apply experimental_devServer preset to allow addons/frameworks to extend the dev server with middlewares, etc.
Expand Down
Loading