Skip to content

Codemod: Fix glob pattern handling on Windows #33714

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
valentinpalkovic merged 2 commits into from
Jan 30, 2026
Merged

Codemod: Fix glob pattern handling on Windows #33714

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7ef33d0
Codemod: Fix glob pattern handling on Windows
kasperpeulen Jan 30, 2026
5f4ed14
Fix linting
valentinpalkovic Jan 30, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion code/lib/codemod/src/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@ import { extname, join } from 'node:path';
import { resolvePackageDir } from 'storybook/internal/common';

import { sync as spawnSync } from 'cross-spawn';
import { normalize } from 'pathe';
import { glob as tinyglobby } from 'tinyglobby';

import { jscodeshiftToPrettierParser } from './lib/utils';
Expand Down Expand Up @@ -60,7 +61,8 @@ export async function runCodemod(
}
}

const files = await tinyglobby([glob, '!**/node_modules', '!**/dist']);
// Normalize the glob pattern to use forward slashes (required for glob patterns on Windows)
const files = await tinyglobby([normalize(glob), '!**/node_modules', '!**/dist']);
const extensions = new Set(files.map((file) => extname(file).slice(1)));
const commaSeparatedExtensions = Array.from(extensions).join(',');

Expand Down
Loading