Skip to content

Manager: Remove deprecated active prop warning in ZoomButton #33697

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
valentinpalkovic merged 8 commits into from
Jan 30, 2026
Merged

Manager: Remove deprecated active prop warning in ZoomButton #33697

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
a374480
Fix: Replace deprecated active prop with pressed in ZoomButton
yatishgoel Jan 28, 2026
b880dfb
Update ZoomButton ariaLabel to false for accessibility compliance
yatishgoel Jan 29, 2026
ecc2491
Update ZoomButton ariaLabel to "Change zoom level" for improved acces…
yatishgoel Jan 29, 2026
d21d594
Merge branch 'next' into fix/33689-zoom-button-active-prop
yatishgoel Jan 29, 2026
f391b41
Merge branch 'next' into fix/33689-zoom-button-active-prop
valentinpalkovic Jan 30, 2026
6a8df6c
Merge branch 'next' into fix/33689-zoom-button-active-prop
yatishgoel Jan 30, 2026
cd2a64f
Update zoom story to use 'switch' role instead of 'button' for zoom l…
yatishgoel Jan 30, 2026
ec085df
Merge branch 'next' into fix/33689-zoom-button-active-prop
yatishgoel Jan 30, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion code/core/src/manager/components/preview/tools/zoom.stories.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ import preview from '../../../../../../.storybook/preview';
import { Zoom } from './zoom';

const openDialog = async (context: StoryContext<typeof Zoom>) => {
const zoom = await context.canvas.findByRole('button', { name: 'Change zoom level' });
const zoom = await context.canvas.findByRole('switch', { name: 'Change zoom level' });
await context.userEvent.click(zoom);
return screen.findByRole('dialog');
};
Expand Down
6 changes: 3 additions & 3 deletions code/core/src/manager/components/preview/tools/zoom.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
import type { PropsWithChildren } from 'react';
import React, { Component, createContext, memo, useCallback, useEffect, useRef } from 'react';

import { ActionList, Button, PopoverProvider } from 'storybook/internal/components';
import { ActionList, PopoverProvider, ToggleButton } from 'storybook/internal/components';
import type { Addon_BaseType } from 'storybook/internal/types';

import { UndoIcon, ZoomIcon } from '@storybook/icons';
Expand All @@ -15,7 +15,7 @@ import { NumericInput } from '../NumericInput';
const ZOOM_LEVELS = [0.25, 0.5, 0.75, 0.9, 1, 1.1, 1.25, 1.5, 2, 3, 4, 8] as const;
const INITIAL_ZOOM_LEVEL = 1;

const ZoomButton = styled(Button)({
const ZoomButton = styled(ToggleButton)({
minWidth: 48,
});

Expand Down Expand Up @@ -148,7 +148,7 @@ export const Zoom = memo<{
padding="small"
variant="ghost"
ariaLabel="Change zoom level"
active={value !== INITIAL_ZOOM_LEVEL}
pressed={value !== INITIAL_ZOOM_LEVEL}
>
{Math.round(value * 100)}%
</ZoomButton>
Expand Down