Vue3: Add test for generic components with CSF factories#33685
Merged
Conversation
This adds a unit test demonstrating that generic Vue components work
correctly with CSF factories by passing the type parameter directly:
`GenericComponent<{ id: number; name: string }>`.
This addresses issue #24238 where generic Vue components had type
inference issues with traditional CSF3.
|
View your CI Pipeline Execution ↗ for commit 35318b6
☁️ Nx Cloud last updated this comment at |
Contributor
📝 WalkthroughWalkthroughAdds a new generic Vue 3 single-file component Changes
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Comment |
5c8d2be to
35318b6
Compare
shilman
approved these changes
Jan 28, 2026
24 tasks
This was referenced Jan 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related to #24238
What I did
This PR adds a unit test demonstrating that generic Vue components (using
<script lang="ts" setup generic="T">) work correctly with CSF Next.The key finding: With CSF Next, you can pass the type parameter directly:
This addresses the long-standing issue #24238 where generic Vue components had type inference issues with traditional CSF3 (the generic type
Twould default tounknown).Checklist for Contributors
Testing
The changes in this PR are covered in the following automated tests:
Manual testing
No manual testing required - this PR adds a type-level unit test that verifies TypeScript inference works correctly with generic Vue components.
Documentation
MIGRATION.MD
Checklist for Maintainers
When this PR is ready for testing, make sure to add
ci:normal,ci:mergedorci:dailyGH label to it to run a specific set of sandboxes. The particular set of sandboxes can be found incode/lib/cli-storybook/src/sandbox-templates.tsMake sure this PR contains one of the labels below:
Available labels
bug: Internal changes that fixes incorrect behavior.maintenance: User-facing maintenance tasks.dependencies: Upgrading (sometimes downgrading) dependencies.build: Internal-facing build tooling & test updates. Will not show up in release changelog.cleanup: Minor cleanup style change. Will not show up in release changelog.documentation: Documentation only changes. Will not show up in release changelog.feature request: Introducing a new feature.BREAKING CHANGE: Changes that break compatibility in some way with current major version.other: Changes that don't fit in the above categories.🦋 Canary release
This PR does not have a canary release associated. You can request a canary release of this pull request by mentioning the
@storybookjs/coreteam here.core team members can create a canary release here or locally with
gh workflow run --repo storybookjs/storybook publish.yml --field pr=<PR_NUMBER>