Skip to content

Build: Fix MCP tests on Windows #33644

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
valentinpalkovic merged 2 commits into from
Jan 27, 2026
Merged

Build: Fix MCP tests on Windows #33644

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7a2871a
Build: Fix MCP tests on Windows
valentinpalkovic Jan 26, 2026
09dfdde
Merge branch 'next' into valentin/fix-mcp-tests-on-windows
valentinpalkovic Jan 27, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions code/e2e-tests/addon-mcp.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,12 +1,14 @@
/* eslint-disable local-rules/no-uncategorized-errors */
import path from 'node:path';

import type { APIRequestContext } from '@playwright/test';
import { expect, test } from '@playwright/test';
import process from 'process';

const storybookUrl = process.env.STORYBOOK_URL || 'http://localhost:8001';
const templateName = process.env.STORYBOOK_TEMPLATE_NAME || '';
const type = process.env.STORYBOOK_TYPE || 'dev';
const sandboxDir = process.env.STORYBOOK_SANDBOX_DIR;
const sandboxDir = process.env.STORYBOOK_SANDBOX_DIR!;
Comment on lines 8 to +11

@coderabbitai coderabbitai Bot Jan 26, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟡 Minor

Avoid non‑null assertion for required env var; fail with a clear error.

process.env.STORYBOOK_SANDBOX_DIR! can throw later in path.join with a confusing error when the env var isn’t set. Prefer an explicit guard and a helpful message (including the default sandbox location) to make CI/local failures actionable.

✅ Suggested change 
-const sandboxDir = process.env.STORYBOOK_SANDBOX_DIR!;
+const sandboxDir = process.env.STORYBOOK_SANDBOX_DIR;
+if (!sandboxDir) {
+  throw new Error(
+    'STORYBOOK_SANDBOX_DIR is required. Sandboxes are generated outside the repo at ../storybook-sandboxes/.'
+  );
+}

Based on learnings, sandboxes default to ../storybook-sandboxes/.

📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
const storybookUrl = process.env.STORYBOOK_URL || 'http://localhost:8001';
const templateName = process.env.STORYBOOK_TEMPLATE_NAME || '';
const type = process.env.STORYBOOK_TYPE || 'dev';
const sandboxDir = process.env.STORYBOOK_SANDBOX_DIR;
const sandboxDir = process.env.STORYBOOK_SANDBOX_DIR!;
const storybookUrl = process.env.STORYBOOK_URL || 'http://localhost:8001';
const templateName = process.env.STORYBOOK_TEMPLATE_NAME || '';
const type = process.env.STORYBOOK_TYPE || 'dev';
const sandboxDir = process.env.STORYBOOK_SANDBOX_DIR;
if (!sandboxDir) {
throw new Error(
'STORYBOOK_SANDBOX_DIR is required. Sandboxes are generated outside the repo at ../storybook-sandboxes/.'
);
}
🤖 Prompt for AI Agents 
In `@code/e2e-tests/addon-mcp.spec.ts` around lines 8 - 11, Replace the non‑null
asserted constant sandboxDir so it fails fast with a clear message and provides
the usual default; instead of using process.env.STORYBOOK_SANDBOX_DIR! in the
top‑level const, read the env var into a variable, and if it is missing throw a
descriptive Error (or set to the default sandbox path "../storybook-sandboxes/"
resolved to an absolute path) before any path.join usage; update references to
the existing sandboxDir constant so code uses the validated/defaulted value and
avoid later mysterious path.join failures.


const MCP_ENDPOINT = `${storybookUrl}/mcp`;

Expand Down Expand Up @@ -200,7 +202,7 @@ test.describe('addon-mcp', () => {
stories: [
{
exportName: storyName,
absoluteStoryPath: `${sandboxDir}/src/stories/Button.stories.ts`,
absoluteStoryPath: path.join(sandboxDir, 'src', 'stories', 'Button.stories.ts'),
},
],
},
Expand Down
Loading