Core: Remove unused useModalDialog hook by akornmeier · Pull Request #33632 · storybookjs/storybook

akornmeier · 2026-01-23T15:45:10Z

Related #32253

Removes dead code as referenced in issue #32253.

@Sidnioulz

Testing

Manual testing

Not needed

Documentation

Dead code removal
Add or update documentation reflecting your changes
If you are deprecating/removing a feature, make sure to update
MIGRATION.MD

Checklist for Maintainers

When this PR is ready for testing, make sure to add ci:normal, ci:merged or ci:daily GH label to it to run a specific set of sandboxes. The particular set of sandboxes can be found in code/lib/cli-storybook/src/sandbox-templates.ts
Make sure this PR contains one of the labels below:
Available labels
- bug: Internal changes that fixes incorrect behavior.
- maintenance: User-facing maintenance tasks.
- dependencies: Upgrading (sometimes downgrading) dependencies.
- build: Internal-facing build tooling & test updates. Will not show up in release changelog.
- cleanup: Minor cleanup style change. Will not show up in release changelog.
- documentation: Documentation only changes. Will not show up in release changelog.
- feature request: Introducing a new feature.
- BREAKING CHANGE: Changes that break compatibility in some way with current major version.
- other: Changes that don't fit in the above categories.

🦋 Canary release

This PR does not have a canary release associated. You can request a canary release of this pull request by mentioning the @storybookjs/core team here.

core team members can create a canary release here or locally with gh workflow run --repo storybookjs/storybook publish.yml --field pr=<PR_NUMBER>

Summary by CodeRabbit

Refactor
- Removed the built-in modal dialog hook and its related public contract. Projects relying on this hook will need to provide an alternative dialog-management approach (e.g., local state or a different shared utility) to preserve existing modal behavior. Update integrations to handle open/close lifecycle and escape/close handling where required.

_{✏️ Tip: You can customize this high-level summary in your review settings.}

coderabbitai · 2026-01-23T15:46:27Z

📝 Walkthrough

Walkthrough

The useModalDialog.ts file containing a React hook and its associated interface for managing modal dialogs has been entirely removed, eliminating the exported hook and its type definitions from the codebase.

Changes

Cohort / File(s)	Summary
Hook Deletion `code/core/src/manager/hooks/useModalDialog.ts`	Removed entire file (51 lines). Deleted `useModalDialog` hook for HTMLDialogElement management and `UseModalDialogOptions` interface.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

✨ Finishing touches

📝 Generate docstrings

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

storybook-app-bot · 2026-01-23T16:14:38Z

Package Benchmarks

^{Commit: e4687ca, ran on 28 January 2026 at 07:58:28 UTC}

The following packages have significant changes to their size or dependencies:

`@storybook/addon-a11y`

	Before	After	Difference
Dependency count	0	2	🚨 +2 🚨
Self size	0 B	184 KB	🚨 +184 KB 🚨
Dependency size	0 B	2.98 MB	🚨 +2.98 MB 🚨
Bundle Size Analyzer	Link	Link

`@storybook/addon-docs`

	Before	After	Difference
Dependency count	0	18	🚨 +18 🚨
Self size	0 B	1.64 MB	🚨 +1.64 MB 🚨
Dependency size	0 B	9.25 MB	🚨 +9.25 MB 🚨
Bundle Size Analyzer	Link	Link

`@storybook/addon-links`

	Before	After	Difference
Dependency count	0	1	🚨 +1 🚨
Self size	0 B	14 KB	🚨 +14 KB 🚨
Dependency size	0 B	5 KB	🚨 +5 KB 🚨
Bundle Size Analyzer	Link	Link

`@storybook/addon-onboarding`

	Before	After	Difference
Dependency count	0	0	0
Self size	0 B	331 KB	🚨 +331 KB 🚨
Dependency size	0 B	670 B	🚨 +670 B 🚨
Bundle Size Analyzer	Link	Link

`storybook-addon-pseudo-states`

	Before	After	Difference
Dependency count	0	0	0
Self size	0 B	21 KB	🚨 +21 KB 🚨
Dependency size	0 B	689 B	🚨 +689 B 🚨
Bundle Size Analyzer	Link	Link

`@storybook/addon-themes`

	Before	After	Difference
Dependency count	0	1	🚨 +1 🚨
Self size	0 B	18 KB	🚨 +18 KB 🚨
Dependency size	0 B	28 KB	🚨 +28 KB 🚨
Bundle Size Analyzer	Link	Link

`@storybook/addon-vitest`

	Before	After	Difference
Dependency count	0	2	🚨 +2 🚨
Self size	0 B	379 KB	🚨 +379 KB 🚨
Dependency size	0 B	338 KB	🚨 +338 KB 🚨
Bundle Size Analyzer	Link	Link

`@storybook/builder-vite`

	Before	After	Difference
Dependency count	0	11	🚨 +11 🚨
Self size	0 B	123 KB	🚨 +123 KB 🚨
Dependency size	0 B	1.30 MB	🚨 +1.30 MB 🚨
Bundle Size Analyzer	Link	Link

`@storybook/builder-webpack5`

	Before	After	Difference
Dependency count	0	188	🚨 +188 🚨
Self size	0 B	75 KB	🚨 +75 KB 🚨
Dependency size	0 B	32.04 MB	🚨 +32.04 MB 🚨
Bundle Size Analyzer	Link	Link

`storybook`

	Before	After	Difference
Dependency count	0	49	🚨 +49 🚨
Self size	0 B	20.39 MB	🚨 +20.39 MB 🚨
Dependency size	0 B	16.52 MB	🚨 +16.52 MB 🚨
Bundle Size Analyzer	Link	Link

`@storybook/angular`

	Before	After	Difference
Dependency count	0	188	🚨 +188 🚨
Self size	0 B	139 KB	🚨 +139 KB 🚨
Dependency size	0 B	30.27 MB	🚨 +30.27 MB 🚨
Bundle Size Analyzer	Link	Link

`@storybook/ember`

	Before	After	Difference
Dependency count	0	192	🚨 +192 🚨
Self size	0 B	15 KB	🚨 +15 KB 🚨
Dependency size	0 B	28.76 MB	🚨 +28.76 MB 🚨
Bundle Size Analyzer	Link	Link

`@storybook/html-vite`

	Before	After	Difference
Dependency count	0	14	🚨 +14 🚨
Self size	0 B	22 KB	🚨 +22 KB 🚨
Dependency size	0 B	1.46 MB	🚨 +1.46 MB 🚨
Bundle Size Analyzer	Link	Link

`@storybook/nextjs`

	Before	After	Difference
Dependency count	0	534	🚨 +534 🚨
Self size	0 B	646 KB	🚨 +646 KB 🚨
Dependency size	0 B	59.53 MB	🚨 +59.53 MB 🚨
Bundle Size Analyzer	Link	Link

`@storybook/nextjs-vite`

	Before	After	Difference
Dependency count	0	123	🚨 +123 🚨
Self size	0 B	1.12 MB	🚨 +1.12 MB 🚨
Dependency size	0 B	22.11 MB	🚨 +22.11 MB 🚨
Bundle Size Analyzer	Link	Link

`@storybook/preact-vite`

	Before	After	Difference
Dependency count	0	14	🚨 +14 🚨
Self size	0 B	13 KB	🚨 +13 KB 🚨
Dependency size	0 B	1.44 MB	🚨 +1.44 MB 🚨
Bundle Size Analyzer	Link	Link

`@storybook/react-native-web-vite`

	Before	After	Difference
Dependency count	0	155	🚨 +155 🚨
Self size	0 B	30 KB	🚨 +30 KB 🚨
Dependency size	0 B	23.41 MB	🚨 +23.41 MB 🚨
Bundle Size Analyzer	Link	Link

`@storybook/react-vite`

	Before	After	Difference
Dependency count	0	113	🚨 +113 🚨
Self size	0 B	35 KB	🚨 +35 KB 🚨
Dependency size	0 B	19.91 MB	🚨 +19.91 MB 🚨
Bundle Size Analyzer	Link	Link

`@storybook/react-webpack5`

	Before	After	Difference
Dependency count	0	274	🚨 +274 🚨
Self size	0 B	24 KB	🚨 +24 KB 🚨
Dependency size	0 B	44.43 MB	🚨 +44.43 MB 🚨
Bundle Size Analyzer	Link	Link

`@storybook/server-webpack5`

	Before	After	Difference
Dependency count	0	200	🚨 +200 🚨
Self size	0 B	16 KB	🚨 +16 KB 🚨
Dependency size	0 B	33.30 MB	🚨 +33.30 MB 🚨
Bundle Size Analyzer	Link	Link

`@storybook/svelte-vite`

	Before	After	Difference
Dependency count	0	19	🚨 +19 🚨
Self size	0 B	55 KB	🚨 +55 KB 🚨
Dependency size	0 B	26.58 MB	🚨 +26.58 MB 🚨
Bundle Size Analyzer	Link	Link

`@storybook/sveltekit`

	Before	After	Difference
Dependency count	0	20	🚨 +20 🚨
Self size	0 B	56 KB	🚨 +56 KB 🚨
Dependency size	0 B	26.63 MB	🚨 +26.63 MB 🚨
Bundle Size Analyzer	Link	Link

`@storybook/vue3-vite`

	Before	After	Difference
Dependency count	0	108	🚨 +108 🚨
Self size	0 B	35 KB	🚨 +35 KB 🚨
Dependency size	0 B	43.67 MB	🚨 +43.67 MB 🚨
Bundle Size Analyzer	Link	Link

`@storybook/web-components-vite`

	Before	After	Difference
Dependency count	0	15	🚨 +15 🚨
Self size	0 B	19 KB	🚨 +19 KB 🚨
Dependency size	0 B	1.50 MB	🚨 +1.50 MB 🚨
Bundle Size Analyzer	Link	Link

`@storybook/cli`

	Before	After	Difference
Dependency count	0	183	🚨 +183 🚨
Self size	0 B	775 KB	🚨 +775 KB 🚨
Dependency size	0 B	67.55 MB	🚨 +67.55 MB 🚨
Bundle Size Analyzer	Link	Link

`@storybook/codemod`

	Before	After	Difference
Dependency count	0	176	🚨 +176 🚨
Self size	0 B	30 KB	🚨 +30 KB 🚨
Dependency size	0 B	66.13 MB	🚨 +66.13 MB 🚨
Bundle Size Analyzer	Link	Link

`@storybook/core-webpack`

	Before	After	Difference
Dependency count	0	1	🚨 +1 🚨
Self size	0 B	11 KB	🚨 +11 KB 🚨
Dependency size	0 B	28 KB	🚨 +28 KB 🚨
Bundle Size Analyzer	Link	Link

`create-storybook`

	Before	After	Difference
Dependency count	0	50	🚨 +50 🚨
Self size	0 B	1000 KB	🚨 +1000 KB 🚨
Dependency size	0 B	36.91 MB	🚨 +36.91 MB 🚨
Bundle Size Analyzer	node	node

`@storybook/csf-plugin`

	Before	After	Difference
Dependency count	0	9	🚨 +9 🚨
Self size	0 B	7 KB	🚨 +7 KB 🚨
Dependency size	0 B	1.26 MB	🚨 +1.26 MB 🚨
Bundle Size Analyzer	Link	Link

`eslint-plugin-storybook`

	Before	After	Difference
Dependency count	0	20	🚨 +20 🚨
Self size	0 B	131 KB	🚨 +131 KB 🚨
Dependency size	0 B	2.82 MB	🚨 +2.82 MB 🚨
Bundle Size Analyzer	Link	Link

`@storybook/react-dom-shim`

	Before	After	Difference
Dependency count	0	0	0
Self size	0 B	18 KB	🚨 +18 KB 🚨
Dependency size	0 B	788 B	🚨 +788 B 🚨
Bundle Size Analyzer	Link	Link

`@storybook/preset-create-react-app`

	Before	After	Difference
Dependency count	0	68	🚨 +68 🚨
Self size	0 B	32 KB	🚨 +32 KB 🚨
Dependency size	0 B	5.98 MB	🚨 +5.98 MB 🚨
Bundle Size Analyzer	Link	Link

`@storybook/preset-react-webpack`

	Before	After	Difference
Dependency count	0	170	🚨 +170 🚨
Self size	0 B	18 KB	🚨 +18 KB 🚨
Dependency size	0 B	31.29 MB	🚨 +31.29 MB 🚨
Bundle Size Analyzer	Link	Link

`@storybook/preset-server-webpack`

	Before	After	Difference
Dependency count	0	10	🚨 +10 🚨
Self size	0 B	7 KB	🚨 +7 KB 🚨
Dependency size	0 B	1.20 MB	🚨 +1.20 MB 🚨
Bundle Size Analyzer	Link	Link

`@storybook/html`

	Before	After	Difference
Dependency count	0	2	🚨 +2 🚨
Self size	0 B	29 KB	🚨 +29 KB 🚨
Dependency size	0 B	32 KB	🚨 +32 KB 🚨
Bundle Size Analyzer	Link	Link

`@storybook/preact`

	Before	After	Difference
Dependency count	0	2	🚨 +2 🚨
Self size	0 B	16 KB	🚨 +16 KB 🚨
Dependency size	0 B	32 KB	🚨 +32 KB 🚨
Bundle Size Analyzer	Link	Link

`@storybook/react`

	Before	After	Difference
Dependency count	0	57	🚨 +57 🚨
Self size	0 B	1.23 MB	🚨 +1.23 MB 🚨
Dependency size	0 B	12.95 MB	🚨 +12.95 MB 🚨
Bundle Size Analyzer	Link	Link

`@storybook/server`

	Before	After	Difference
Dependency count	0	3	🚨 +3 🚨
Self size	0 B	8 KB	🚨 +8 KB 🚨
Dependency size	0 B	716 KB	🚨 +716 KB 🚨
Bundle Size Analyzer	Link	Link

`@storybook/svelte`

	Before	After	Difference
Dependency count	0	2	🚨 +2 🚨
Self size	0 B	45 KB	🚨 +45 KB 🚨
Dependency size	0 B	230 KB	🚨 +230 KB 🚨
Bundle Size Analyzer	Link	Link

`@storybook/vue3`

	Before	After	Difference
Dependency count	0	3	🚨 +3 🚨
Self size	0 B	63 KB	🚨 +63 KB 🚨
Dependency size	0 B	211 KB	🚨 +211 KB 🚨
Bundle Size Analyzer	Link	Link

`@storybook/web-components`

	Before	After	Difference
Dependency count	0	3	🚨 +3 🚨
Self size	0 B	61 KB	🚨 +61 KB 🚨
Dependency size	0 B	47 KB	🚨 +47 KB 🚨
Bundle Size Analyzer	Link	Link

Sidnioulz

Thanks!

Sidnioulz added cleanup Minor cleanup style change that won't show up in release changelog ci:normal Run our default set of CI jobs (choose this for most PRs). labels Jan 23, 2026

Sidnioulz self-assigned this Jan 23, 2026

Sidnioulz changed the title ~~fix(core): remove unused useModalDialog hook~~ Core: Memove unused useModalDialog hook Jan 23, 2026

Sidnioulz changed the title ~~Core: Memove unused useModalDialog hook~~ Core: Remove unused useModalDialog hook Jan 23, 2026

Sidnioulz approved these changes Jan 26, 2026

View reviewed changes

fix(core): remove unused useModalDialog hook

2424a12

Sidnioulz force-pushed the a11y/remove-use-modal-dialog-hook-32253 branch from eb26a71 to 2424a12 Compare January 26, 2026 14:21

valentinpalkovic self-assigned this Jan 26, 2026

valentinpalkovic added this to Core Team Projects Jan 27, 2026

valentinpalkovic moved this to Empathy Queue (prioritized) in Core Team Projects Jan 27, 2026

valentinpalkovic moved this from Empathy Queue (prioritized) to In Progress in Core Team Projects Jan 27, 2026

valentinpalkovic approved these changes Jan 28, 2026

View reviewed changes

valentinpalkovic added ci:normal Run our default set of CI jobs (choose this for most PRs). and removed ci:normal Run our default set of CI jobs (choose this for most PRs). labels Jan 28, 2026

Merge branch 'next' into a11y/remove-use-modal-dialog-hook-32253

e4687ca

valentinpalkovic merged commit d89d005 into storybookjs:next Jan 28, 2026
114 checks passed

github-project-automation Bot moved this from In Progress to Done in Core Team Projects Jan 28, 2026

github-actions Bot mentioned this pull request Jan 28, 2026

Release: Prerelease 10.3.0-alpha.2 #33678

Merged

24 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Core: Remove unused useModalDialog hook#33632

Core: Remove unused useModalDialog hook#33632
valentinpalkovic merged 2 commits into
storybookjs:nextfrom
akornmeier:a11y/remove-use-modal-dialog-hook-32253

akornmeier commented Jan 23, 2026 •

edited by coderabbitai Bot

Loading

Uh oh!

coderabbitai Bot commented Jan 23, 2026 •

edited

Loading

Walkthrough

Changes

Estimated code review effort

Uh oh!

storybook-app-bot Bot commented Jan 23, 2026 •

edited

Loading

Uh oh!

Sidnioulz left a comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Uh oh!

Conversation

akornmeier commented Jan 23, 2026 • edited by coderabbitai Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Testing

Manual testing

Documentation

Checklist for Maintainers

🦋 Canary release

Summary by CodeRabbit

Uh oh!

coderabbitai Bot commented Jan 23, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Changes

Estimated code review effort

Uh oh!

storybook-app-bot Bot commented Jan 23, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Package Benchmarks

@storybook/addon-a11y

@storybook/addon-docs

@storybook/addon-links

@storybook/addon-onboarding

storybook-addon-pseudo-states

@storybook/addon-themes

@storybook/addon-vitest

@storybook/builder-vite

@storybook/builder-webpack5

storybook

@storybook/angular

@storybook/ember

@storybook/html-vite

@storybook/nextjs

@storybook/nextjs-vite

@storybook/preact-vite

@storybook/react-native-web-vite

@storybook/react-vite

@storybook/react-webpack5

@storybook/server-webpack5

@storybook/svelte-vite

@storybook/sveltekit

@storybook/vue3-vite

@storybook/web-components-vite

@storybook/cli

@storybook/codemod

@storybook/core-webpack

create-storybook

@storybook/csf-plugin

eslint-plugin-storybook

@storybook/react-dom-shim

@storybook/preset-create-react-app

@storybook/preset-react-webpack

@storybook/preset-server-webpack

@storybook/html

@storybook/preact

@storybook/react

@storybook/server

@storybook/svelte

@storybook/vue3

@storybook/web-components

Uh oh!

Sidnioulz left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

akornmeier commented Jan 23, 2026 •

edited by coderabbitai Bot

Loading

coderabbitai Bot commented Jan 23, 2026 •

edited

Loading

storybook-app-bot Bot commented Jan 23, 2026 •

edited

Loading

`@storybook/addon-a11y`

`@storybook/addon-docs`

`@storybook/addon-links`

`@storybook/addon-onboarding`

`storybook-addon-pseudo-states`

`@storybook/addon-themes`

`@storybook/addon-vitest`

`@storybook/builder-vite`

`@storybook/builder-webpack5`

`storybook`

`@storybook/angular`

`@storybook/ember`

`@storybook/html-vite`

`@storybook/nextjs`

`@storybook/nextjs-vite`

`@storybook/preact-vite`

`@storybook/react-native-web-vite`

`@storybook/react-vite`

`@storybook/react-webpack5`

`@storybook/server-webpack5`

`@storybook/svelte-vite`

`@storybook/sveltekit`

`@storybook/vue3-vite`

`@storybook/web-components-vite`

`@storybook/cli`

`@storybook/codemod`

`@storybook/core-webpack`

`create-storybook`

`@storybook/csf-plugin`

`eslint-plugin-storybook`

`@storybook/react-dom-shim`

`@storybook/preset-create-react-app`

`@storybook/preset-react-webpack`

`@storybook/preset-server-webpack`

`@storybook/html`

`@storybook/preact`

`@storybook/react`

`@storybook/server`

`@storybook/svelte`

`@storybook/vue3`

`@storybook/web-components`