Skip to content

Addon-Docs: ArgsTable borders in forced-colors mode#33618

Closed
nickcottrell wants to merge 2 commits into
storybookjs:nextfrom
nickcottrell:fix/argstable-high-contrast-borders
Closed

Addon-Docs: ArgsTable borders in forced-colors mode#33618
nickcottrell wants to merge 2 commits into
storybookjs:nextfrom
nickcottrell:fix/argstable-high-contrast-borders

Conversation

@nickcottrell
Copy link
Copy Markdown

@nickcottrell nickcottrell commented Jan 22, 2026

Fixes #24147

ArgsTable borders invisible in high contrast mode.

Use CanvasText in @media (forced-colors: active).

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented Jan 22, 2026

📝 Walkthrough

Walkthrough

Added forced-colors mode accessibility styling to the ArgsTable component by injecting @media (forced-colors: active) rules that adjust border color properties. No runtime logic or component behavior changes were introduced.

Changes

Cohort / File(s) Summary
ArgsTable accessibility styling
code/addons/docs/src/blocks/components/ArgsTable/ArgsTable.tsx
Added forced-colors mode support for border properties (borderTop, borderBlockStart, borderBlockEnd, borderInlineStart, borderInlineEnd) to ensure proper visibility in high-contrast and forced-color accessibility modes

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Possibly related PRs

✨ Finishing touches
  • 📝 Generate docstrings

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@valentinpalkovic valentinpalkovic changed the title fix(docs): ArgsTable borders in forced-colors mode Addon-Docs: ArgsTable borders in forced-colors mode Jan 26, 2026
@valentinpalkovic valentinpalkovic added bug accessibility addon: docs ci:normal Run our default set of CI jobs (choose this for most PRs). and removed accessibility addon: docs ci:normal Run our default set of CI jobs (choose this for most PRs). labels Jan 26, 2026
@storybook-app-bot
Copy link
Copy Markdown

storybook-app-bot Bot commented Jan 26, 2026

Package Benchmarks

Commit: cf2f00f, ran on 30 January 2026 at 15:12:26 UTC

No significant changes detected, all good. 👏

Copy link
Copy Markdown
Contributor

@Sidnioulz Sidnioulz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nickcottrell could you please provide screenshots of before/after on the OS and browser you used to test this?

I am not seeing any difference on Firefox or Chrome with this PR's code on compared to default forced colour adjustments.

@github-actions github-actions Bot added the Stale label Feb 13, 2026
@Sidnioulz
Copy link
Copy Markdown
Contributor

I'm gonna close this PR for now to help the team focus on active PRs. Feel free to reopen one with screenshots to show the platforms where a bug is fixed. Thanks!

@Sidnioulz Sidnioulz closed this Mar 19, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

accessibility addon: docs bug ci:normal Run our default set of CI jobs (choose this for most PRs). Stale

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: ArgsTable border is not very visible in High Contrast Mode

3 participants