Skip to content

CLI: Fix onboarding not opening #33609

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ndelangen merged 2 commits into from
Jan 21, 2026
Merged

CLI: Fix onboarding not opening #33609

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a35dd08
Refactor port handling and onboarding logic in runStorybookDev function
ndelangen Jan 21, 2026
26dfe51
Update comments in runStorybookDev function to clarify Angular flag h…
ndelangen Jan 21, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions code/lib/create-storybook/src/initiate.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -182,11 +182,11 @@ async function runStorybookDev(result: {
parts.push('--silent');
}

// in the case of Angular, we are calling `ng run` which doesn't allow passing flags to the command
const supportSbFlags = projectType !== ProjectType.ANGULAR;

if (supportSbFlags) {
// npm needs extra -- to pass flags to the command
// in the case of Angular, we are calling `ng run` which doesn't need the extra `--`
const doesNeedExtraDash =
packageManager.type === PackageManagerName.NPM ||
packageManager.type === PackageManagerName.BUN;
Expand All @@ -201,13 +201,13 @@ async function runStorybookDev(result: {

if (useAlternativePort) {
parts.push(`-p`, `${availablePort}`);
}

if (supportsOnboarding && shouldOnboard) {
parts.push('--initial-path=/onboarding');
}

parts.push('--quiet');
if (supportsOnboarding && shouldOnboard) {
parts.push('--initial-path=/onboarding');
}

parts.push('--quiet');
}

// instead of calling 'dev' automatically, we spawn a subprocess so that it gets
Expand Down