Skip to content

Add negative test case for create-rsbuild pattern and fix overly permissive regex #33604

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
shilman merged 2 commits into from
Jan 21, 2026
Merged

Add negative test case for create-rsbuild pattern and fix overly permissive regex #33604

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f5d9dde
Initial plan
Copilot Jan 21, 2026
6128e73
Add negative test case for create-rsbuild pattern and fix regex
Copilot Jan 21, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions code/lib/create-storybook/src/services/VersionService.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -156,6 +156,14 @@ describe('VersionService', () => {
expect(integration).toBe('create-rsbuild');
});

it('should NOT detect creatersbuild without separator', () => {
const ancestry = [{ command: 'npx creatersbuild' }];

const integration = versionService.getCliIntegrationFromAncestry(ancestry as any);

expect(integration).toBeUndefined();
});

it('should detect @tanstack/start command', () => {
const ancestry = [{ command: 'npx @tanstack/start@latest create my-app' }];

Expand Down
2 changes: 1 addition & 1 deletion code/lib/create-storybook/src/services/VersionService.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,7 +56,7 @@ export class VersionService {
return svMatch[1].toLowerCase().includes('add') ? 'sv add' : 'sv create';
}
// Check for create-rsbuild or create rsbuild
const rsbuildMatch = ancestor.command?.match(/(?:^|\s)create[\s\-]?rsbuild/i);
const rsbuildMatch = ancestor.command?.match(/(?:^|\s)create[\s\-]rsbuild/i);
if (rsbuildMatch) {
return 'create-rsbuild';
}
Expand Down
Loading