Skip to content

Build: Fix linting & docs #33601

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ndelangen merged 3 commits into from
Jan 20, 2026
Merged

Build: Fix linting & docs #33601

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
a295727
fix linting
ndelangen Jan 20, 2026
0e6a674
Update ESLint plugin documentation to clarify default export requirem…
ndelangen Jan 20, 2026
d8938d0
Clarify documentation for ESLint plugin regarding default export requ…
ndelangen Jan 20, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 9 additions & 13 deletions code/core/assets/server/base-preview-head.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,19 +2,19 @@

<style>
/* While we aren't showing the main block yet, but still preparing, we want everything the user has rendered, which may or may not be in #storybook-root, to be display none */
.sb-show-preparing-story:not(.sb-show-main)> :not(.sb-preparing-story) {
.sb-show-preparing-story:not(.sb-show-main) > :not(.sb-preparing-story) {
display: none;
}

.sb-show-preparing-docs:not(.sb-show-main)> :not(.sb-preparing-docs) {
.sb-show-preparing-docs:not(.sb-show-main) > :not(.sb-preparing-docs) {
display: none;
}

/* Hide our own blocks when we aren't supposed to be showing them */
:not(.sb-show-preparing-story)>.sb-preparing-story,
:not(.sb-show-preparing-docs)>.sb-preparing-docs,
:not(.sb-show-nopreview)>.sb-nopreview,
:not(.sb-show-errordisplay)>.sb-errordisplay {
:not(.sb-show-preparing-story) > .sb-preparing-story,
:not(.sb-show-preparing-docs) > .sb-preparing-docs,
:not(.sb-show-nopreview) > .sb-nopreview,
:not(.sb-show-errordisplay) > .sb-errordisplay {
display: none;
}

Expand All @@ -34,8 +34,7 @@
}

/* Vertical centering fix for IE11 */
@media screen and (-ms-high-contrast: none),
(-ms-high-contrast: active) {
@media screen and (-ms-high-contrast: none), (-ms-high-contrast: active) {
.sb-show-main.sb-main-centered:after {
content: '';
min-height: inherit;
Expand Down Expand Up @@ -188,7 +187,7 @@
margin: 0;
}

& li+li {
& li + li {
margin: 0;
padding: 0;
padding-top: 12px;
Expand Down Expand Up @@ -228,7 +227,6 @@
}
}


@-webkit-keyframes sb-rotate360 {
from {
transform: rotate(0deg);
Expand All @@ -250,7 +248,6 @@
}

@-webkit-keyframes sb-glow {

0%,
100% {
opacity: 1;
Expand All @@ -262,7 +259,6 @@
}

@keyframes sb-glow {

0%,
100% {
opacity: 1;
Expand Down Expand Up @@ -490,4 +486,4 @@
// eslint-disable-next-line no-console
console.warn('unable to connect to top frame for connecting dev tools');
}
</script>
</script>
2 changes: 1 addition & 1 deletion docs/configure/integration/eslint-plugin.mdx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -153,7 +153,7 @@ This plugin does not support MDX files.
| [`storybook/await-interactions`](https://github.com/storybookjs/storybook/blob/next/code/lib/eslint-plugin/docs/rules/await-interactions.md) | Interactions should be awaited | ✅ | <ul><li>addon-interactions</li><li>flat/addon-interactions</li><li>recommended</li><li>flat/recommended</li></ul> |
| [`storybook/context-in-play-function`](https://github.com/storybookjs/storybook/blob/next/code/lib/eslint-plugin/docs/rules/context-in-play-function.md) | Pass a context when invoking play function of another story | | <ul><li>recommended</li><li>flat/recommended</li><li>addon-interactions</li><li>flat/addon-interactions</li></ul> |
| [`storybook/csf-component`](https://github.com/storybookjs/storybook/blob/next/code/lib/eslint-plugin/docs/rules/csf-component.md) | The component property should be set | | <ul><li>csf</li><li>flat/csf</li><li>csf-strict</li><li>flat/csf-strict</li></ul> |
| [`storybook/default-exports`](https://github.com/storybookjs/storybook/blob/next/code/lib/eslint-plugin/docs/rules/default-exports.md) | Story files (unless using [CSF Next](../../api/csf/csf-next.mdx)) should have a default export | ✅ | <ul><li>csf</li><li>flat/csf</li><li>recommended</li><li>flat/recommended</li><li>csf-strict</li><li>flat/csf-strict</li></ul> |
| [`storybook/default-exports`](https://github.com/storybookjs/storybook/blob/next/code/lib/eslint-plugin/docs/rules/default-exports.md) | Story files should have a default export | ✅ | <ul><li>csf</li><li>flat/csf</li><li>recommended</li><li>flat/recommended</li><li>csf-strict</li><li>flat/csf-strict</li></ul> |
| [`storybook/hierarchy-separator`](https://github.com/storybookjs/storybook/blob/next/code/lib/eslint-plugin/docs/rules/hierarchy-separator.md) | Deprecated hierarchy separator in title property | ✅ | <ul><li>csf</li><li>flat/csf</li><li>recommended</li><li>flat/recommended</li><li>csf-strict</li><li>flat/csf-strict</li></ul> |
| [`storybook/meta-inline-properties`](https://github.com/storybookjs/storybook/blob/next/code/lib/eslint-plugin/docs/rules/meta-inline-properties.md) | Meta should only have inline properties | | N/A |
| [`storybook/meta-satisfies-type`](https://github.com/storybookjs/storybook/blob/next/code/lib/eslint-plugin/docs/rules/meta-satisfies-type.md) | Meta should use `satisfies Meta` | ✅ | N/A |
Expand Down