Core: Fix input width#33591
Conversation
|
View your CI Pipeline Execution ↗ for commit 7ee4fa6
☁️ Nx Cloud last updated this comment at |
📝 WalkthroughWalkthroughCSS styling updates to the Form Input component. One change adds full-width styling to ensure the input element expands to 100% width. The other corrects a formatting issue in style reset declarations by removing a leading whitespace character. Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes ✨ Finishing touches
Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Fix all issues with AI agents
In `@code/core/src/components/components/Form/Input.tsx`:
- Around line 84-87: The width: '100%' being applied after the sizes object
overrides size-specific styles (e.g., size="flex" -> {flex:1}, size="auto" ->
{display:'inline'}) causing layout regressions; update the Input style merge in
Input.tsx where styles, sizes, alignment, validation, { minHeight:32,
width:'100%' } are composed so that width is conditional on the resolved size:
if size === 'flex' do not set width (let flex:1 handle sizing), if size ===
'auto' avoid forcing width, otherwise apply width:'100%'; ensure the conditional
uses the same size prop used by the sizes map (refer to sizes and InputProps) so
Text, Files, Number controls retain their intended behavior.
| )<InputProps>(styles, sizes, alignment, validation, { | ||
| minHeight: 32, | ||
| width: '100%', | ||
| }), |
There was a problem hiding this comment.
🧩 Analysis chain
🏁 Script executed:
cat -n code/core/src/components/components/Form/Input.tsx | head -100Repository: storybookjs/storybook
Length of output: 2540
🏁 Script executed:
# Search for Input component usages with size prop
rg -n "size=\"|size={" code/core/src/components/components/Form/ -A 2 -B 2 --type tsxRepository: storybookjs/storybook
Length of output: 154
🏁 Script executed:
# Find all files that import Input from Form/Input
rg -l "from.*Form/Input|from.*Form/Input" code/ --type tsxRepository: storybookjs/storybook
Length of output: 92
🏁 Script executed:
# Search for size prop values being used in the codebase
rg "size=['\"]" code/ --type tsx -o | sort | uniq -cRepository: storybookjs/storybook
Length of output: 92
🏁 Script executed:
cat -n code/core/src/components/components/Form/styles.ts | head -150Repository: storybookjs/storybook
Length of output: 3610
🏁 Script executed:
# Search for Input component usages with size prop - corrected syntax
rg -n 'Input.*size=' code/ --type ts --type tsx -B 1 -A 1Repository: storybookjs/storybook
Length of output: 92
🏁 Script executed:
# Also search for imports of Input component
rg -n 'import.*Input.*from.*Form/Input' code/ --type ts --type tsxRepository: storybookjs/storybook
Length of output: 92
🏁 Script executed:
fd -t f -e ts -e tsx | xargs rg -l 'Input' | head -20Repository: storybookjs/storybook
Length of output: 1234
🏁 Script executed:
# Search directly for usage patterns
rg '<Input' code/ -A 2 | head -50Repository: storybookjs/storybook
Length of output: 3196
🏁 Script executed:
# Check if flex or auto size is used
rg "size=['\"]flex['\"]|size=['\"]auto['\"]" code/Repository: storybookjs/storybook
Length of output: 265
🏁 Script executed:
cat -n code/addons/docs/src/blocks/controls/Text.tsx | head -80Repository: storybookjs/storybook
Length of output: 2613
🏁 Script executed:
find code/core/src/components/components/Form -name "*.tsx" -type f | head -20Repository: storybookjs/storybook
Length of output: 788
🏁 Script executed:
cat -n code/core/src/components/components/Form/Textarea.tsx | head -50Repository: storybookjs/storybook
Length of output: 1698
🏁 Script executed:
cat -n code/core/src/components/components/Form/Textarea.tsx | tail -40Repository: storybookjs/storybook
Length of output: 1336
Check size prop behavior—width: '100%' overrides size="flex" which is actively used.
width: '100%' is applied after sizes, which means:
size="flex"returns{ flex: 1 }, thenwidth: '100%'overrides it (breaks flex layouts in Text, Files, Number controls)size="auto"returns{ display: 'inline' }, thenwidth: '100%'contradicts inline display
This is a functional regression affecting real uses in the codebase. Make width conditional on size to preserve the intended behavior:
Suggested fix
- )<InputProps>(styles, sizes, alignment, validation, {
- minHeight: 32,
- width: '100%',
- }),
+ )<InputProps>(styles, sizes, alignment, validation, ({ size }) => ({
+ minHeight: 32,
+ width: !size || size === '100%' ? '100%' : 'auto',
+ })),🤖 Prompt for AI Agents
In `@code/core/src/components/components/Form/Input.tsx` around lines 84 - 87, The
width: '100%' being applied after the sizes object overrides size-specific
styles (e.g., size="flex" -> {flex:1}, size="auto" -> {display:'inline'})
causing layout regressions; update the Input style merge in Input.tsx where
styles, sizes, alignment, validation, { minHeight:32, width:'100%' } are
composed so that width is conditional on the resolved size: if size === 'flex'
do not set width (let flex:1 handle sizing), if size === 'auto' avoid forcing
width, otherwise apply width:'100%'; ensure the conditional uses the same size
prop used by the sizes map (refer to sizes and InputProps) so Text, Files,
Number controls retain their intended behavior.
Package BenchmarksCommit: The following packages have significant changes to their size or dependencies:
|
| Before | After | Difference | |
|---|---|---|---|
| Dependency count | 538 | 538 | 0 |
| Self size | 646 KB | 646 KB | 🎉 -10 B 🎉 |
| Dependency size | 59.22 MB | 59.28 MB | 🚨 +58 KB 🚨 |
| Bundle Size Analyzer | Link | Link |
@storybook/nextjs-vite
| Before | After | Difference | |
|---|---|---|---|
| Dependency count | 127 | 127 | 0 |
| Self size | 1.12 MB | 1.12 MB | 🎉 -22 B 🎉 |
| Dependency size | 21.82 MB | 21.87 MB | 🚨 +49 KB 🚨 |
| Bundle Size Analyzer | Link | Link |
@storybook/react-native-web-vite
| Before | After | Difference | |
|---|---|---|---|
| Dependency count | 159 | 159 | 0 |
| Self size | 30 KB | 30 KB | 🚨 +8 B 🚨 |
| Dependency size | 23.00 MB | 23.17 MB | 🚨 +164 KB 🚨 |
| Bundle Size Analyzer | Link | Link |
@storybook/react-vite
| Before | After | Difference | |
|---|---|---|---|
| Dependency count | 117 | 117 | 0 |
| Self size | 35 KB | 35 KB | 🎉 -8 B 🎉 |
| Dependency size | 19.62 MB | 19.66 MB | 🚨 +49 KB 🚨 |
| Bundle Size Analyzer | Link | Link |
@storybook/react-webpack5
| Before | After | Difference | |
|---|---|---|---|
| Dependency count | 278 | 278 | 0 |
| Self size | 24 KB | 24 KB | 🚨 +2 B 🚨 |
| Dependency size | 44.13 MB | 44.19 MB | 🚨 +58 KB 🚨 |
| Bundle Size Analyzer | Link | Link |
@storybook/cli
| Before | After | Difference | |
|---|---|---|---|
| Dependency count | 183 | 183 | 0 |
| Self size | 775 KB | 775 KB | 🚨 +139 B 🚨 |
| Dependency size | 67.38 MB | 67.46 MB | 🚨 +79 KB 🚨 |
| Bundle Size Analyzer | Link | Link |
@storybook/codemod
| Before | After | Difference | |
|---|---|---|---|
| Dependency count | 176 | 176 | 0 |
| Self size | 30 KB | 30 KB | 🎉 -40 B 🎉 |
| Dependency size | 65.95 MB | 66.03 MB | 🚨 +79 KB 🚨 |
| Bundle Size Analyzer | Link | Link |
@storybook/react
| Before | After | Difference | |
|---|---|---|---|
| Dependency count | 57 | 57 | 0 |
| Self size | 732 KB | 781 KB | 🚨 +49 KB 🚨 |
| Dependency size | 12.94 MB | 12.94 MB | 🚨 +409 B 🚨 |
| Bundle Size Analyzer | Link | Link |
1 participant
What I did
Fixed a regression where inputs did not stretch to fill their container anymore.
Checklist for Contributors
Testing
The changes in this PR are covered in the following automated tests:
Manual testing
Caution
This section is mandatory for all contributions. If you believe no manual test is necessary, please state so explicitly. Thanks!
Documentation
MIGRATION.MD
Checklist for Maintainers
When this PR is ready for testing, make sure to add
ci:normal,ci:mergedorci:dailyGH label to it to run a specific set of sandboxes. The particular set of sandboxes can be found incode/lib/cli-storybook/src/sandbox-templates.tsMake sure this PR contains one of the labels below:
Available labels
bug: Internal changes that fixes incorrect behavior.maintenance: User-facing maintenance tasks.dependencies: Upgrading (sometimes downgrading) dependencies.build: Internal-facing build tooling & test updates. Will not show up in release changelog.cleanup: Minor cleanup style change. Will not show up in release changelog.documentation: Documentation only changes. Will not show up in release changelog.feature request: Introducing a new feature.BREAKING CHANGE: Changes that break compatibility in some way with current major version.other: Changes that don't fit in the above categories.🦋 Canary release
This PR does not have a canary release associated. You can request a canary release of this pull request by mentioning the
@storybookjs/coreteam here.core team members can create a canary release here or locally with
gh workflow run --repo storybookjs/storybook publish.yml --field pr=<PR_NUMBER>Summary by CodeRabbit
✏️ Tip: You can customize this high-level summary in your review settings.