Skip to content

UI: Fix border color for Select picker#33585

Merged
ghengeveld merged 1 commit into
nextfrom
fix-select-border
Jan 19, 2026
Merged

UI: Fix border color for Select picker#33585
ghengeveld merged 1 commit into
nextfrom
fix-select-border

Conversation

@ghengeveld
Copy link
Copy Markdown
Member

@ghengeveld ghengeveld commented Jan 19, 2026

What I did

Fixed this ugly border:
image

Now it looks correct in both light and dark mode:
Screenshot 2026-01-19 at 16 38 51
Screenshot 2026-01-19 at 16 39 17

Checklist for Contributors

Testing

The changes in this PR are covered in the following automated tests:

  • stories
  • unit tests
  • integration tests
  • end-to-end tests

Manual testing

Caution

This section is mandatory for all contributions. If you believe no manual test is necessary, please state so explicitly. Thanks!

Documentation

  • Add or update documentation reflecting your changes
  • If you are deprecating/removing a feature, make sure to update
    MIGRATION.MD

Checklist for Maintainers

  • When this PR is ready for testing, make sure to add ci:normal, ci:merged or ci:daily GH label to it to run a specific set of sandboxes. The particular set of sandboxes can be found in code/lib/cli-storybook/src/sandbox-templates.ts

  • Make sure this PR contains one of the labels below:

    Available labels
    • bug: Internal changes that fixes incorrect behavior.
    • maintenance: User-facing maintenance tasks.
    • dependencies: Upgrading (sometimes downgrading) dependencies.
    • build: Internal-facing build tooling & test updates. Will not show up in release changelog.
    • cleanup: Minor cleanup style change. Will not show up in release changelog.
    • documentation: Documentation only changes. Will not show up in release changelog.
    • feature request: Introducing a new feature.
    • BREAKING CHANGE: Changes that break compatibility in some way with current major version.
    • other: Changes that don't fit in the above categories.

🦋 Canary release

This PR does not have a canary release associated. You can request a canary release of this pull request by mentioning the @storybookjs/core team here.

core team members can create a canary release here or locally with gh workflow run --repo storybookjs/storybook publish.yml --field pr=<PR_NUMBER>

Summary by CodeRabbit

  • Style
    • Updated select component border styling to dynamically use theme values, ensuring better visual consistency with the application's overall design system.

✏️ Tip: You can customize this high-level summary in your review settings.

@ghengeveld ghengeveld requested a review from ndelangen January 19, 2026 15:41
@ghengeveld ghengeveld self-assigned this Jan 19, 2026
@ghengeveld ghengeveld added bug ci:normal Run our default set of CI jobs (choose this for most PRs). labels Jan 19, 2026
@nx-cloud
Copy link
Copy Markdown

nx-cloud Bot commented Jan 19, 2026

View your CI Pipeline Execution ↗ for commit a537267

Command Status Duration Result
nx run-many -t compile,check,knip,test,pretty-d... ✅ Succeeded 9m 33s View ↗

☁️ Nx Cloud last updated this comment at 2026-01-19 15:53:02 UTC

1 similar comment
@nx-cloud
Copy link
Copy Markdown

nx-cloud Bot commented Jan 19, 2026

View your CI Pipeline Execution ↗ for commit a537267

Command Status Duration Result
nx run-many -t compile,check,knip,test,pretty-d... ✅ Succeeded 9m 33s View ↗

☁️ Nx Cloud last updated this comment at 2026-01-19 15:53:02 UTC

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented Jan 19, 2026

📝 Walkthrough

Walkthrough

The Select component's native picker border styling has been updated to use a theme-based value instead of a hardcoded color. The border color now references theme.input.border through a template string, enabling consistent theming across the application.

Changes

Cohort / File(s) Summary
Theme-aware styling
code/core/src/components/components/Form/Select.tsx
Updated native picker border color from hardcoded #e4e4e7 to dynamic theme value ${theme.input.border}

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

✨ Finishing touches
  • 📝 Generate docstrings

Comment @coderabbitai help to get the list of available commands and usage tips.

@storybook-app-bot
Copy link
Copy Markdown

Package Benchmarks

Commit: a537267, ran on 19 January 2026 at 15:51:01 UTC

The following packages have significant changes to their size or dependencies:

@storybook/react-native-web-vite

Before After Difference
Dependency count 159 159 0
Self size 30 KB 30 KB 🚨 +8 B 🚨
Dependency size 23.00 MB 23.12 MB 🚨 +115 KB 🚨
Bundle Size Analyzer Link Link

@storybook/cli

Before After Difference
Dependency count 183 183 0
Self size 775 KB 775 KB 🚨 +139 B 🚨
Dependency size 67.38 MB 67.46 MB 🚨 +77 KB 🚨
Bundle Size Analyzer Link Link

@storybook/codemod

Before After Difference
Dependency count 176 176 0
Self size 30 KB 30 KB 🎉 -40 B 🎉
Dependency size 65.95 MB 66.03 MB 🚨 +77 KB 🚨
Bundle Size Analyzer Link Link

@ndelangen ndelangen changed the title Core: Fix border color for Select picker UI: Fix border color for Select picker Jan 19, 2026
@ghengeveld ghengeveld merged commit 0a4bd9a into next Jan 19, 2026
127 of 134 checks passed
@ghengeveld ghengeveld deleted the fix-select-border branch January 19, 2026 16:16
@github-actions github-actions Bot mentioned this pull request Jan 19, 2026
18 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug ci:normal Run our default set of CI jobs (choose this for most PRs).

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants