You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Sets CSS selectors with high specificty on all nodes of both Preview Error displays:
"No preview" which triggers when there are no stories
The error wrapper that shows a title, message and stack trace
This PR may have side effects on existing users' CSS customisations to the aforementioned UIs. We need to decide if we consider that a potential breaking change.
Checklist for Contributors
Testing
The changes in this PR are covered in the following automated tests:
When this PR is ready for testing, make sure to add ci:normal, ci:merged or ci:daily GH label to it to run a specific set of sandboxes. The particular set of sandboxes can be found in code/lib/cli-storybook/src/sandbox-templates.ts
Make sure this PR contains one of the labels below:
Available labels
bug: Internal changes that fixes incorrect behavior.
build: Internal-facing build tooling & test updates. Will not show up in release changelog.
cleanup: Minor cleanup style change. Will not show up in release changelog.
documentation: Documentation only changes. Will not show up in release changelog.
feature request: Introducing a new feature.
BREAKING CHANGE: Changes that break compatibility in some way with current major version.
other: Changes that don't fit in the above categories.
🦋 Canary release
This PR does not have a canary release associated. You can request a canary release of this pull request by mentioning the @storybookjs/core team here.
core team members can create a canary release here or locally with gh workflow run --repo storybookjs/storybook publish.yml --field pr=<PR_NUMBER>
Summary by CodeRabbit
Style
Improved error display visual styling with updated colors and enhanced readability
Refined preview block spacing and formatting consistency
Tests
Added new error display story variants with custom styling scenarios
✏️ Tip: You can customize this high-level summary in your review settings.
Updates CSS selectors and visual styling in the base preview HTML file to refine error display formatting and color schemes. Introduces two new story variants in the error stories file to demonstrate custom CSS styling application.
Changes
Cohort / File(s)
Summary
Preview HTML Styling code/core/assets/server/base-preview-head.html
CSS selector formatting normalization (removed spaces around combinators); visual theme adjustments for error/nopreview blocks (background color rgb(247,247,247), explicit text colors); new .sb-errordisplay_main and .sb-errordisplay_code blocks with layout, borders, and monospace typography; universal color resets for readability.
Story Variants code/core/src/preview-api/Errors.stories.tsx
Added internal StyleDecorator utility; introduced two new story exports (MyErrorWithCustomCSS, MissingWithCustomCSS) that extend existing stories with custom CSS styling via decorators.
Estimated code review effort
🎯 2 (Simple) | ⏱️ ~12 minutes
✨ Finishing touches
📝 Generate docstrings
Comment @coderabbitai help to get the list of available commands and usage tips.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #32749
What I did
Sets CSS selectors with high specificty on all nodes of both Preview Error displays:
This PR may have side effects on existing users' CSS customisations to the aforementioned UIs. We need to decide if we consider that a potential breaking change.
Checklist for Contributors
Testing
The changes in this PR are covered in the following automated tests:
Manual testing
Documentation
Checklist for Maintainers
When this PR is ready for testing, make sure to add
ci:normal,ci:mergedorci:dailyGH label to it to run a specific set of sandboxes. The particular set of sandboxes can be found incode/lib/cli-storybook/src/sandbox-templates.tsMake sure this PR contains one of the labels below:
Available labels
bug: Internal changes that fixes incorrect behavior.maintenance: User-facing maintenance tasks.dependencies: Upgrading (sometimes downgrading) dependencies.build: Internal-facing build tooling & test updates. Will not show up in release changelog.cleanup: Minor cleanup style change. Will not show up in release changelog.documentation: Documentation only changes. Will not show up in release changelog.feature request: Introducing a new feature.BREAKING CHANGE: Changes that break compatibility in some way with current major version.other: Changes that don't fit in the above categories.🦋 Canary release
This PR does not have a canary release associated. You can request a canary release of this pull request by mentioning the
@storybookjs/coreteam here.core team members can create a canary release here or locally with
gh workflow run --repo storybookjs/storybook publish.yml --field pr=<PR_NUMBER>Summary by CodeRabbit
Style
Tests
✏️ Tip: You can customize this high-level summary in your review settings.