Release: Prerelease 10.2.0-beta.3#33579
Merged
Merged
Conversation
…med` errors This is an attempt to fix the remaining `Exported variable '...' has or is using name '...' from external module "/..." but cannot be named` errors when using `definedPreview().meta().story()`.
…g handle functionality [skip ci]
Core: Viewport UX fixes
…Deps-nextjs-vite NextJSVite: Add `@opentelemetry/api` to `optimizeDeps`
TypeScript: Reduce `cannot be named` errors
- Modified configureFlatConfig to handle CallExpression wrappers like defineConfig([...]) - Added test case for Next.js-style ESLint configuration - All existing tests continue to pass Co-authored-by: yannbf <1671563+yannbf@users.noreply.github.com>
- Added proper type checks before accessing array arguments - Verify argument is Expression or TS type before unwrapping - Addresses code review feedback about unsafe type casting Co-authored-by: yannbf <1671563+yannbf@users.noreply.github.com>
- Removed redundant TS type checks from type guard - t.isExpression is sufficient since unwrapTSExpression handles TS types - All tests continue to pass Co-authored-by: yannbf <1671563+yannbf@users.noreply.github.com>
- Prevent potential runtime error when unwrapTSExpression returns null/undefined - Makes code more defensive and robust - All tests continue to pass Co-authored-by: yannbf <1671563+yannbf@users.noreply.github.com>
- Track eslintDefineConfigLocalName from "eslint/config" imports - Check callee matches defineConfig before modifying array - Add test for defineConfig from non-eslint/config source - Ensures we don't modify arbitrary function calls Co-authored-by: yannbf <1671563+yannbf@users.noreply.github.com>
- Added Case 2b to handle export default defineConfig([...]) from "eslint/config" - Added test case for direct export default defineConfig pattern - Ensures defineConfig directly exported is modified correctly Co-authored-by: yannbf <1671563+yannbf@users.noreply.github.com>
…in-eslint-config Core: Support defineConfig when setting up ESLint plugin
8f3df09 to
5dd4043
Compare
Package BenchmarksCommit: The following packages have significant changes to their size or dependencies:
|
| Before | After | Difference | |
|---|---|---|---|
| Dependency count | 159 | 159 | 0 |
| Self size | 30 KB | 30 KB | 🎉 -10 B 🎉 |
| Dependency size | 23.00 MB | 23.12 MB | 🚨 +115 KB 🚨 |
| Bundle Size Analyzer | Link | Link |
@storybook/cli
| Before | After | Difference | |
|---|---|---|---|
| Dependency count | 183 | 183 | 0 |
| Self size | 775 KB | 775 KB | 🚨 +360 B 🚨 |
| Dependency size | 67.38 MB | 67.46 MB | 🚨 +80 KB 🚨 |
| Bundle Size Analyzer | Link | Link |
@storybook/codemod
| Before | After | Difference | |
|---|---|---|---|
| Dependency count | 176 | 176 | 0 |
| Self size | 30 KB | 30 KB | 🎉 -4 B 🎉 |
| Dependency size | 65.95 MB | 66.03 MB | 🚨 +80 KB 🚨 |
| Bundle Size Analyzer | Link | Link |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is an automated pull request that bumps the version from
10.2.0-beta.2to10.2.0-beta.3.Once this pull request is merged, it will trigger a new release of version
10.2.0-beta.3.If you're not a core maintainer with permissions to release you can ignore this pull request.
To do
Before merging the PR, there are a few QA steps to go through:
And for each change below:
This is a list of all the PRs merged and commits pushed directly to
next, that will be part of this release:cannot be namederrors #33344opentelemetry/apitooptimizeDeps#33577If you've made any changes doing the above QA (change PR titles, revert PRs), manually trigger a re-generation of this PR with this workflow and wait for it to finish. It will wipe your progress in this to do, which is expected.
Feel free to manually commit any changes necessary to this branch after you've done the last re-generation, following the Make Manual Changes section in the docs, especially if you're making changes to the changelog.
When everything above is done:
Generated changelog
10.2.0-beta.3
opentelemetry/apitooptimizeDeps- #33577, thanks ndelangen!cannot be namederrors - #33344, thanks icopp!