Skip to content

Cli: Use npm for registry URL in PNPMProxy to avoid workspace errors #33571

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
valentinpalkovic merged 2 commits into from
Jan 29, 2026
Merged

Cli: Use npm for registry URL in PNPMProxy to avoid workspace errors #33571

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7f5fac2
fix: use npm for registry URL in PNPMProxy to avoid workspace errors
ia319 Jan 17, 2026
f251df3
Merge branch 'next' into bug/33508-use-npm-for-workspace-registry
valentinpalkovic Jan 29, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 7 additions & 2 deletions code/core/src/common/js-package-manager/PNPMProxy.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -103,9 +103,14 @@ export class PNPMProxy extends JsPackageManager {
}

public async getRegistryURL() {
// pnpm 10.7.1+ falls back to npm for certain config keys (including registry)
// https://github.com/pnpm/pnpm/pull/9346
// "npm config" commands are not allowed in workspaces per default
// https://github.com/npm/cli/issues/6099#issuecomment-1847584792
const childProcess = await executeCommand({
command: 'pnpm',
args: ['config', 'get', 'registry'],
command: 'npm',
cwd: this.cwd,
args: ['config', 'get', 'registry', '-ws=false', '-iwr'],
});
const url = (typeof childProcess.stdout === 'string' ? childProcess.stdout : '').trim();
return url === 'undefined' ? undefined : url;
Expand Down