Skip to content

Core: Fix panel overflowing issue#33570

Closed
ghengeveld wants to merge 1 commit into
nextfrom
panel-overflow
Closed

Core: Fix panel overflowing issue#33570
ghengeveld wants to merge 1 commit into
nextfrom
panel-overflow

Conversation

@ghengeveld
Copy link
Copy Markdown
Member

@ghengeveld ghengeveld commented Jan 17, 2026

Copy of #33450

What I did

Checklist for Contributors

Testing

The changes in this PR are covered in the following automated tests:

  • stories
  • unit tests
  • integration tests
  • end-to-end tests

Manual testing

Caution

This section is mandatory for all contributions. If you believe no manual test is necessary, please state so explicitly. Thanks!

Documentation

  • Add or update documentation reflecting your changes
  • If you are deprecating/removing a feature, make sure to update
    MIGRATION.MD

Checklist for Maintainers

  • When this PR is ready for testing, make sure to add ci:normal, ci:merged or ci:daily GH label to it to run a specific set of sandboxes. The particular set of sandboxes can be found in code/lib/cli-storybook/src/sandbox-templates.ts

  • Make sure this PR contains one of the labels below:

    Available labels
    • bug: Internal changes that fixes incorrect behavior.
    • maintenance: User-facing maintenance tasks.
    • dependencies: Upgrading (sometimes downgrading) dependencies.
    • build: Internal-facing build tooling & test updates. Will not show up in release changelog.
    • cleanup: Minor cleanup style change. Will not show up in release changelog.
    • documentation: Documentation only changes. Will not show up in release changelog.
    • feature request: Introducing a new feature.
    • BREAKING CHANGE: Changes that break compatibility in some way with current major version.
    • other: Changes that don't fit in the above categories.

🦋 Canary release

This PR does not have a canary release associated. You can request a canary release of this pull request by mentioning the @storybookjs/core team here.

core team members can create a canary release here or locally with gh workflow run --repo storybookjs/storybook publish.yml --field pr=<PR_NUMBER>

Summary by CodeRabbit

  • Refactor
    • Reorganized internal layout structure for improved modularity and responsiveness while maintaining compatibility.

✏️ Tip: You can customize this high-level summary in your review settings.

@nx-cloud
Copy link
Copy Markdown

nx-cloud Bot commented Jan 17, 2026

View your CI Pipeline Execution ↗ for commit 01bcc3f

Command Status Duration Result
nx run-many -t compile,check,knip,test,pretty-d... ⛔ Cancelled 4h 51m 9s View ↗

☁️ Nx Cloud last updated this comment at 2026-01-17 20:30:03 UTC

@nx-cloud
Copy link
Copy Markdown

nx-cloud Bot commented Jan 17, 2026

View your CI Pipeline Execution ↗ for commit 01bcc3f


☁️ Nx Cloud last updated this comment at 2026-01-17 15:37:56 UTC

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented Jan 17, 2026

📝 Walkthrough

Walkthrough

The Layout component's internal structure was refactored from a grid-based composition to a flex-based layout. A new ContentPanelWrapper encapsulates panel and content areas, and the sidebar now uses inline styling instead of grid configuration. Panel rendering logic was moved and repositioned within the hierarchy with added PanelSlot wrapper management.

Changes

Cohort / File(s) Summary
Layout component restructuring
code/core/src/manager/components/layout/Layout.tsx
Replaced grid-based layout declarations with flex-based composition; introduced ContentPanelWrapper and PanelSlot styled components; moved panel rendering into ContentPanelWrapper; changed sidebar width to inline style; adjusted conditional rendering for pages and main content; updated PanelContainer to use inline dimensions based on panelPosition; removed explicit isDragging propagation through LayoutContainer.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

Possibly related PRs

✨ Finishing touches
  • 📝 Generate docstrings

Comment @coderabbitai help to get the list of available commands and usage tips.

@storybook-app-bot
Copy link
Copy Markdown

Package Benchmarks

Commit: 01bcc3f, ran on 17 January 2026 at 15:45:55 UTC

The following packages have significant changes to their size or dependencies:

@storybook/react-native-web-vite

Before After Difference
Dependency count 159 159 0
Self size 30 KB 30 KB 🚨 +8 B 🚨
Dependency size 23.00 MB 23.12 MB 🚨 +115 KB 🚨
Bundle Size Analyzer Link Link

@storybook/cli

Before After Difference
Dependency count 183 183 0
Self size 775 KB 775 KB 🚨 +139 B 🚨
Dependency size 67.38 MB 67.45 MB 🚨 +69 KB 🚨
Bundle Size Analyzer Link Link

@storybook/codemod

Before After Difference
Dependency count 176 176 0
Self size 30 KB 30 KB 🎉 -4 B 🎉
Dependency size 65.95 MB 66.02 MB 🚨 +69 KB 🚨
Bundle Size Analyzer Link Link

@ghengeveld ghengeveld closed this Jan 19, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant