Skip to content

Build: Update Visual Tests addon#33569

Merged
ghengeveld merged 2 commits into
nextfrom
update-vta
Jan 19, 2026
Merged

Build: Update Visual Tests addon#33569
ghengeveld merged 2 commits into
nextfrom
update-vta

Conversation

@ghengeveld
Copy link
Copy Markdown
Member

@ghengeveld ghengeveld commented Jan 17, 2026

What I did

Upgraded Visual Tests addon and fixed its configuration.

Checklist for Contributors

Testing

The changes in this PR are covered in the following automated tests:

  • stories
  • unit tests
  • integration tests
  • end-to-end tests

Manual testing

Start storybook:ui and run a VTA build.

Documentation

  • Add or update documentation reflecting your changes
  • If you are deprecating/removing a feature, make sure to update
    MIGRATION.MD

Checklist for Maintainers

  • When this PR is ready for testing, make sure to add ci:normal, ci:merged or ci:daily GH label to it to run a specific set of sandboxes. The particular set of sandboxes can be found in code/lib/cli-storybook/src/sandbox-templates.ts

  • Make sure this PR contains one of the labels below:

    Available labels
    • bug: Internal changes that fixes incorrect behavior.
    • maintenance: User-facing maintenance tasks.
    • dependencies: Upgrading (sometimes downgrading) dependencies.
    • build: Internal-facing build tooling & test updates. Will not show up in release changelog.
    • cleanup: Minor cleanup style change. Will not show up in release changelog.
    • documentation: Documentation only changes. Will not show up in release changelog.
    • feature request: Introducing a new feature.
    • BREAKING CHANGE: Changes that break compatibility in some way with current major version.
    • other: Changes that don't fit in the above categories.

🦋 Canary release

This PR does not have a canary release associated. You can request a canary release of this pull request by mentioning the @storybookjs/core team here.

core team members can create a canary release here or locally with gh workflow run --repo storybookjs/storybook publish.yml --field pr=<PR_NUMBER>

Summary by CodeRabbit

  • Chores
    • Upgraded Storybook integration dependency to major version 5.
    • Optimized build configuration to use a dedicated build script and focus on modified files only.

✏️ Tip: You can customize this high-level summary in your review settings.

@ghengeveld ghengeveld self-assigned this Jan 17, 2026
@ghengeveld ghengeveld added build Internal-facing build tooling & test updates ci:normal labels Jan 17, 2026
@nx-cloud
Copy link
Copy Markdown

nx-cloud Bot commented Jan 17, 2026

View your CI Pipeline Execution ↗ for commit cfb9096

Command Status Duration Result
nx run-many -t compile,check,knip,test,pretty-d... ✅ Succeeded 8m 47s View ↗

☁️ Nx Cloud last updated this comment at 2026-01-17 13:39:01 UTC

@ghengeveld ghengeveld requested a review from ndelangen January 17, 2026 13:30
@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented Jan 17, 2026

📝 Walkthrough

Walkthrough

Updates the Chromatic configuration to specify a build script name and base directory while restricting builds to only changed files. Additionally upgrades the @chromatic-com/storybook dependency from version 4.1.3 to 5.0.0.

Changes

Cohort / File(s) Summary
Chromatic Configuration
code/chromatic.config.json
Added buildScriptName ("storybook:ui:build") and storybookBaseDir ("code") fields; updated onlyChanged from false to true
Dependency Upgrade
code/package.json
Updated @chromatic-com/storybook from ^4.1.3 to ^5.0.0 (major version bump)

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Possibly related PRs


Comment @coderabbitai help to get the list of available commands and usage tips.

@storybook-app-bot
Copy link
Copy Markdown

Package Benchmarks

Commit: cfb9096, ran on 17 January 2026 at 13:36:37 UTC

The following packages have significant changes to their size or dependencies:

@storybook/react-native-web-vite

Before After Difference
Dependency count 159 159 0
Self size 30 KB 30 KB 🚨 +8 B 🚨
Dependency size 23.00 MB 23.12 MB 🚨 +115 KB 🚨
Bundle Size Analyzer Link Link

@storybook/cli

Before After Difference
Dependency count 183 183 0
Self size 775 KB 775 KB 🚨 +55 B 🚨
Dependency size 67.38 MB 67.45 MB 🚨 +69 KB 🚨
Bundle Size Analyzer Link Link

@storybook/codemod

Before After Difference
Dependency count 176 176 0
Self size 30 KB 30 KB 🎉 -4 B 🎉
Dependency size 65.95 MB 66.02 MB 🚨 +69 KB 🚨
Bundle Size Analyzer Link Link

@ghengeveld ghengeveld merged commit f0ed614 into next Jan 19, 2026
130 of 133 checks passed
@ghengeveld ghengeveld deleted the update-vta branch January 19, 2026 08:41
@github-actions github-actions Bot mentioned this pull request Jan 19, 2026
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

build Internal-facing build tooling & test updates ci:normal

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants