Skip to content

Zoom: Keyboardshortcut for the plus key #33565

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ndelangen merged 4 commits into from
Jan 16, 2026
Merged

Zoom: Keyboardshortcut for the plus key #33565

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
387f8d2
zoom in when the user uses the `plus` key
ndelangen Jan 16, 2026
ad7b69d
Merge branch 'next' into norbert/keyboard-plus-zoom
ndelangen Jan 16, 2026
956e722
Rename zoom action from 'zoomIn' to 'zoomPlus' for clarity in shortcu…
ndelangen Jan 16, 2026
6587802
Merge branch 'next' into norbert/keyboard-plus-zoom
ndelangen Jan 16, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions code/core/src/manager/components/preview/tools/zoom.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -196,6 +196,12 @@ const ZoomWrapper = memo<{
actionName: 'zoomIn',
action: zoomIn,
});
api.setAddonShortcut('zoom', {
label: 'Zoom in',
defaultShortcut: ['alt', '+'],
actionName: 'zoomPlus',
action: zoomIn,
});
Comment on lines +199 to +204

@ghengeveld ghengeveld Jan 16, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did you verify this works? I would thing this is going to override the existing zoomIn action. You should probably give it an alternative name, such as zoomInAlt. Do not that it will then show up twice in the keyboard shortcuts table.

@ndelangen ndelangen Jan 16, 2026 •
edited
Loading

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I THINK it tried both, but now you're making me second guess myself, I'll re-test it locally!

Yup, good catch! I'll change it, so they both work.
I tried looking for a way for a single "action" to be linked to multiple keyboard-shortcuts, but that's not allowed by the system we have, and this is not the right time to be changing that significantly.

api.setAddonShortcut('zoom', {
label: 'Zoom out',
defaultShortcut: ['alt', '-'],
Expand Down
Loading