Addon-docs: Add MDX manifest generation#33408
Merged
Merged
Conversation
- Create manifest.ts to generate manifests for MDX files - Filter MDX entries with 'attached-mdx' or 'unattached-mdx' tags - Export experimental_manifests from preset.ts - Add comprehensive tests for MDX manifest generation Co-authored-by: JReinhold <5678122+JReinhold@users.noreply.github.com>
Co-authored-by: JReinhold <5678122+JReinhold@users.noreply.github.com>
Co-authored-by: JReinhold <5678122+JReinhold@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Add support for MDX files in manifest generation
feat(addon-docs): add MDX manifest generation
Dec 22, 2025
Base automatically changed from
jeppe/support-manifest-tag-in-preview
to
next
December 22, 2025 22:04
|
View your CI Pipeline Execution ↗ for commit 2f7d638
☁️ Nx Cloud last updated this comment at |
JReinhold
changed the title
JReinhold
added
react
addon: docs
ci:normal
manifest
Package BenchmarksCommit: The following packages have significant changes to their size or dependencies:
|
| Before | After | Difference | |
|---|---|---|---|
| Dependency count | 49 | 49 | 0 |
| Self size | 20.18 MB | 20.20 MB | 🚨 +20 KB 🚨 |
| Dependency size | 16.52 MB | 16.52 MB | 🎉 -2 B 🎉 |
| Bundle Size Analyzer | Link | Link |
@storybook/cli
| Before | After | Difference | |
|---|---|---|---|
| Dependency count | 183 | 183 | 0 |
| Self size | 775 KB | 775 KB | 🚨 +53 B 🚨 |
| Dependency size | 67.23 MB | 67.25 MB | 🚨 +20 KB 🚨 |
| Bundle Size Analyzer | Link | Link |
@storybook/codemod
| Before | After | Difference | |
|---|---|---|---|
| Dependency count | 176 | 176 | 0 |
| Self size | 30 KB | 30 KB | 🎉 -2 B 🎉 |
| Dependency size | 65.80 MB | 65.82 MB | 🚨 +20 KB 🚨 |
| Bundle Size Analyzer | Link | Link |
create-storybook
| Before | After | Difference | |
|---|---|---|---|
| Dependency count | 50 | 50 | 0 |
| Self size | 999 KB | 999 KB | 🎉 -3 B 🎉 |
| Dependency size | 36.70 MB | 36.72 MB | 🚨 +20 KB 🚨 |
| Bundle Size Analyzer | node | node |
JReinhold
changed the title
Contributor
📝 WalkthroughWalkthroughAdds a Docs manifest pipeline that classifies DocsIndexEntry items (attached/unattached/ignored), extracts MDX content or errors, attaches docs to component manifests, and emits a separate unattached docs manifest; also centralizes tag constants and updates manifest/component generators and tests to use Tag.*. Changes
Sequence Diagram(s)sequenceDiagram
participant Preset as experimental_manifests
participant Grouper as Entry Grouper
participant Attached as Attached Handler
participant Unattached as Unattached Handler
participant Components as Components Manifest Store
participant DocsOut as Docs Manifest Store
Note over Preset,Grouper: Input: manifestEntries filtered for docs
Preset->>Grouper: classify entries by Tag (ATTACHED_MDX / UNATTACHED_MDX / ignore)
par attach and extract concurrently
Grouper->>Attached: attached-mdx entries + existing components
Attached->>Components: resolve storyFilePath, attach docs into component manifests
Components-->>Attached: updated components manifest
Grouper->>Unattached: unattached-mdx entries
Unattached->>Unattached: read MDX files (createDocsManifestEntry)
Unattached-->>DocsOut: docs manifest entries (content or error)
end
Components->>Preset: return updated components manifest
DocsOut->>Preset: return docs manifest
Preset->>Preset: merge into final ManifestsWithDocs (docs + components)
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~25 minutes Possibly related PRs
✨ Finishing touches
📜 Recent review detailsConfiguration used: Organization UI Review profile: CHILL Plan: Pro 📒 Files selected for processing (11)
🚧 Files skipped from review as they are similar to previous changes (5)
🧰 Additional context used📓 Path-based instructions (5)**/*.{js,jsx,ts,tsx,json,md,html,css,scss}📄 CodeRabbit inference engine (.github/copilot-instructions.md)
Files:
**/*.{js,jsx,json,html,ts,tsx,mjs}📄 CodeRabbit inference engine (.github/copilot-instructions.md)
Files:
**/*.{ts,tsx}📄 CodeRabbit inference engine (.github/copilot-instructions.md)
Files:
**/*.{ts,tsx,js,jsx}📄 CodeRabbit inference engine (.github/copilot-instructions.md)
Files:
code/{core,lib,addons,builders,frameworks,presets}/**/*.{ts,tsx,js,jsx}📄 CodeRabbit inference engine (.github/copilot-instructions.md)
Files:
🧠 Learnings (9)📚 Learning: 2025-11-05T09:38:47.712ZApplied to files:
📚 Learning: 2025-09-24T09:39:39.233ZApplied to files:
📚 Learning: 2025-09-18T20:51:06.618ZApplied to files:
📚 Learning: 2025-09-18T20:51:06.618ZApplied to files:
📚 Learning: 2025-11-05T09:37:25.920ZApplied to files:
📚 Learning: 2025-12-22T22:03:40.123ZApplied to files:
📚 Learning: 2025-11-05T09:36:55.944ZApplied to files:
📚 Learning: 2025-10-01T15:24:01.060ZApplied to files:
📚 Learning: 2025-12-22T22:03:40.123ZApplied to files:
🧬 Code graph analysis (5)code/core/src/manager-api/lib/stories.ts (1)
code/addons/vitest/src/manager.tsx (1)
code/core/src/csf-tools/CsfFile.ts (3)
code/core/src/manager/components/sidebar/TagsFilter.tsx (4)
code/renderers/react/src/componentManifest/generator.ts (1)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (3)
🔇 Additional comments (13)
Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (2)
code/addons/docs/src/manifest.ts (2)
92-116: Consider a non-mutating approach forextractAttachedDocsEntries.This function mutates
existingComponentsdirectly (lines 108-111). While it works correctly and the caller handles the result appropriately, a non-mutating approach would be more predictable and align with functional programming best practices.🔎 Proposed non-mutating approach
export async function extractAttachedDocsEntries( entries: DocsIndexEntry[], existingComponents: ComponentsManifestWithDocs | undefined ): Promise<ComponentsManifestWithDocs | undefined> { if (!existingComponents || entries.length === 0) { return existingComponents; } const entriesWithContent = await Promise.all(entries.map(createDocsManifestEntry)); + // Build updated components without mutating + const updatedComponents = { ...existingComponents.components }; + // Add docs to their corresponding components based on the entry id prefix for (const docsEntry of entriesWithContent) { const componentId = docsEntry.id.split('--')[0]; - const component = existingComponents.components[componentId]; + const component = updatedComponents[componentId]; if (component) { - if (!component.docs) { - component.docs = {}; - } - component.docs[docsEntry.id] = docsEntry; + updatedComponents[componentId] = { + ...component, + docs: { + ...component.docs, + [docsEntry.id]: docsEntry, + }, + }; } } - return existingComponents; + return { + ...existingComponents, + components: updatedComponents, + }; }
16-17: These constants are duplicated across the codebase.The same
ATTACHED_MDX_TAGandUNATTACHED_MDX_TAGconstants are already exported fromcode/core/src/core-server/utils/StoryIndexGenerator.ts(and also fromcode/core/src/preview-api/modules/preview-web/PreviewWithSelection.tsx). However, they are not currently exposed through thestorybook/internal/*public API, and importing from those internal core-server modules would require a cross-package import. Consider whether extracting these to a sharedstorybook/internal/*export location would be worthwhile to eliminate duplication.
📜 Review details
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (5)
code/addons/docs/src/manifest.test.tscode/addons/docs/src/manifest.tscode/addons/docs/src/preset.tscode/renderers/react/src/componentManifest/generator.test.tscode/renderers/react/src/componentManifest/generator.ts
🧰 Additional context used
📓 Path-based instructions (8)
**/*.{js,jsx,ts,tsx,json,md,html,css,scss}
📄 CodeRabbit inference engine (.github/copilot-instructions.md)
Format code using Prettier with
yarn prettier --write <file>
Files:
code/addons/docs/src/manifest.tscode/addons/docs/src/preset.tscode/addons/docs/src/manifest.test.tscode/renderers/react/src/componentManifest/generator.tscode/renderers/react/src/componentManifest/generator.test.ts
**/*.{js,jsx,json,html,ts,tsx,mjs}
📄 CodeRabbit inference engine (.github/copilot-instructions.md)
Run ESLint checks using
yarn lint:js:cmd <file>or the full commandcross-env NODE_ENV=production eslint --cache --cache-location=../.cache/eslint --ext .js,.jsx,.json,.html,.ts,.tsx,.mjs --report-unused-disable-directivesto fix linting errors before committing
Files:
code/addons/docs/src/manifest.tscode/addons/docs/src/preset.tscode/addons/docs/src/manifest.test.tscode/renderers/react/src/componentManifest/generator.tscode/renderers/react/src/componentManifest/generator.test.ts
**/*.{ts,tsx}
📄 CodeRabbit inference engine (.github/copilot-instructions.md)
Enable TypeScript strict mode across all packages
Files:
code/addons/docs/src/manifest.tscode/addons/docs/src/preset.tscode/addons/docs/src/manifest.test.tscode/renderers/react/src/componentManifest/generator.tscode/renderers/react/src/componentManifest/generator.test.ts
**/*.{ts,tsx,js,jsx}
📄 CodeRabbit inference engine (.github/copilot-instructions.md)
**/*.{ts,tsx,js,jsx}: Export functions from modules if they need to be tested
Do not useconsole.log,console.warn, orconsole.errordirectly unless in isolated files where importing loggers would significantly increase bundle size
Files:
code/addons/docs/src/manifest.tscode/addons/docs/src/preset.tscode/addons/docs/src/manifest.test.tscode/renderers/react/src/componentManifest/generator.tscode/renderers/react/src/componentManifest/generator.test.ts
code/{core,lib,addons,builders,frameworks,presets}/**/*.{ts,tsx,js,jsx}
📄 CodeRabbit inference engine (.github/copilot-instructions.md)
Use
loggerfromstorybook/internal/node-loggerfor server-side logging in Node.js code
Files:
code/addons/docs/src/manifest.tscode/addons/docs/src/preset.tscode/addons/docs/src/manifest.test.ts
**/*.{test,spec}.{ts,tsx}
📄 CodeRabbit inference engine (.cursorrules)
**/*.{test,spec}.{ts,tsx}: Test files should follow the naming pattern*.test.ts,*.test.tsx,*.spec.ts, or*.spec.tsx
Follow the spy mocking rules defined in.cursor/rules/spy-mocking.mdcfor consistent mocking patterns with Vitest
Files:
code/addons/docs/src/manifest.test.tscode/renderers/react/src/componentManifest/generator.test.ts
**/*.test.{ts,tsx,js,jsx}
📄 CodeRabbit inference engine (.cursor/rules/spy-mocking.mdc)
**/*.test.{ts,tsx,js,jsx}: Usevi.mock()with thespy: trueoption for all package and file mocks in Vitest tests
Place all mocks at the top of the test file before any test cases
Usevi.mocked()to type and access the mocked functions in Vitest tests
Implement mock behaviors inbeforeEachblocks in Vitest tests
Mock all required dependencies that the test subject uses
Each mock implementation should return a Promise for async functions in Vitest
Mock implementations should match the expected return type of the original function
Mock all required properties and methods that the test subject uses in Vitest tests
Avoid direct function mocking withoutvi.mocked()in Vitest tests
Avoid mock implementations outside ofbeforeEachblocks in Vitest tests
Avoid mocking without thespy: trueoption in Vitest tests
Avoid inline mock implementations within test cases in Vitest tests
Avoid mocking only a subset of required dependencies in Vitest tests
Mock at the highest level of abstraction needed in Vitest tests
Keep mock implementations simple and focused in Vitest tests
Use type-safe mocking withvi.mocked()in Vitest tests
Document complex mock behaviors in Vitest tests
Group related mocks together in Vitest tests
Files:
code/addons/docs/src/manifest.test.tscode/renderers/react/src/componentManifest/generator.test.ts
**/*.{test,spec}.{ts,tsx,js,jsx}
📄 CodeRabbit inference engine (.github/copilot-instructions.md)
**/*.{test,spec}.{ts,tsx,js,jsx}: Write meaningful unit tests that actually import and call the functions being tested, not just verify syntax patterns
Achieve high test coverage of business logic, aiming for 75%+ coverage of statements/lines
Cover all branches, conditions, edge cases, error paths, and different input variations in unit tests
Usevi.mock()to mock file system, loggers, and other external dependencies in tests
Files:
code/addons/docs/src/manifest.test.tscode/renderers/react/src/componentManifest/generator.test.ts
🧠 Learnings (20)
📓 Common learnings
Learnt from: CR
Repo: storybookjs/storybook PR: 0
File: .github/copilot-instructions.md:0-0
Timestamp: 2025-12-22T22:03:40.123Z
Learning: Applies to {code/addons,code/frameworks}/**/README.md : Update README files for significant changes and include code examples in addon/framework documentation
📚 Learning: 2025-12-22T22:03:40.123Z
Learnt from: CR
Repo: storybookjs/storybook PR: 0
File: .github/copilot-instructions.md:0-0
Timestamp: 2025-12-22T22:03:40.123Z
Learning: Applies to {code/addons,code/frameworks}/**/README.md : Update README files for significant changes and include code examples in addon/framework documentation
Applied to files:
code/addons/docs/src/manifest.ts
📚 Learning: 2025-12-22T22:03:40.123Z
Learnt from: CR
Repo: storybookjs/storybook PR: 0
File: .github/copilot-instructions.md:0-0
Timestamp: 2025-12-22T22:03:40.123Z
Learning: Applies to code/{core,lib,addons,builders,frameworks,presets}/**/*.{ts,tsx,js,jsx} : Use `logger` from `storybook/internal/node-logger` for server-side logging in Node.js code
Applied to files:
code/addons/docs/src/preset.tscode/renderers/react/src/componentManifest/generator.ts
📚 Learning: 2025-12-22T22:03:40.123Z
Learnt from: CR
Repo: storybookjs/storybook PR: 0
File: .github/copilot-instructions.md:0-0
Timestamp: 2025-12-22T22:03:40.123Z
Learning: Applies to code/{renderers}/**/*.{ts,tsx,js,jsx} : Use `logger` from `storybook/internal/client-logger` for client-side logging in browser code
Applied to files:
code/addons/docs/src/preset.tscode/renderers/react/src/componentManifest/generator.ts
📚 Learning: 2025-12-22T22:03:40.123Z
Learnt from: CR
Repo: storybookjs/storybook PR: 0
File: .github/copilot-instructions.md:0-0
Timestamp: 2025-12-22T22:03:40.123Z
Learning: Applies to **/*.{test,spec}.{ts,tsx,js,jsx} : Cover all branches, conditions, edge cases, error paths, and different input variations in unit tests
Applied to files:
code/addons/docs/src/manifest.test.ts
📚 Learning: 2025-12-22T22:03:40.123Z
Learnt from: CR
Repo: storybookjs/storybook PR: 0
File: .github/copilot-instructions.md:0-0
Timestamp: 2025-12-22T22:03:40.123Z
Learning: Applies to **/*.{test,spec}.{ts,tsx,js,jsx} : Write meaningful unit tests that actually import and call the functions being tested, not just verify syntax patterns
Applied to files:
code/addons/docs/src/manifest.test.tscode/renderers/react/src/componentManifest/generator.test.ts
📚 Learning: 2025-11-24T17:49:59.279Z
Learnt from: CR
Repo: storybookjs/storybook PR: 0
File: .cursor/rules/spy-mocking.mdc:0-0
Timestamp: 2025-11-24T17:49:59.279Z
Learning: Applies to **/*.test.{ts,tsx,js,jsx} : Document complex mock behaviors in Vitest tests
Applied to files:
code/addons/docs/src/manifest.test.ts
📚 Learning: 2025-11-24T17:49:59.279Z
Learnt from: CR
Repo: storybookjs/storybook PR: 0
File: .cursor/rules/spy-mocking.mdc:0-0
Timestamp: 2025-11-24T17:49:59.279Z
Learning: Applies to **/*.test.{ts,tsx,js,jsx} : Avoid mocking only a subset of required dependencies in Vitest tests
Applied to files:
code/addons/docs/src/manifest.test.ts
📚 Learning: 2025-11-24T17:49:59.279Z
Learnt from: CR
Repo: storybookjs/storybook PR: 0
File: .cursor/rules/spy-mocking.mdc:0-0
Timestamp: 2025-11-24T17:49:59.279Z
Learning: Applies to **/*.test.{ts,tsx,js,jsx} : Avoid inline mock implementations within test cases in Vitest tests
Applied to files:
code/addons/docs/src/manifest.test.ts
📚 Learning: 2025-11-24T17:49:59.279Z
Learnt from: CR
Repo: storybookjs/storybook PR: 0
File: .cursor/rules/spy-mocking.mdc:0-0
Timestamp: 2025-11-24T17:49:59.279Z
Learning: Applies to **/*.test.{ts,tsx,js,jsx} : Keep mock implementations simple and focused in Vitest tests
Applied to files:
code/addons/docs/src/manifest.test.ts
📚 Learning: 2025-11-24T17:49:59.279Z
Learnt from: CR
Repo: storybookjs/storybook PR: 0
File: .cursor/rules/spy-mocking.mdc:0-0
Timestamp: 2025-11-24T17:49:59.279Z
Learning: Applies to **/*.test.{ts,tsx,js,jsx} : Avoid mock implementations outside of `beforeEach` blocks in Vitest tests
Applied to files:
code/addons/docs/src/manifest.test.ts
📚 Learning: 2025-11-24T17:49:59.279Z
Learnt from: CR
Repo: storybookjs/storybook PR: 0
File: .cursor/rules/spy-mocking.mdc:0-0
Timestamp: 2025-11-24T17:49:59.279Z
Learning: Applies to **/*.test.{ts,tsx,js,jsx} : Each mock implementation should return a Promise for async functions in Vitest
Applied to files:
code/addons/docs/src/manifest.test.ts
📚 Learning: 2025-11-24T17:49:59.279Z
Learnt from: CR
Repo: storybookjs/storybook PR: 0
File: .cursor/rules/spy-mocking.mdc:0-0
Timestamp: 2025-11-24T17:49:59.279Z
Learning: Applies to **/*.test.{ts,tsx,js,jsx} : Implement mock behaviors in `beforeEach` blocks in Vitest tests
Applied to files:
code/addons/docs/src/manifest.test.ts
📚 Learning: 2025-11-24T17:49:59.279Z
Learnt from: CR
Repo: storybookjs/storybook PR: 0
File: .cursor/rules/spy-mocking.mdc:0-0
Timestamp: 2025-11-24T17:49:59.279Z
Learning: Applies to **/*.test.{ts,tsx,js,jsx} : Group related mocks together in Vitest tests
Applied to files:
code/addons/docs/src/manifest.test.ts
📚 Learning: 2025-11-24T17:49:59.279Z
Learnt from: CR
Repo: storybookjs/storybook PR: 0
File: .cursor/rules/spy-mocking.mdc:0-0
Timestamp: 2025-11-24T17:49:59.279Z
Learning: Applies to **/*.test.{ts,tsx,js,jsx} : Mock all required properties and methods that the test subject uses in Vitest tests
Applied to files:
code/addons/docs/src/manifest.test.ts
📚 Learning: 2025-12-22T22:03:40.123Z
Learnt from: CR
Repo: storybookjs/storybook PR: 0
File: .github/copilot-instructions.md:0-0
Timestamp: 2025-12-22T22:03:40.123Z
Learning: Applies to **/*.{test,spec}.{ts,tsx,js,jsx} : Use `vi.mock()` to mock file system, loggers, and other external dependencies in tests
Applied to files:
code/addons/docs/src/manifest.test.ts
📚 Learning: 2025-10-01T15:24:01.060Z
Learnt from: Sidnioulz
Repo: storybookjs/storybook PR: 32594
File: code/core/src/components/components/Popover/WithPopover.tsx:7-9
Timestamp: 2025-10-01T15:24:01.060Z
Learning: In the Storybook repository, "react-aria-components/patched-dist/*" (e.g., "react-aria-components/patched-dist/Dialog", "react-aria-components/patched-dist/Popover", "react-aria-components/patched-dist/Tooltip") are valid import paths created by a patch applied to the react-aria-components package. These imports should not be flagged as broken or invalid until a maintainer explicitly states they are no longer acceptable.
Applied to files:
code/renderers/react/src/componentManifest/generator.ts
📚 Learning: 2025-11-05T09:38:47.712Z
Learnt from: Sidnioulz
Repo: storybookjs/storybook PR: 32458
File: code/core/src/components/components/Select/Select.tsx:200-204
Timestamp: 2025-11-05T09:38:47.712Z
Learning: Repo: storybookjs/storybook — Guidance: Until Storybook 11 is released, do not suggest using React.useId anywhere (e.g., in code/core/src/components/components/Select/Select.tsx) to maintain compatibility with React 17 runtimes. Prefer advising: accept a caller-provided props.id and, if needed, generate a client-only fallback id to minimize SSR hydration issues — but avoid useId. Resume prompting for useId after Storybook 11.
Applied to files:
code/renderers/react/src/componentManifest/generator.ts
📚 Learning: 2025-11-05T09:37:25.920Z
Learnt from: Sidnioulz
Repo: storybookjs/storybook PR: 32458
File: code/core/src/components/components/tooltip/WithTooltip.tsx:54-96
Timestamp: 2025-11-05T09:37:25.920Z
Learning: Repo: storybookjs/storybook — In code/core/src/components/components/tooltip/WithTooltip.tsx, the legacy WithTooltip implementation is intentionally reintroduced for backward compatibility and is deprecated; maintainers (per Sidnioulz) do not want maintenance or improvements on it. Prefer WithTooltipNew/Popover; avoid suggesting changes to WithTooltip.* going forward.
Applied to files:
code/renderers/react/src/componentManifest/generator.ts
📚 Learning: 2025-09-24T09:39:39.233Z
Learnt from: ndelangen
Repo: storybookjs/storybook PR: 32507
File: code/core/src/manager/globals/globals-module-info.ts:25-33
Timestamp: 2025-09-24T09:39:39.233Z
Learning: In Storybook, storybook/actions/decorator is a preview-only entrypoint and should not be included in manager globals configuration. The duplicatedKeys array in code/core/src/manager/globals/globals-module-info.ts is specifically for manager-side externalization, not preview entrypoints.
Applied to files:
code/renderers/react/src/componentManifest/generator.ts
🧬 Code graph analysis (2)
code/addons/docs/src/manifest.ts (1)
code/core/src/core-server/utils/StoryIndexGenerator.ts (2)
ATTACHED_MDX_TAG(68-68)UNATTACHED_MDX_TAG(69-69)
code/renderers/react/src/componentManifest/generator.ts (1)
code/core/src/core-server/utils/StoryIndexGenerator.ts (1)
ATTACHED_MDX_TAG(68-68)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (3)
- GitHub Check: normal
- GitHub Check: Core Unit Tests, windows-latest
- GitHub Check: nx
🔇 Additional comments (9)
code/addons/docs/src/preset.ts (1)
221-221: LGTM!Clean re-export that exposes the new docs manifest functionality through the preset system. The
experimental_prefix appropriately signals the API's maturity level.code/renderers/react/src/componentManifest/generator.test.ts (1)
461-565: LGTM!Well-structured test that verifies component manifest generation when only attached-mdx docs entries have the
manifesttag. The test:
- Follows existing test patterns in the file
- Clearly documents the scenario being tested via comments
- Properly sets up the docs entry with required fields (
storiesImports,attached-mdxtag)- Validates the expected manifest structure via snapshot
code/renderers/react/src/componentManifest/generator.ts (3)
110-118: LGTM!The filter logic correctly extends manifest generation to include attached docs entries. The conditions properly guard against accessing
storiesImportswhen it's empty.
124-129: LGTM!The
storyFilePathderivation correctly handles both entry types:
- Stories use their
importPathdirectly- Attached docs use
storiesImports[0]to locate the associated story fileThis ensures the component manifest is built from the correct source file in both cases.
20-21: The suggestion to importATTACHED_MDX_TAGfrom a shared location is not feasible. The constant is not exported through any public API (storybook/internalor otherwise), and the react renderer is intentionally kept separate fromcore-server. The local duplication is the correct approach for maintaining package boundaries.Likely an incorrect or invalid review comment.
code/addons/docs/src/manifest.test.ts (2)
10-13: Mock setup note.The mock pattern here doesn't use the
spy: trueoption mentioned in the coding guidelines. However, since this is mocking the entirenode:fs/promisesmodule with memfs (not spying on individual functions), this approach is appropriate for this use case.
50-360: Excellent test coverage!The test suite thoroughly covers the docs manifest functionality:
- ✅ No docs entries scenario
- ✅ Filtering out docs without proper tags
- ✅ Attached docs integration with component manifests
- ✅ Unattached docs in separate manifest
- ✅ Mixed attached/unattached handling
- ✅ Preservation of existing manifests
- ✅ Error handling for file read failures
- ✅ Mixed success/error scenarios
All tests follow the pattern of actually calling the
manifestsfunction and asserting on the results. Good job covering edge cases and error paths per the coding guidelines.code/addons/docs/src/manifest.ts (2)
47-71: LGTM!The
createDocsManifestEntryfunction properly:
- Resolves paths relative to cwd
- Reads file content asynchronously
- Handles errors gracefully by returning a structured error object instead of throwing
This allows partial success when processing multiple docs entries.
127-185: Well-structured manifest orchestration.The main
manifestsfunction:
- Early returns for empty inputs (good performance optimization)
- Uses
groupByfor clean categorization with explicit handling of ignored entries- Processes attached and unattached docs in parallel via
Promise.all- Includes verbose performance logging
- Properly spreads existing manifests to avoid mutation at the top level
|
|
||
| /** Converts a DocsIndexEntry to a DocsManifestEntry by reading its file content. */ | ||
| export async function createDocsManifestEntry(entry: DocsIndexEntry): Promise<DocsManifestEntry> { | ||
| const absolutePath = path.join(process.cwd(), entry.importPath); |
Contributor
There was a problem hiding this comment.
As discussed, evaluating the absolute path of the import path needs a helper function and refactoring, because it's opaque to know what the "workingDir" actually is. I have agreed with Jeppe that refactoring and adjusting other code places as well will be a separate task, likely implemented in the next cooldown cycle.
|
|
||
| // Add docs to their corresponding components based on the entry id prefix | ||
| for (const docsEntry of entriesWithContent) { | ||
| const componentId = docsEntry.id.split('--')[0]; |
Contributor
There was a problem hiding this comment.
We should use a helper function to get the component id. Does storybook/internal/csf already provide a proper helper function?
| import { type DocObj } from './reactDocgen'; | ||
| import { cachedFindUp, cachedReadFileSync, invalidateCache, invariant } from './utils'; | ||
|
|
||
| const ATTACHED_MDX_TAG = 'attached-mdx'; |
Contributor
There was a problem hiding this comment.
We should export the tag const from core and re-use it in addon/docs and react
Contributor
|
|
JReinhold
added a commit
to storybookjs/mcp
that referenced
this pull request
Jan 5, 2026
valentinpalkovic
approved these changes
Jan 5, 2026
Contributor
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Fix all issues with AI Agents
In @code/core/src/manager/globals/exports.ts:
- Line 319: This file was manually edited to add the 'Tag' export but is
auto-generated; remove the manual 'Tag' entry from exports.ts and run the
generator (generate-source-files.ts) so it picks up 'Tag' from
storybook/manager-api/index.ts (which is imported via runtime.ts) and
regenerates the exports list correctly.
📜 Review details
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (40)
code/addons/docs/src/blocks/blocks/Stories.tsxcode/addons/docs/src/blocks/blocks/usePrimaryStory.test.tsxcode/addons/docs/src/blocks/blocks/usePrimaryStory.tscode/addons/docs/src/manifest.test.tscode/addons/docs/src/manifest.tscode/addons/vitest/src/manager.tsxcode/addons/vitest/src/node/test-manager.test.tscode/addons/vitest/src/node/vitest-manager.tscode/addons/vitest/src/vitest-plugin/index.tscode/core/src/core-server/index.tscode/core/src/core-server/presets/common-manager.tscode/core/src/core-server/utils/StoryIndexGenerator.test.tscode/core/src/core-server/utils/StoryIndexGenerator.tscode/core/src/core-server/utils/__tests__/index-extraction.test.tscode/core/src/core-server/utils/manifests/manifests.test.tscode/core/src/core-server/utils/manifests/manifests.tscode/core/src/core-server/utils/summarizeIndex.test.tscode/core/src/core-server/utils/summarizeIndex.tscode/core/src/csf-tools/CsfFile.tscode/core/src/csf-tools/vitest-plugin/transformer.test.tscode/core/src/csf/csf-factories.tscode/core/src/manager-api/index.mock.tscode/core/src/manager-api/index.tscode/core/src/manager-api/lib/stories.tscode/core/src/manager/components/sidebar/TagsFilter.tsxcode/core/src/manager/globals/exports.tscode/core/src/preview-api/index.tscode/core/src/preview-api/modules/preview-web/PreviewWeb.mockdata.tscode/core/src/preview-api/modules/preview-web/PreviewWithSelection.tsxcode/core/src/preview-api/modules/preview-web/render/CsfDocsRender.test.tscode/core/src/preview-api/modules/store/csf/portable-stories.test.tscode/core/src/preview-api/modules/store/csf/prepareStory.test.tscode/core/src/preview-api/modules/store/csf/prepareStory.tscode/core/src/shared/checklist-store/checklistData.tsxcode/core/src/shared/constants/tags.tscode/lib/cli-storybook/src/automigrate/fixes/remove-docs-autodocs.tscode/renderers/react/src/componentManifest/fixtures.tscode/renderers/react/src/componentManifest/generator.test.tscode/renderers/react/src/componentManifest/generator.tscode/renderers/react/src/entry-preview.tsx
🚧 Files skipped from review as they are similar to previous changes (2)
- code/renderers/react/src/componentManifest/generator.test.ts
- code/addons/docs/src/manifest.test.ts
🧰 Additional context used
📓 Path-based instructions (8)
**/*.{js,jsx,ts,tsx,json,md,html,css,scss}
📄 CodeRabbit inference engine (.github/copilot-instructions.md)
Format code using Prettier with
yarn prettier --write <file>
Files:
code/core/src/manager-api/index.mock.tscode/renderers/react/src/entry-preview.tsxcode/core/src/core-server/utils/manifests/manifests.tscode/renderers/react/src/componentManifest/generator.tscode/renderers/react/src/componentManifest/fixtures.tscode/addons/vitest/src/manager.tsxcode/addons/docs/src/blocks/blocks/usePrimaryStory.test.tsxcode/core/src/preview-api/modules/store/csf/prepareStory.test.tscode/core/src/core-server/index.tscode/addons/docs/src/blocks/blocks/Stories.tsxcode/core/src/csf-tools/vitest-plugin/transformer.test.tscode/addons/docs/src/blocks/blocks/usePrimaryStory.tscode/core/src/shared/checklist-store/checklistData.tsxcode/core/src/core-server/utils/__tests__/index-extraction.test.tscode/core/src/manager/globals/exports.tscode/core/src/preview-api/modules/preview-web/render/CsfDocsRender.test.tscode/core/src/preview-api/index.tscode/core/src/preview-api/modules/preview-web/PreviewWithSelection.tsxcode/core/src/preview-api/modules/store/csf/prepareStory.tscode/core/src/manager-api/index.tscode/core/src/core-server/utils/manifests/manifests.test.tscode/lib/cli-storybook/src/automigrate/fixes/remove-docs-autodocs.tscode/core/src/preview-api/modules/preview-web/PreviewWeb.mockdata.tscode/core/src/core-server/utils/summarizeIndex.tscode/core/src/core-server/utils/StoryIndexGenerator.test.tscode/core/src/core-server/utils/summarizeIndex.test.tscode/core/src/manager-api/lib/stories.tscode/addons/vitest/src/node/vitest-manager.tscode/addons/vitest/src/vitest-plugin/index.tscode/core/src/core-server/presets/common-manager.tscode/core/src/csf/csf-factories.tscode/core/src/manager/components/sidebar/TagsFilter.tsxcode/core/src/core-server/utils/StoryIndexGenerator.tscode/addons/docs/src/manifest.tscode/core/src/preview-api/modules/store/csf/portable-stories.test.tscode/core/src/shared/constants/tags.tscode/addons/vitest/src/node/test-manager.test.tscode/core/src/csf-tools/CsfFile.ts
**/*.{js,jsx,json,html,ts,tsx,mjs}
📄 CodeRabbit inference engine (.github/copilot-instructions.md)
Run ESLint checks using
yarn lint:js:cmd <file>or the full commandcross-env NODE_ENV=production eslint --cache --cache-location=../.cache/eslint --ext .js,.jsx,.json,.html,.ts,.tsx,.mjs --report-unused-disable-directivesto fix linting errors before committing
Files:
code/core/src/manager-api/index.mock.tscode/renderers/react/src/entry-preview.tsxcode/core/src/core-server/utils/manifests/manifests.tscode/renderers/react/src/componentManifest/generator.tscode/renderers/react/src/componentManifest/fixtures.tscode/addons/vitest/src/manager.tsxcode/addons/docs/src/blocks/blocks/usePrimaryStory.test.tsxcode/core/src/preview-api/modules/store/csf/prepareStory.test.tscode/core/src/core-server/index.tscode/addons/docs/src/blocks/blocks/Stories.tsxcode/core/src/csf-tools/vitest-plugin/transformer.test.tscode/addons/docs/src/blocks/blocks/usePrimaryStory.tscode/core/src/shared/checklist-store/checklistData.tsxcode/core/src/core-server/utils/__tests__/index-extraction.test.tscode/core/src/manager/globals/exports.tscode/core/src/preview-api/modules/preview-web/render/CsfDocsRender.test.tscode/core/src/preview-api/index.tscode/core/src/preview-api/modules/preview-web/PreviewWithSelection.tsxcode/core/src/preview-api/modules/store/csf/prepareStory.tscode/core/src/manager-api/index.tscode/core/src/core-server/utils/manifests/manifests.test.tscode/lib/cli-storybook/src/automigrate/fixes/remove-docs-autodocs.tscode/core/src/preview-api/modules/preview-web/PreviewWeb.mockdata.tscode/core/src/core-server/utils/summarizeIndex.tscode/core/src/core-server/utils/StoryIndexGenerator.test.tscode/core/src/core-server/utils/summarizeIndex.test.tscode/core/src/manager-api/lib/stories.tscode/addons/vitest/src/node/vitest-manager.tscode/addons/vitest/src/vitest-plugin/index.tscode/core/src/core-server/presets/common-manager.tscode/core/src/csf/csf-factories.tscode/core/src/manager/components/sidebar/TagsFilter.tsxcode/core/src/core-server/utils/StoryIndexGenerator.tscode/addons/docs/src/manifest.tscode/core/src/preview-api/modules/store/csf/portable-stories.test.tscode/core/src/shared/constants/tags.tscode/addons/vitest/src/node/test-manager.test.tscode/core/src/csf-tools/CsfFile.ts
**/*.{ts,tsx}
📄 CodeRabbit inference engine (.github/copilot-instructions.md)
Enable TypeScript strict mode across all packages
Files:
code/core/src/manager-api/index.mock.tscode/renderers/react/src/entry-preview.tsxcode/core/src/core-server/utils/manifests/manifests.tscode/renderers/react/src/componentManifest/generator.tscode/renderers/react/src/componentManifest/fixtures.tscode/addons/vitest/src/manager.tsxcode/addons/docs/src/blocks/blocks/usePrimaryStory.test.tsxcode/core/src/preview-api/modules/store/csf/prepareStory.test.tscode/core/src/core-server/index.tscode/addons/docs/src/blocks/blocks/Stories.tsxcode/core/src/csf-tools/vitest-plugin/transformer.test.tscode/addons/docs/src/blocks/blocks/usePrimaryStory.tscode/core/src/shared/checklist-store/checklistData.tsxcode/core/src/core-server/utils/__tests__/index-extraction.test.tscode/core/src/manager/globals/exports.tscode/core/src/preview-api/modules/preview-web/render/CsfDocsRender.test.tscode/core/src/preview-api/index.tscode/core/src/preview-api/modules/preview-web/PreviewWithSelection.tsxcode/core/src/preview-api/modules/store/csf/prepareStory.tscode/core/src/manager-api/index.tscode/core/src/core-server/utils/manifests/manifests.test.tscode/lib/cli-storybook/src/automigrate/fixes/remove-docs-autodocs.tscode/core/src/preview-api/modules/preview-web/PreviewWeb.mockdata.tscode/core/src/core-server/utils/summarizeIndex.tscode/core/src/core-server/utils/StoryIndexGenerator.test.tscode/core/src/core-server/utils/summarizeIndex.test.tscode/core/src/manager-api/lib/stories.tscode/addons/vitest/src/node/vitest-manager.tscode/addons/vitest/src/vitest-plugin/index.tscode/core/src/core-server/presets/common-manager.tscode/core/src/csf/csf-factories.tscode/core/src/manager/components/sidebar/TagsFilter.tsxcode/core/src/core-server/utils/StoryIndexGenerator.tscode/addons/docs/src/manifest.tscode/core/src/preview-api/modules/store/csf/portable-stories.test.tscode/core/src/shared/constants/tags.tscode/addons/vitest/src/node/test-manager.test.tscode/core/src/csf-tools/CsfFile.ts
**/*.{ts,tsx,js,jsx}
📄 CodeRabbit inference engine (.github/copilot-instructions.md)
**/*.{ts,tsx,js,jsx}: Export functions from modules if they need to be tested
Do not useconsole.log,console.warn, orconsole.errordirectly unless in isolated files where importing loggers would significantly increase bundle size
Files:
code/core/src/manager-api/index.mock.tscode/renderers/react/src/entry-preview.tsxcode/core/src/core-server/utils/manifests/manifests.tscode/renderers/react/src/componentManifest/generator.tscode/renderers/react/src/componentManifest/fixtures.tscode/addons/vitest/src/manager.tsxcode/addons/docs/src/blocks/blocks/usePrimaryStory.test.tsxcode/core/src/preview-api/modules/store/csf/prepareStory.test.tscode/core/src/core-server/index.tscode/addons/docs/src/blocks/blocks/Stories.tsxcode/core/src/csf-tools/vitest-plugin/transformer.test.tscode/addons/docs/src/blocks/blocks/usePrimaryStory.tscode/core/src/shared/checklist-store/checklistData.tsxcode/core/src/core-server/utils/__tests__/index-extraction.test.tscode/core/src/manager/globals/exports.tscode/core/src/preview-api/modules/preview-web/render/CsfDocsRender.test.tscode/core/src/preview-api/index.tscode/core/src/preview-api/modules/preview-web/PreviewWithSelection.tsxcode/core/src/preview-api/modules/store/csf/prepareStory.tscode/core/src/manager-api/index.tscode/core/src/core-server/utils/manifests/manifests.test.tscode/lib/cli-storybook/src/automigrate/fixes/remove-docs-autodocs.tscode/core/src/preview-api/modules/preview-web/PreviewWeb.mockdata.tscode/core/src/core-server/utils/summarizeIndex.tscode/core/src/core-server/utils/StoryIndexGenerator.test.tscode/core/src/core-server/utils/summarizeIndex.test.tscode/core/src/manager-api/lib/stories.tscode/addons/vitest/src/node/vitest-manager.tscode/addons/vitest/src/vitest-plugin/index.tscode/core/src/core-server/presets/common-manager.tscode/core/src/csf/csf-factories.tscode/core/src/manager/components/sidebar/TagsFilter.tsxcode/core/src/core-server/utils/StoryIndexGenerator.tscode/addons/docs/src/manifest.tscode/core/src/preview-api/modules/store/csf/portable-stories.test.tscode/core/src/shared/constants/tags.tscode/addons/vitest/src/node/test-manager.test.tscode/core/src/csf-tools/CsfFile.ts
code/{core,lib,addons,builders,frameworks,presets}/**/*.{ts,tsx,js,jsx}
📄 CodeRabbit inference engine (.github/copilot-instructions.md)
Use
loggerfromstorybook/internal/node-loggerfor server-side logging in Node.js code
Files:
code/core/src/manager-api/index.mock.tscode/core/src/core-server/utils/manifests/manifests.tscode/addons/vitest/src/manager.tsxcode/addons/docs/src/blocks/blocks/usePrimaryStory.test.tsxcode/core/src/preview-api/modules/store/csf/prepareStory.test.tscode/core/src/core-server/index.tscode/addons/docs/src/blocks/blocks/Stories.tsxcode/core/src/csf-tools/vitest-plugin/transformer.test.tscode/addons/docs/src/blocks/blocks/usePrimaryStory.tscode/core/src/shared/checklist-store/checklistData.tsxcode/core/src/core-server/utils/__tests__/index-extraction.test.tscode/core/src/manager/globals/exports.tscode/core/src/preview-api/modules/preview-web/render/CsfDocsRender.test.tscode/core/src/preview-api/index.tscode/core/src/preview-api/modules/preview-web/PreviewWithSelection.tsxcode/core/src/preview-api/modules/store/csf/prepareStory.tscode/core/src/manager-api/index.tscode/core/src/core-server/utils/manifests/manifests.test.tscode/lib/cli-storybook/src/automigrate/fixes/remove-docs-autodocs.tscode/core/src/preview-api/modules/preview-web/PreviewWeb.mockdata.tscode/core/src/core-server/utils/summarizeIndex.tscode/core/src/core-server/utils/StoryIndexGenerator.test.tscode/core/src/core-server/utils/summarizeIndex.test.tscode/core/src/manager-api/lib/stories.tscode/addons/vitest/src/node/vitest-manager.tscode/addons/vitest/src/vitest-plugin/index.tscode/core/src/core-server/presets/common-manager.tscode/core/src/csf/csf-factories.tscode/core/src/manager/components/sidebar/TagsFilter.tsxcode/core/src/core-server/utils/StoryIndexGenerator.tscode/addons/docs/src/manifest.tscode/core/src/preview-api/modules/store/csf/portable-stories.test.tscode/core/src/shared/constants/tags.tscode/addons/vitest/src/node/test-manager.test.tscode/core/src/csf-tools/CsfFile.ts
**/*.{test,spec}.{ts,tsx}
📄 CodeRabbit inference engine (.cursorrules)
**/*.{test,spec}.{ts,tsx}: Test files should follow the naming pattern*.test.ts,*.test.tsx,*.spec.ts, or*.spec.tsx
Follow the spy mocking rules defined in.cursor/rules/spy-mocking.mdcfor consistent mocking patterns with Vitest
Files:
code/addons/docs/src/blocks/blocks/usePrimaryStory.test.tsxcode/core/src/preview-api/modules/store/csf/prepareStory.test.tscode/core/src/csf-tools/vitest-plugin/transformer.test.tscode/core/src/core-server/utils/__tests__/index-extraction.test.tscode/core/src/preview-api/modules/preview-web/render/CsfDocsRender.test.tscode/core/src/core-server/utils/manifests/manifests.test.tscode/core/src/core-server/utils/StoryIndexGenerator.test.tscode/core/src/core-server/utils/summarizeIndex.test.tscode/core/src/preview-api/modules/store/csf/portable-stories.test.tscode/addons/vitest/src/node/test-manager.test.ts
**/*.test.{ts,tsx,js,jsx}
📄 CodeRabbit inference engine (.cursor/rules/spy-mocking.mdc)
**/*.test.{ts,tsx,js,jsx}: Usevi.mock()with thespy: trueoption for all package and file mocks in Vitest tests
Place all mocks at the top of the test file before any test cases
Usevi.mocked()to type and access the mocked functions in Vitest tests
Implement mock behaviors inbeforeEachblocks in Vitest tests
Mock all required dependencies that the test subject uses
Each mock implementation should return a Promise for async functions in Vitest
Mock implementations should match the expected return type of the original function
Mock all required properties and methods that the test subject uses in Vitest tests
Avoid direct function mocking withoutvi.mocked()in Vitest tests
Avoid mock implementations outside ofbeforeEachblocks in Vitest tests
Avoid mocking without thespy: trueoption in Vitest tests
Avoid inline mock implementations within test cases in Vitest tests
Avoid mocking only a subset of required dependencies in Vitest tests
Mock at the highest level of abstraction needed in Vitest tests
Keep mock implementations simple and focused in Vitest tests
Use type-safe mocking withvi.mocked()in Vitest tests
Document complex mock behaviors in Vitest tests
Group related mocks together in Vitest tests
Files:
code/addons/docs/src/blocks/blocks/usePrimaryStory.test.tsxcode/core/src/preview-api/modules/store/csf/prepareStory.test.tscode/core/src/csf-tools/vitest-plugin/transformer.test.tscode/core/src/core-server/utils/__tests__/index-extraction.test.tscode/core/src/preview-api/modules/preview-web/render/CsfDocsRender.test.tscode/core/src/core-server/utils/manifests/manifests.test.tscode/core/src/core-server/utils/StoryIndexGenerator.test.tscode/core/src/core-server/utils/summarizeIndex.test.tscode/core/src/preview-api/modules/store/csf/portable-stories.test.tscode/addons/vitest/src/node/test-manager.test.ts
**/*.{test,spec}.{ts,tsx,js,jsx}
📄 CodeRabbit inference engine (.github/copilot-instructions.md)
**/*.{test,spec}.{ts,tsx,js,jsx}: Write meaningful unit tests that actually import and call the functions being tested, not just verify syntax patterns
Achieve high test coverage of business logic, aiming for 75%+ coverage of statements/lines
Cover all branches, conditions, edge cases, error paths, and different input variations in unit tests
Usevi.mock()to mock file system, loggers, and other external dependencies in tests
Files:
code/addons/docs/src/blocks/blocks/usePrimaryStory.test.tsxcode/core/src/preview-api/modules/store/csf/prepareStory.test.tscode/core/src/csf-tools/vitest-plugin/transformer.test.tscode/core/src/core-server/utils/__tests__/index-extraction.test.tscode/core/src/preview-api/modules/preview-web/render/CsfDocsRender.test.tscode/core/src/core-server/utils/manifests/manifests.test.tscode/core/src/core-server/utils/StoryIndexGenerator.test.tscode/core/src/core-server/utils/summarizeIndex.test.tscode/core/src/preview-api/modules/store/csf/portable-stories.test.tscode/addons/vitest/src/node/test-manager.test.ts
🧠 Learnings (34)
📚 Learning: 2025-12-22T22:03:40.123Z
Learnt from: CR
Repo: storybookjs/storybook PR: 0
File: .github/copilot-instructions.md:0-0
Timestamp: 2025-12-22T22:03:40.123Z
Learning: Applies to **/*.{ts,tsx,js,jsx} : Export functions from modules if they need to be tested
Applied to files:
code/core/src/manager-api/index.mock.tscode/core/src/core-server/utils/__tests__/index-extraction.test.ts
📚 Learning: 2025-11-24T17:49:59.279Z
Learnt from: CR
Repo: storybookjs/storybook PR: 0
File: .cursor/rules/spy-mocking.mdc:0-0
Timestamp: 2025-11-24T17:49:59.279Z
Learning: Applies to **/*.test.{ts,tsx,js,jsx} : Mock all required dependencies that the test subject uses
Applied to files:
code/core/src/manager-api/index.mock.tscode/renderers/react/src/componentManifest/fixtures.tscode/core/src/core-server/utils/manifests/manifests.test.ts
📚 Learning: 2025-11-05T09:38:47.712Z
Learnt from: Sidnioulz
Repo: storybookjs/storybook PR: 32458
File: code/core/src/components/components/Select/Select.tsx:200-204
Timestamp: 2025-11-05T09:38:47.712Z
Learning: Repo: storybookjs/storybook — Guidance: Until Storybook 11 is released, do not suggest using React.useId anywhere (e.g., in code/core/src/components/components/Select/Select.tsx) to maintain compatibility with React 17 runtimes. Prefer advising: accept a caller-provided props.id and, if needed, generate a client-only fallback id to minimize SSR hydration issues — but avoid useId. Resume prompting for useId after Storybook 11.
Applied to files:
code/core/src/manager-api/index.mock.tscode/renderers/react/src/entry-preview.tsxcode/renderers/react/src/componentManifest/generator.tscode/renderers/react/src/componentManifest/fixtures.tscode/addons/vitest/src/manager.tsxcode/addons/docs/src/blocks/blocks/usePrimaryStory.test.tsxcode/core/src/preview-api/modules/store/csf/prepareStory.test.tscode/core/src/core-server/index.tscode/addons/docs/src/blocks/blocks/Stories.tsxcode/addons/docs/src/blocks/blocks/usePrimaryStory.tscode/core/src/shared/checklist-store/checklistData.tsxcode/core/src/core-server/utils/__tests__/index-extraction.test.tscode/core/src/preview-api/modules/preview-web/render/CsfDocsRender.test.tscode/core/src/preview-api/modules/store/csf/prepareStory.tscode/lib/cli-storybook/src/automigrate/fixes/remove-docs-autodocs.tscode/core/src/core-server/utils/summarizeIndex.tscode/core/src/core-server/utils/StoryIndexGenerator.test.tscode/core/src/manager-api/lib/stories.tscode/addons/vitest/src/node/vitest-manager.tscode/addons/vitest/src/vitest-plugin/index.tscode/core/src/core-server/utils/StoryIndexGenerator.tscode/addons/docs/src/manifest.tscode/core/src/csf-tools/CsfFile.ts
📚 Learning: 2025-09-24T09:39:39.233Z
Learnt from: ndelangen
Repo: storybookjs/storybook PR: 32507
File: code/core/src/manager/globals/globals-module-info.ts:25-33
Timestamp: 2025-09-24T09:39:39.233Z
Learning: In Storybook, storybook/actions/decorator is a preview-only entrypoint and should not be included in manager globals configuration. The duplicatedKeys array in code/core/src/manager/globals/globals-module-info.ts is specifically for manager-side externalization, not preview entrypoints.
Applied to files:
code/renderers/react/src/entry-preview.tsxcode/renderers/react/src/componentManifest/generator.tscode/addons/vitest/src/manager.tsxcode/addons/docs/src/blocks/blocks/usePrimaryStory.test.tsxcode/core/src/preview-api/modules/store/csf/prepareStory.test.tscode/core/src/core-server/index.tscode/core/src/shared/checklist-store/checklistData.tsxcode/core/src/core-server/utils/__tests__/index-extraction.test.tscode/core/src/manager/globals/exports.tscode/core/src/preview-api/modules/preview-web/PreviewWithSelection.tsxcode/core/src/preview-api/modules/store/csf/prepareStory.tscode/core/src/preview-api/modules/preview-web/PreviewWeb.mockdata.tscode/core/src/core-server/utils/StoryIndexGenerator.test.tscode/addons/vitest/src/vitest-plugin/index.tscode/core/src/core-server/presets/common-manager.tscode/core/src/manager/components/sidebar/TagsFilter.tsx
📚 Learning: 2025-11-05T09:37:25.920Z
Learnt from: Sidnioulz
Repo: storybookjs/storybook PR: 32458
File: code/core/src/components/components/tooltip/WithTooltip.tsx:54-96
Timestamp: 2025-11-05T09:37:25.920Z
Learning: Repo: storybookjs/storybook — In code/core/src/components/components/tooltip/WithTooltip.tsx, the legacy WithTooltip implementation is intentionally reintroduced for backward compatibility and is deprecated; maintainers (per Sidnioulz) do not want maintenance or improvements on it. Prefer WithTooltipNew/Popover; avoid suggesting changes to WithTooltip.* going forward.
Applied to files:
code/renderers/react/src/entry-preview.tsxcode/renderers/react/src/componentManifest/generator.tscode/addons/vitest/src/manager.tsxcode/addons/docs/src/blocks/blocks/usePrimaryStory.test.tsxcode/core/src/core-server/index.tscode/addons/docs/src/blocks/blocks/usePrimaryStory.tscode/core/src/shared/checklist-store/checklistData.tsxcode/core/src/csf-tools/CsfFile.ts
📚 Learning: 2025-09-18T20:51:06.618Z
Learnt from: Sidnioulz
Repo: storybookjs/storybook PR: 32458
File: code/core/src/viewport/components/Tool.tsx:38-39
Timestamp: 2025-09-18T20:51:06.618Z
Learning: The useGlobals hook from storybook/manager-api returns a tuple where the third element (storyGlobals) is typed as Globals, not Globals | undefined. This means TypeScript guarantees it's always defined, making the `in` operator safe to use without additional null checks.
Applied to files:
code/renderers/react/src/entry-preview.tsxcode/addons/vitest/src/manager.tsxcode/addons/docs/src/blocks/blocks/usePrimaryStory.test.tsxcode/core/src/core-server/index.tscode/addons/docs/src/blocks/blocks/usePrimaryStory.tscode/core/src/shared/checklist-store/checklistData.tsxcode/core/src/preview-api/modules/preview-web/PreviewWithSelection.tsxcode/core/src/preview-api/modules/store/csf/prepareStory.tscode/core/src/core-server/presets/common-manager.ts
📚 Learning: 2025-09-18T20:51:06.618Z
Learnt from: Sidnioulz
Repo: storybookjs/storybook PR: 32458
File: code/core/src/viewport/components/Tool.tsx:38-39
Timestamp: 2025-09-18T20:51:06.618Z
Learning: In viewport tool code, when using the `useGlobals` hook from storybook/manager-api, the third returned value `storyGlobals` is guaranteed by TypeScript to be defined (not undefined/null), making the `in` operator safe to use without additional null checks.
Applied to files:
code/renderers/react/src/entry-preview.tsxcode/addons/docs/src/blocks/blocks/usePrimaryStory.test.tsxcode/addons/docs/src/blocks/blocks/usePrimaryStory.tscode/core/src/preview-api/modules/preview-web/PreviewWithSelection.tsxcode/core/src/preview-api/modules/store/csf/prepareStory.tscode/core/src/core-server/utils/summarizeIndex.tscode/core/src/core-server/presets/common-manager.ts
📚 Learning: 2025-09-24T13:04:58.631Z
Learnt from: cylewaitforit
Repo: storybookjs/storybook PR: 31965
File: code/lib/eslint-plugin/src/rules/only-csf3.ts:31-33
Timestamp: 2025-09-24T13:04:58.631Z
Learning: The Storybook ESLint plugin supports ESLint v8.57+ where context.sourceCode is already available as a property since it was introduced in v8.40.0, so no fallback to context.getSourceCode() is needed in rules.
Applied to files:
code/renderers/react/src/entry-preview.tsx
📚 Learning: 2025-12-22T22:03:40.123Z
Learnt from: CR
Repo: storybookjs/storybook PR: 0
File: .github/copilot-instructions.md:0-0
Timestamp: 2025-12-22T22:03:40.123Z
Learning: Applies to **/*.{test,spec}.{ts,tsx,js,jsx} : Write meaningful unit tests that actually import and call the functions being tested, not just verify syntax patterns
Applied to files:
code/renderers/react/src/entry-preview.tsxcode/core/src/preview-api/modules/store/csf/prepareStory.test.tscode/core/src/csf-tools/vitest-plugin/transformer.test.tscode/core/src/core-server/utils/__tests__/index-extraction.test.tscode/core/src/core-server/utils/StoryIndexGenerator.test.tscode/core/src/core-server/utils/summarizeIndex.test.ts
📚 Learning: 2025-10-01T15:24:01.060Z
Learnt from: Sidnioulz
Repo: storybookjs/storybook PR: 32594
File: code/core/src/components/components/Popover/WithPopover.tsx:7-9
Timestamp: 2025-10-01T15:24:01.060Z
Learning: In the Storybook repository, "react-aria-components/patched-dist/*" (e.g., "react-aria-components/patched-dist/Dialog", "react-aria-components/patched-dist/Popover", "react-aria-components/patched-dist/Tooltip") are valid import paths created by a patch applied to the react-aria-components package. These imports should not be flagged as broken or invalid until a maintainer explicitly states they are no longer acceptable.
Applied to files:
code/renderers/react/src/componentManifest/generator.tscode/renderers/react/src/componentManifest/fixtures.ts
📚 Learning: 2025-12-22T22:03:40.123Z
Learnt from: CR
Repo: storybookjs/storybook PR: 0
File: .github/copilot-instructions.md:0-0
Timestamp: 2025-12-22T22:03:40.123Z
Learning: Applies to code/{core,lib,addons,builders,frameworks,presets}/**/*.{ts,tsx,js,jsx} : Use `logger` from `storybook/internal/node-logger` for server-side logging in Node.js code
Applied to files:
code/renderers/react/src/componentManifest/generator.tscode/addons/docs/src/blocks/blocks/usePrimaryStory.test.tsxcode/core/src/core-server/utils/__tests__/index-extraction.test.tscode/core/src/core-server/utils/StoryIndexGenerator.test.tscode/addons/vitest/src/node/vitest-manager.tscode/addons/vitest/src/vitest-plugin/index.tscode/core/src/core-server/presets/common-manager.tscode/core/src/core-server/utils/StoryIndexGenerator.tscode/core/src/csf-tools/CsfFile.ts
📚 Learning: 2025-12-22T22:03:40.123Z
Learnt from: CR
Repo: storybookjs/storybook PR: 0
File: .github/copilot-instructions.md:0-0
Timestamp: 2025-12-22T22:03:40.123Z
Learning: Applies to code/{renderers}/**/*.{ts,tsx,js,jsx} : Use `logger` from `storybook/internal/client-logger` for client-side logging in browser code
Applied to files:
code/renderers/react/src/componentManifest/generator.tscode/core/src/preview-api/modules/preview-web/render/CsfDocsRender.test.tscode/core/src/core-server/utils/StoryIndexGenerator.test.tscode/addons/vitest/src/node/vitest-manager.tscode/addons/vitest/src/vitest-plugin/index.tscode/core/src/csf-tools/CsfFile.ts
📚 Learning: 2025-12-22T22:03:40.123Z
Learnt from: CR
Repo: storybookjs/storybook PR: 0
File: .github/copilot-instructions.md:0-0
Timestamp: 2025-12-22T22:03:40.123Z
Learning: Applies to **/*.{test,spec}.{ts,tsx,js,jsx} : Use `vi.mock()` to mock file system, loggers, and other external dependencies in tests
Applied to files:
code/renderers/react/src/componentManifest/fixtures.tscode/core/src/csf-tools/vitest-plugin/transformer.test.tscode/core/src/core-server/utils/manifests/manifests.test.tscode/addons/vitest/src/node/test-manager.test.ts
📚 Learning: 2025-11-24T17:49:59.279Z
Learnt from: CR
Repo: storybookjs/storybook PR: 0
File: .cursor/rules/spy-mocking.mdc:0-0
Timestamp: 2025-11-24T17:49:59.279Z
Learning: Applies to **/*.test.{ts,tsx,js,jsx} : Document complex mock behaviors in Vitest tests
Applied to files:
code/renderers/react/src/componentManifest/fixtures.tscode/addons/vitest/src/manager.tsxcode/core/src/csf-tools/vitest-plugin/transformer.test.tscode/core/src/core-server/utils/__tests__/index-extraction.test.tscode/core/src/core-server/utils/summarizeIndex.test.tscode/addons/vitest/src/node/vitest-manager.tscode/addons/vitest/src/vitest-plugin/index.tscode/addons/vitest/src/node/test-manager.test.ts
📚 Learning: 2025-11-24T17:49:59.279Z
Learnt from: CR
Repo: storybookjs/storybook PR: 0
File: .cursor/rules/spy-mocking.mdc:0-0
Timestamp: 2025-11-24T17:49:59.279Z
Learning: Applies to **/*.test.{ts,tsx,js,jsx} : Mock all required properties and methods that the test subject uses in Vitest tests
Applied to files:
code/renderers/react/src/componentManifest/fixtures.tscode/addons/vitest/src/manager.tsxcode/core/src/csf-tools/vitest-plugin/transformer.test.tscode/core/src/core-server/utils/summarizeIndex.test.tscode/addons/vitest/src/node/vitest-manager.tscode/addons/vitest/src/vitest-plugin/index.tscode/addons/vitest/src/node/test-manager.test.ts
📚 Learning: 2025-11-24T17:49:59.279Z
Learnt from: CR
Repo: storybookjs/storybook PR: 0
File: .cursor/rules/spy-mocking.mdc:0-0
Timestamp: 2025-11-24T17:49:59.279Z
Learning: Applies to **/*.test.{ts,tsx,js,jsx} : Group related mocks together in Vitest tests
Applied to files:
code/renderers/react/src/componentManifest/fixtures.tscode/addons/vitest/src/manager.tsxcode/core/src/csf-tools/vitest-plugin/transformer.test.tscode/core/src/core-server/utils/summarizeIndex.test.tscode/addons/vitest/src/node/vitest-manager.tscode/addons/vitest/src/vitest-plugin/index.tscode/addons/vitest/src/node/test-manager.test.ts
📚 Learning: 2025-11-24T17:49:59.279Z
Learnt from: CR
Repo: storybookjs/storybook PR: 0
File: .cursor/rules/spy-mocking.mdc:0-0
Timestamp: 2025-11-24T17:49:59.279Z
Learning: Applies to **/*.test.{ts,tsx,js,jsx} : Avoid mocking only a subset of required dependencies in Vitest tests
Applied to files:
code/renderers/react/src/componentManifest/fixtures.tscode/addons/vitest/src/manager.tsxcode/core/src/csf-tools/vitest-plugin/transformer.test.tscode/core/src/core-server/utils/__tests__/index-extraction.test.tscode/core/src/core-server/utils/summarizeIndex.test.tscode/addons/vitest/src/node/vitest-manager.tscode/addons/vitest/src/vitest-plugin/index.tscode/addons/vitest/src/node/test-manager.test.ts
📚 Learning: 2025-11-24T17:49:31.838Z
Learnt from: CR
Repo: storybookjs/storybook PR: 0
File: .cursorrules:0-0
Timestamp: 2025-11-24T17:49:31.838Z
Learning: Applies to **/*.{test,spec}.{ts,tsx} : Follow the spy mocking rules defined in `.cursor/rules/spy-mocking.mdc` for consistent mocking patterns with Vitest
Applied to files:
code/renderers/react/src/componentManifest/fixtures.ts
📚 Learning: 2025-11-24T17:49:59.279Z
Learnt from: CR
Repo: storybookjs/storybook PR: 0
File: .cursor/rules/spy-mocking.mdc:0-0
Timestamp: 2025-11-24T17:49:59.279Z
Learning: Applies to **/*.test.{ts,tsx,js,jsx} : Mock implementations should match the expected return type of the original function
Applied to files:
code/renderers/react/src/componentManifest/fixtures.ts
📚 Learning: 2025-11-24T17:49:59.279Z
Learnt from: CR
Repo: storybookjs/storybook PR: 0
File: .cursor/rules/spy-mocking.mdc:0-0
Timestamp: 2025-11-24T17:49:59.279Z
Learning: Applies to **/*.test.{ts,tsx,js,jsx} : Implement mock behaviors in `beforeEach` blocks in Vitest tests
Applied to files:
code/renderers/react/src/componentManifest/fixtures.tscode/core/src/csf-tools/vitest-plugin/transformer.test.tscode/core/src/core-server/utils/summarizeIndex.test.tscode/addons/vitest/src/node/vitest-manager.tscode/addons/vitest/src/vitest-plugin/index.tscode/addons/vitest/src/node/test-manager.test.ts
📚 Learning: 2025-11-24T17:49:59.279Z
Learnt from: CR
Repo: storybookjs/storybook PR: 0
File: .cursor/rules/spy-mocking.mdc:0-0
Timestamp: 2025-11-24T17:49:59.279Z
Learning: Applies to **/*.test.{ts,tsx,js,jsx} : Mock at the highest level of abstraction needed in Vitest tests
Applied to files:
code/renderers/react/src/componentManifest/fixtures.tscode/core/src/csf-tools/vitest-plugin/transformer.test.tscode/core/src/core-server/utils/summarizeIndex.test.tscode/addons/vitest/src/node/test-manager.test.ts
📚 Learning: 2025-11-05T09:36:55.944Z
Learnt from: Sidnioulz
Repo: storybookjs/storybook PR: 32458
File: code/core/src/components/components/Tabs/Tabs.stories.tsx:222-227
Timestamp: 2025-11-05T09:36:55.944Z
Learning: Repo: storybookjs/storybook PR: 32458 — In code/core/src/components/components/Button/Button.tsx (React/TypeScript), ButtonProps includes ariaLabel?: string | false and the component maps it to the DOM aria-label. Convention: ariaLabel is mandatory on all Button usages — provide a descriptive string for icon-only buttons; set ariaLabel=false when the button’s children already serve as the accessible name. Do not suggest using a raw aria-label prop on Button call sites.
Applied to files:
code/renderers/react/src/componentManifest/fixtures.tscode/addons/docs/src/blocks/blocks/usePrimaryStory.tscode/core/src/core-server/utils/summarizeIndex.test.ts
📚 Learning: 2025-11-24T17:49:59.279Z
Learnt from: CR
Repo: storybookjs/storybook PR: 0
File: .cursor/rules/spy-mocking.mdc:0-0
Timestamp: 2025-11-24T17:49:59.279Z
Learning: Applies to **/*.test.{ts,tsx,js,jsx} : Avoid inline mock implementations within test cases in Vitest tests
Applied to files:
code/addons/vitest/src/manager.tsxcode/core/src/csf-tools/vitest-plugin/transformer.test.tscode/core/src/core-server/utils/__tests__/index-extraction.test.tscode/core/src/core-server/utils/StoryIndexGenerator.test.tscode/core/src/core-server/utils/summarizeIndex.test.tscode/addons/vitest/src/node/vitest-manager.tscode/addons/vitest/src/vitest-plugin/index.tscode/addons/vitest/src/node/test-manager.test.ts
📚 Learning: 2025-11-24T17:49:59.279Z
Learnt from: CR
Repo: storybookjs/storybook PR: 0
File: .cursor/rules/spy-mocking.mdc:0-0
Timestamp: 2025-11-24T17:49:59.279Z
Learning: Applies to **/*.test.{ts,tsx,js,jsx} : Keep mock implementations simple and focused in Vitest tests
Applied to files:
code/addons/vitest/src/manager.tsxcode/core/src/csf-tools/vitest-plugin/transformer.test.tscode/core/src/core-server/utils/__tests__/index-extraction.test.tscode/core/src/core-server/utils/summarizeIndex.test.tscode/addons/vitest/src/node/vitest-manager.tscode/addons/vitest/src/vitest-plugin/index.tscode/addons/vitest/src/node/test-manager.test.ts
📚 Learning: 2025-11-24T17:49:59.279Z
Learnt from: CR
Repo: storybookjs/storybook PR: 0
File: .cursor/rules/spy-mocking.mdc:0-0
Timestamp: 2025-11-24T17:49:59.279Z
Learning: Applies to **/*.test.{ts,tsx,js,jsx} : Avoid mock implementations outside of `beforeEach` blocks in Vitest tests
Applied to files:
code/addons/vitest/src/manager.tsxcode/core/src/csf-tools/vitest-plugin/transformer.test.tscode/core/src/core-server/utils/__tests__/index-extraction.test.tscode/core/src/core-server/utils/summarizeIndex.test.tscode/addons/vitest/src/node/vitest-manager.tscode/addons/vitest/src/vitest-plugin/index.tscode/addons/vitest/src/node/test-manager.test.ts
📚 Learning: 2025-11-24T17:49:31.838Z
Learnt from: CR
Repo: storybookjs/storybook PR: 0
File: .cursorrules:0-0
Timestamp: 2025-11-24T17:49:31.838Z
Learning: Applies to code/vitest.workspace.ts : Vitest configuration is centralized in `code/vitest.workspace.ts` for workspace setup
Applied to files:
code/addons/vitest/src/manager.tsxcode/addons/vitest/src/node/vitest-manager.tscode/addons/vitest/src/vitest-plugin/index.ts
📚 Learning: 2025-11-24T17:49:59.279Z
Learnt from: CR
Repo: storybookjs/storybook PR: 0
File: .cursor/rules/spy-mocking.mdc:0-0
Timestamp: 2025-11-24T17:49:59.279Z
Learning: Applies to **/*.test.{ts,tsx,js,jsx} : Avoid direct function mocking without `vi.mocked()` in Vitest tests
Applied to files:
code/core/src/csf-tools/vitest-plugin/transformer.test.tscode/core/src/core-server/utils/summarizeIndex.test.tscode/addons/vitest/src/node/vitest-manager.tscode/addons/vitest/src/node/test-manager.test.ts
📚 Learning: 2025-11-24T17:49:59.279Z
Learnt from: CR
Repo: storybookjs/storybook PR: 0
File: .cursor/rules/spy-mocking.mdc:0-0
Timestamp: 2025-11-24T17:49:59.279Z
Learning: Applies to **/*.test.{ts,tsx,js,jsx} : Use `vi.mocked()` to type and access the mocked functions in Vitest tests
Applied to files:
code/core/src/csf-tools/vitest-plugin/transformer.test.tscode/addons/vitest/src/node/test-manager.test.ts
📚 Learning: 2025-11-24T17:49:59.279Z
Learnt from: CR
Repo: storybookjs/storybook PR: 0
File: .cursor/rules/spy-mocking.mdc:0-0
Timestamp: 2025-11-24T17:49:59.279Z
Learning: Applies to **/*.test.{ts,tsx,js,jsx} : Use type-safe mocking with `vi.mocked()` in Vitest tests
Applied to files:
code/core/src/csf-tools/vitest-plugin/transformer.test.ts
📚 Learning: 2025-12-22T22:03:40.123Z
Learnt from: CR
Repo: storybookjs/storybook PR: 0
File: .github/copilot-instructions.md:0-0
Timestamp: 2025-12-22T22:03:40.123Z
Learning: Applies to **/*.{test,spec}.{ts,tsx,js,jsx} : Cover all branches, conditions, edge cases, error paths, and different input variations in unit tests
Applied to files:
code/core/src/csf-tools/vitest-plugin/transformer.test.tscode/core/src/core-server/utils/summarizeIndex.test.ts
📚 Learning: 2025-12-22T22:03:40.123Z
Learnt from: CR
Repo: storybookjs/storybook PR: 0
File: .github/copilot-instructions.md:0-0
Timestamp: 2025-12-22T22:03:40.123Z
Learning: Applies to **/*.{test,spec}.{ts,tsx,js,jsx} : Achieve high test coverage of business logic, aiming for 75%+ coverage of statements/lines
Applied to files:
code/core/src/csf-tools/vitest-plugin/transformer.test.ts
📚 Learning: 2025-12-22T22:03:40.123Z
Learnt from: CR
Repo: storybookjs/storybook PR: 0
File: .github/copilot-instructions.md:0-0
Timestamp: 2025-12-22T22:03:40.123Z
Learning: Applies to docs/**/migration*.md : Update migration guides for breaking changes
Applied to files:
code/lib/cli-storybook/src/automigrate/fixes/remove-docs-autodocs.ts
📚 Learning: 2025-11-24T17:49:59.279Z
Learnt from: CR
Repo: storybookjs/storybook PR: 0
File: .cursor/rules/spy-mocking.mdc:0-0
Timestamp: 2025-11-24T17:49:59.279Z
Learning: Applies to **/*.test.{ts,tsx,js,jsx} : Avoid mocking without the `spy: true` option in Vitest tests
Applied to files:
code/core/src/core-server/utils/summarizeIndex.test.tscode/addons/vitest/src/node/vitest-manager.tscode/addons/vitest/src/node/test-manager.test.ts
📚 Learning: 2025-12-22T22:03:40.123Z
Learnt from: CR
Repo: storybookjs/storybook PR: 0
File: .github/copilot-instructions.md:0-0
Timestamp: 2025-12-22T22:03:40.123Z
Learning: Applies to {code/addons,code/frameworks}/**/README.md : Update README files for significant changes and include code examples in addon/framework documentation
Applied to files:
code/addons/docs/src/manifest.ts
🧬 Code graph analysis (31)
code/renderers/react/src/entry-preview.tsx (1)
code/core/src/shared/constants/tags.ts (2)
Tag(2-19)Tag(25-25)
code/core/src/core-server/utils/manifests/manifests.ts (1)
code/core/src/shared/constants/tags.ts (2)
Tag(2-19)Tag(25-25)
code/renderers/react/src/componentManifest/generator.ts (1)
code/core/src/shared/constants/tags.ts (2)
Tag(2-19)Tag(25-25)
code/renderers/react/src/componentManifest/fixtures.ts (1)
code/core/src/shared/constants/tags.ts (2)
Tag(2-19)Tag(25-25)
code/addons/docs/src/blocks/blocks/usePrimaryStory.test.tsx (1)
code/core/src/shared/constants/tags.ts (2)
Tag(2-19)Tag(25-25)
code/core/src/preview-api/modules/store/csf/prepareStory.test.ts (1)
code/core/src/shared/constants/tags.ts (2)
Tag(2-19)Tag(25-25)
code/addons/docs/src/blocks/blocks/Stories.tsx (1)
code/core/src/shared/constants/tags.ts (2)
Tag(2-19)Tag(25-25)
code/core/src/csf-tools/vitest-plugin/transformer.test.ts (1)
code/core/src/shared/constants/tags.ts (2)
Tag(2-19)Tag(25-25)
code/addons/docs/src/blocks/blocks/usePrimaryStory.ts (1)
code/core/src/shared/constants/tags.ts (2)
Tag(2-19)Tag(25-25)
code/core/src/shared/checklist-store/checklistData.tsx (5)
code/core/src/core-server/index.ts (1)
Tag(15-15)code/core/src/manager-api/index.mock.ts (1)
Tag(4-4)code/core/src/manager-api/index.ts (1)
Tag(26-26)code/core/src/preview-api/index.ts (1)
Tag(75-75)code/core/src/shared/constants/tags.ts (2)
Tag(2-19)Tag(25-25)
code/core/src/core-server/utils/__tests__/index-extraction.test.ts (1)
code/core/src/shared/constants/tags.ts (2)
Tag(2-19)Tag(25-25)
code/core/src/preview-api/modules/preview-web/render/CsfDocsRender.test.ts (1)
code/core/src/shared/constants/tags.ts (2)
Tag(2-19)Tag(25-25)
code/core/src/preview-api/modules/preview-web/PreviewWithSelection.tsx (1)
code/core/src/shared/constants/tags.ts (2)
Tag(2-19)Tag(25-25)
code/core/src/preview-api/modules/store/csf/prepareStory.ts (1)
code/core/src/shared/constants/tags.ts (2)
Tag(2-19)Tag(25-25)
code/core/src/core-server/utils/manifests/manifests.test.ts (1)
code/core/src/shared/constants/tags.ts (2)
Tag(2-19)Tag(25-25)
code/lib/cli-storybook/src/automigrate/fixes/remove-docs-autodocs.ts (1)
code/core/src/shared/constants/tags.ts (2)
Tag(2-19)Tag(25-25)
code/core/src/preview-api/modules/preview-web/PreviewWeb.mockdata.ts (1)
code/core/src/shared/constants/tags.ts (2)
Tag(2-19)Tag(25-25)
code/core/src/core-server/utils/summarizeIndex.ts (1)
code/core/src/shared/constants/tags.ts (2)
Tag(2-19)Tag(25-25)
code/core/src/core-server/utils/StoryIndexGenerator.test.ts (1)
code/core/src/shared/constants/tags.ts (2)
Tag(2-19)Tag(25-25)
code/core/src/core-server/utils/summarizeIndex.test.ts (1)
code/core/src/shared/constants/tags.ts (2)
Tag(2-19)Tag(25-25)
code/core/src/manager-api/lib/stories.ts (1)
code/core/src/shared/constants/tags.ts (2)
Tag(2-19)Tag(25-25)
code/addons/vitest/src/node/vitest-manager.ts (1)
code/core/src/shared/constants/tags.ts (2)
Tag(2-19)Tag(25-25)
code/addons/vitest/src/vitest-plugin/index.ts (5)
code/core/src/core-server/index.ts (1)
Tag(15-15)code/core/src/manager-api/index.mock.ts (1)
Tag(4-4)code/core/src/manager-api/index.ts (1)
Tag(26-26)code/core/src/preview-api/index.ts (1)
Tag(75-75)code/core/src/shared/constants/tags.ts (2)
Tag(2-19)Tag(25-25)
code/core/src/core-server/presets/common-manager.ts (3)
code/core/src/core-server/index.ts (1)
Tag(15-15)code/core/src/manager-api/index.ts (1)
Tag(26-26)code/core/src/shared/constants/tags.ts (2)
Tag(2-19)Tag(25-25)
code/core/src/manager/components/sidebar/TagsFilter.tsx (1)
code/core/src/shared/constants/tags.ts (2)
Tag(2-19)Tag(25-25)
code/core/src/core-server/utils/StoryIndexGenerator.ts (1)
code/core/src/shared/constants/tags.ts (2)
Tag(2-19)Tag(25-25)
code/addons/docs/src/manifest.ts (1)
code/core/src/shared/constants/tags.ts (2)
Tag(2-19)Tag(25-25)
code/core/src/preview-api/modules/store/csf/portable-stories.test.ts (1)
code/core/src/shared/constants/tags.ts (2)
Tag(2-19)Tag(25-25)
code/core/src/shared/constants/tags.ts (4)
code/core/src/core-server/index.ts (1)
Tag(15-15)code/core/src/manager-api/index.mock.ts (1)
Tag(4-4)code/core/src/manager-api/index.ts (1)
Tag(26-26)code/core/src/preview-api/index.ts (1)
Tag(75-75)
code/addons/vitest/src/node/test-manager.test.ts (1)
code/core/src/shared/constants/tags.ts (2)
Tag(2-19)Tag(25-25)
code/core/src/csf-tools/CsfFile.ts (3)
code/core/src/shared/constants/tags.ts (2)
Tag(2-19)Tag(25-25)code/core/src/csf/story.ts (1)
Tag(15-15)code/core/src/csf/csf-factories.ts (1)
test(198-228)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (3)
- GitHub Check: normal
- GitHub Check: nx
- GitHub Check: Core Unit Tests, windows-latest
8 tasks
JReinhold
added a commit
to storybookjs/mcp
that referenced
this pull request
Jan 8, 2026
* make getManifest handle both component and docs manifests * add support for docs manifest in both tools * update bin and eval to support manifest split * fix manifest feature detection * add MDX files to test support * Use canary version of storybookjs/storybook#33408 * fix tests * rename "list all components" tool to "list all documentation" * fix check-deps e2e tests * remove dependency on canary again * add changesets * fix Button.mdx to match implementation * fix lints * add support for summary in MDX * update storybook deps * small docs fixes * simpllify storybook docs context in eval to always get components.json/docs.json instead of supporting custom filenames * update storybook
8 tasks
8 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What I did
Extends the manifest generation system to include MDX documentation files alongside component manifests. This enables AI agents and other tools to access structured documentation content through the manifest API.
Key Changes
addon-docs (
code/addons/docs/src/manifest.ts)experimental_manifestspreset function that processes MDX docs entriesattached-mdxtag) are added to their corresponding component manifests under adocspropertyunattached-mdxtag) are added to a separate/manifests/docs.jsonendpointReact renderer (
code/renderers/react/src/componentManifest/generator.ts)manifesttag (previously required story entries)storiesImports[0]to find the story file for attached docs entriesCore server (
code/core/src/core-server/utils/manifests/manifests.ts)Manifest Structure
Attached docs are added to component manifests:
{ "components": { "v": 0, "components": { "example-button": { "id": "example-button", "name": "Button", "docs": { "example-button--docs": { "id": "example-button--docs", "name": "docs", "path": "./Button.mdx", "title": "Example/Button", "content": "# Button\n\nDocumentation content..." } } } } } }Unattached docs are served at
/manifests/docs.json:{ "v": 0, "docs": { "standalone--docs": { "id": "standalone--docs", "name": "docs", "path": "./Standalone.mdx", "title": "Standalone", "content": "# Standalone\n\nStandalone documentation..." } } }Checklist for Contributors
Testing
The changes in this PR are covered in the following automated tests:
Manual testing
yarn task --task sandbox --start-from auto --template react-vite/default-ts<Meta of={ButtonStories} />to attach it to the Button stories./manifests/components.jsonto see attached docs in component entries/manifests/docs.jsonto see unattached docs entriesDocumentation
Summary by CodeRabbit
New Features
Tests
✏️ Tip: You can customize this high-level summary in your review settings.