Fix: Allow undefined for summary in PropSummaryValue #33376
Closed
rahulb18 wants to merge 1 commit into
Closed
Conversation
Fixes storybookjs#27129 This change allows users with exactOptionalPropertyTypes: true to explicitly set summary and detail to undefined in argTypes. Changes: - Updated PropSummaryValue interface in PropDef.ts - Updated InputType table types in story.ts - Updated PropSummaryValue detail in ArgsTable types.ts
Member
|
Hey @rahulb18 thank you so much for your PR, it's truly appreciated! We talked about this during the weekly triage meeting: I'll review that PR and merge it if possible. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #27129
This PR allows users with
exactOptionalPropertyTypes: trueto explicitly setsummaryanddetailtoundefinedin argTypes.Changes
PropSummaryValueinterface inPropDef.tsto include| undefinedInputTypetable types instory.tsPropSummaryValuedetail inArgsTable/types.tsTest Plan
Type of Change