Skip to content

CI: Testing changes to DangerJS script - Test 2#33373

Closed
Sidnioulz wants to merge 2 commits into
sidnioulz/dx-mandatory-manual-testfrom
sidnioulz/dx-mandatory-manual-test-2
Closed

CI: Testing changes to DangerJS script - Test 2#33373
Sidnioulz wants to merge 2 commits into
sidnioulz/dx-mandatory-manual-testfrom
sidnioulz/dx-mandatory-manual-test-2

Conversation

@Sidnioulz
Copy link
Copy Markdown
Contributor

@Sidnioulz Sidnioulz commented Dec 16, 2025

Test where I left the entire section untouched. Should fail.

What I did

Checklist for Contributors

Testing

The changes in this PR are covered in the following automated tests:

  • stories
  • unit tests
  • integration tests
  • end-to-end tests

Manual testing

This section is mandatory for all contributions. If you believe no manual test is necessary, please state so explicitly. Thanks!

Documentation

  • Add or update documentation reflecting your changes
  • If you are deprecating/removing a feature, make sure to update
    MIGRATION.MD

Checklist for Maintainers

  • When this PR is ready for testing, make sure to add ci:normal, ci:merged or ci:daily GH label to it to run a specific set of sandboxes. The particular set of sandboxes can be found in code/lib/cli-storybook/src/sandbox-templates.ts

  • Make sure this PR contains one of the labels below:

    Available labels
    • bug: Internal changes that fixes incorrect behavior.
    • maintenance: User-facing maintenance tasks.
    • dependencies: Upgrading (sometimes downgrading) dependencies.
    • build: Internal-facing build tooling & test updates. Will not show up in release changelog.
    • cleanup: Minor cleanup style change. Will not show up in release changelog.
    • documentation: Documentation only changes. Will not show up in release changelog.
    • feature request: Introducing a new feature.
    • BREAKING CHANGE: Changes that break compatibility in some way with current major version.
    • other: Changes that don't fit in the above categories.

🦋 Canary release

This PR does not have a canary release associated. You can request a canary release of this pull request by mentioning the @storybookjs/core team here.

core team members can create a canary release here or locally with gh workflow run --repo storybookjs/storybook publish.yml --field pr=<PR_NUMBER>

Summary by CodeRabbit

  • Chores
    • Added a new minimal text file with no executable code or functionality.

This release contains no user-facing changes or functional improvements.

✏️ Tip: You can customize this high-level summary in your review settings.

@Sidnioulz Sidnioulz self-assigned this Dec 16, 2025
@Sidnioulz Sidnioulz added build Internal-facing build tooling & test updates ci:docs Run the CI jobs for documentation checks only. labels Dec 16, 2025
@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented Dec 16, 2025

📝 Walkthrough

Walkthrough

A new file named frog was added; its contents are the literal text "frog". No code, exports, control flow, or error handling changes were introduced.

Changes

Cohort / File(s) Summary
New text file
frog
Added a plain text file containing the single word "frog".

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~1 minute


📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 82825c9 and cff3d83.

📒 Files selected for processing (1)
  • frog (1 hunks)
🚧 Files skipped from review as they are similar to previous changes (1)
  • frog
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
  • GitHub Check: Core Unit Tests, windows-latest

Comment @coderabbitai help to get the list of available commands and usage tips.

@Sidnioulz Sidnioulz force-pushed the sidnioulz/dx-mandatory-manual-test branch from 377436b to 502ab96 Compare December 16, 2025 12:23
@Sidnioulz Sidnioulz force-pushed the sidnioulz/dx-mandatory-manual-test-2 branch from 82825c9 to cff3d83 Compare December 16, 2025 12:24
@github-actions
Copy link
Copy Markdown
Contributor

Fails
🚫 The "#### Manual testing" section is mandatory. Please describe how to test the changes you've made, step by step, so that reviewers can confirm your PR works as intended.

Generated by 🚫 dangerJS against cff3d83

@Sidnioulz Sidnioulz force-pushed the sidnioulz/dx-mandatory-manual-test branch 2 times, most recently from b35a3d1 to 9234f79 Compare December 16, 2025 12:30
@Sidnioulz Sidnioulz closed this Dec 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

build Internal-facing build tooling & test updates ci:docs Run the CI jobs for documentation checks only.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant