Skip to content

Core: Ensure /project.json route is up before builders serve local FS #33303

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
JReinhold merged 2 commits into from
Dec 9, 2025
Merged

Core: Ensure /project.json route is up before builders serve local FS #33303

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
16f2887
Core: Ensure the /project.json route handler is up before builders st…
Sidnioulz Dec 8, 2025
fada00e
Merge branch 'next' into sidnioulz/fix-project-json-nx-monorepo-conflict
JReinhold Dec 9, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions code/core/src/core-server/dev-server.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,7 @@ import { getCachingMiddleware } from './utils/get-caching-middleware';
import { getServerChannel } from './utils/get-server-channel';
import { getAccessControlMiddleware } from './utils/getAccessControlMiddleware';
import { getStoryIndexGenerator } from './utils/getStoryIndexGenerator';
import { useStorybookMetadata } from './utils/metadata';
import { getMiddleware } from './utils/middleware';
import { openInBrowser } from './utils/open-browser/open-in-browser';
import { getServerAddresses } from './utils/server-address';
Expand Down Expand Up @@ -80,6 +81,12 @@ export async function storybookDevServer(options: Options) {
logConfig('Preview webpack config', await previewBuilder.getConfig(options));
}

// Boot up the `/project.json` route handler early to avoid Vite Dev Server
// serving a NX monorepo `project.json` file instead.
if (!core?.disableProjectJson) {
useStorybookMetadata(app, options.configDir);
}

const managerResult = options.previewOnly
? undefined
: await managerBuilder.start({
Expand Down
5 changes: 0 additions & 5 deletions code/core/src/core-server/utils/doTelemetry.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,6 @@ import invariant from 'tiny-invariant';

import { sendTelemetryError } from '../withTelemetry';
import type { StoryIndexGenerator } from './StoryIndexGenerator';
import { useStorybookMetadata } from './metadata';
import { summarizeIndex } from './summarizeIndex';
import { versionStatus } from './versionStatus';

Expand Down Expand Up @@ -51,8 +50,4 @@ export async function doTelemetry(
telemetry('dev', payload, { configDir: options.configDir });
});
}

if (!core?.disableProjectJson) {
useStorybookMetadata(app, options.configDir);
}
}