Skip to content

Build: Wait for composed Storybooks to load before continuing E2E test #33278

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ghengeveld merged 1 commit into from
Dec 4, 2025
Merged

Build: Wait for composed Storybooks to load before continuing E2E test #33278

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
82 changes: 39 additions & 43 deletions test-storybooks/portable-stories-kitchen-sink/react-vitest-3/e2e-tests/composition.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,47 +1,51 @@
import { expect, test } from "@playwright/test";
import { expect, test } from '@playwright/test';

import { SbPage } from "../../../../code/e2e-tests/util";
import { SbPage } from '../../../../code/e2e-tests/util';

const STORYBOOK_URL = "http://localhost:6006";
const STORYBOOK_URL = 'http://localhost:6006';

test.describe("composition", () => {
test.describe('composition', () => {
// the composed storybook can be slow to load, so we need to increase the timeout
test.describe.configure({ mode: "serial", timeout: 60000, retries: 2 });
test("should filter and render composed stories", async ({ page }) => {
test.describe.configure({ mode: 'serial', timeout: 60000, retries: 2 });
test('should filter and render composed stories', async ({ page }) => {
await page.goto(STORYBOOK_URL);
await new SbPage(page, expect).waitUntilLoaded();

// Expect that composed Storybooks are visible
await expect(page.getByTitle("Storybook 8.0.0")).toBeVisible();
await expect(page.getByTitle("Storybook 7.6.18")).toBeVisible();
// Expect that composed Storybooks are visible and loaded
await expect(page.getByTitle('Storybook 8.0.0')).toBeVisible();
await expect(page.locator('[id="storybook\\@8\\.0\\.0_components-badge"]')).toBeVisible({
timeout: 15000,
});
await expect(page.getByTitle('Storybook 7.6.18')).toBeVisible();
await expect(page.locator('[id="storybook\\@7\\.6\\.18_components-badge"]')).toBeVisible({
timeout: 15000,
});

// Expect composed stories to be available in the sidebar
await page.locator('[id="storybook\\@8\\.0\\.0_components-badge"]').click();
await expect(
page.locator('[id="storybook\\@8\\.0\\.0_components-badge--default"]')
).toBeVisible();

await page
.locator('[id="storybook\\@7\\.6\\.18_components-badge"]')
.click();
await page.locator('[id="storybook\\@7\\.6\\.18_components-badge"]').click();
await expect(
page
.locator('iframe[title="storybook-ref-storybook\\@7\\.6\\.18"]')
.contentFrame()
.locator("#storybook-root")
.getByText("Default")
.locator('#storybook-root')
.getByText('Default')
).toBeVisible({ timeout: 15000 });

// Expect composed stories `to be available in the search
await page.getByPlaceholder("Find components").fill("Button primary");
await page.getByPlaceholder('Find components').fill('Button primary');
await expect(
page.getByRole("option", {
name: "Primary Storybook 7.6.18 / @components / Button",
page.getByRole('option', {
name: 'Primary Storybook 7.6.18 / @components / Button',
})
).toBeVisible();

const buttonStory = page.getByRole("option", {
name: "Primary Storybook 8.0.0 / @blocks / examples / Button",
const buttonStory = page.getByRole('option', {
name: 'Primary Storybook 8.0.0 / @blocks / examples / Button',
});
await expect(buttonStory).toBeVisible();
await buttonStory.click();
Expand All @@ -51,13 +55,11 @@ test.describe("composition", () => {
page
.locator('iframe[title="storybook-ref-storybook\\@8\\.0\\.0"]')
.contentFrame()
.getByRole("button")
.getByRole('button')
).toBeVisible({ timeout: 15000 });
});

test("should filter and render composed stories on mobile", async ({
page,
}) => {
test('should filter and render composed stories on mobile', async ({ page }) => {
page.setViewportSize({ width: 320, height: 800 });
await page.goto(STORYBOOK_URL);
await new SbPage(page, expect).waitUntilLoaded();
Expand All @@ -66,47 +68,41 @@ test.describe("composition", () => {

// scroll down to the bottom of the element getByText('Skip to canvasStorybookSearch')

await page.getByTitle("Storybook 7.6.18").scrollIntoViewIfNeeded();
await page.getByTitle('Storybook 7.6.18').scrollIntoViewIfNeeded();

// Expect that composed Storybooks are visible
await expect(page.getByTitle("Storybook 8.0.0")).toBeVisible();
await expect(page.getByTitle("Storybook 7.6.18")).toBeVisible();
await expect(page.getByTitle('Storybook 8.0.0')).toBeVisible();
await expect(page.getByTitle('Storybook 7.6.18')).toBeVisible();

// Expect composed stories to be available in the sidebar
await expect(
page.locator('[id="storybook\\@8\\.0\\.0_components-badge"]')
).toBeVisible();
await expect(page.locator('[id="storybook\\@8\\.0\\.0_components-badge"]')).toBeVisible();
await page.locator('[id="storybook\\@8\\.0\\.0_components-badge"]').click();
await expect(
page.locator('[id="storybook\\@8\\.0\\.0_components-badge--default"]')
).toBeVisible();

await page
.locator('[id="storybook\\@7\\.6\\.18_components-badge"]')
.click();
await page
.locator('[id="storybook\\@7\\.6\\.18_components-badge--default"]')
.click();
await page.locator('[id="storybook\\@7\\.6\\.18_components-badge"]').click();
await page.locator('[id="storybook\\@7\\.6\\.18_components-badge--default"]').click();
await expect(
page
.locator('iframe[title="storybook-ref-storybook\\@7\\.6\\.18"]')
.contentFrame()
.locator("#storybook-root")
.getByText("Default")
.locator('#storybook-root')
.getByText('Default')
).toBeVisible({ timeout: 15000 });

await page.click('button[aria-label="Open navigation menu"]');

// Expect composed stories `to be available in the search
await page.getByPlaceholder("Find components").fill("Button primary");
await page.getByPlaceholder('Find components').fill('Button primary');
await expect(
page.getByRole("option", {
name: "Primary Storybook 7.6.18 / @components / Button",
page.getByRole('option', {
name: 'Primary Storybook 7.6.18 / @components / Button',
})
).toBeVisible();

const buttonStory = page.getByRole("option", {
name: "Primary Storybook 8.0.0 / @blocks / examples / Button",
const buttonStory = page.getByRole('option', {
name: 'Primary Storybook 8.0.0 / @blocks / examples / Button',
});
await expect(buttonStory).toBeVisible();
await buttonStory.click();
Expand All @@ -116,7 +112,7 @@ test.describe("composition", () => {
page
.locator('iframe[title="storybook-ref-storybook\\@8\\.0\\.0"]')
.contentFrame()
.getByRole("button")
.getByRole('button')
).toBeVisible({ timeout: 15000 });
});
});
84 changes: 40 additions & 44 deletions test-storybooks/portable-stories-kitchen-sink/react/e2e-tests/composition.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,47 +1,51 @@
import { expect, test } from "@playwright/test";
import { expect, test } from '@playwright/test';

import { SbPage } from "../../../../code/e2e-tests/util";
import { SbPage } from '../../../../code/e2e-tests/util';

const STORYBOOK_URL = "http://localhost:6006";
const STORYBOOK_URL = 'http://localhost:6006';

test.describe("composition", () => {
test.describe('composition', () => {
// the composed storybook can be slow to load, so we need to increase the timeout
test.describe.configure({ mode: "serial", timeout: 60000, retries: 2 });
test("should filter and render composed stories", async ({ page }) => {
test.describe.configure({ mode: 'serial', timeout: 60000, retries: 2 });
test('should filter and render composed stories', async ({ page }) => {
await page.goto(STORYBOOK_URL);
await new SbPage(page, expect).waitUntilLoaded();

// Expect that composed Storybooks are visible
await expect(page.getByTitle("Storybook 8.0.0")).toBeVisible();
await expect(page.getByTitle("Storybook 7.6.18")).toBeVisible();
// Expect that composed Storybooks are visible and loaded
await expect(page.getByTitle('Storybook 8.0.0')).toBeVisible();
await expect(page.locator('[id="storybook\\@8\\.0\\.0_components-badge"]')).toBeVisible({
timeout: 15000,
});
await expect(page.getByTitle('Storybook 7.6.18')).toBeVisible();
await expect(page.locator('[id="storybook\\@7\\.6\\.18_components-badge"]')).toBeVisible({
timeout: 15000,
});

// Expect composed stories to be available in the sidebar
await page.locator('[id="storybook\\@8\\.0\\.0_components-badge"]').click();
await expect(
page.locator('[id="storybook\\@8\\.0\\.0_components-badge--default"]')
).toBeVisible();

await page
.locator('[id="storybook\\@7\\.6\\.18_components-badge"]')
.click();
await page.locator('[id="storybook\\@7\\.6\\.18_components-badge"]').click();
await expect(
page
.locator('iframe[title="storybook-ref-storybook\\@7\\.6\\.18"]')
.contentFrame()
.locator("#storybook-root")
.getByText("Default")
.locator('#storybook-root')
.getByText('Default')
).toBeVisible({ timeout: 15000 });

// Expect composed stories `to be available in the search
await page.getByPlaceholder("Find components").fill("Button primary");
// Expect composed stories to be available in the search
await page.getByPlaceholder('Find components').fill('Button primary');
await expect(
page.getByRole("option", {
name: "Primary Storybook 7.6.18 / @components / Button",
page.getByRole('option', {
name: 'Primary Storybook 7.6.18 / @components / Button',
})
).toBeVisible();

const buttonStory = page.getByRole("option", {
name: "Primary Storybook 8.0.0 / @blocks / examples / Button",
const buttonStory = page.getByRole('option', {
name: 'Primary Storybook 8.0.0 / @blocks / examples / Button',
});
await expect(buttonStory).toBeVisible();
await buttonStory.click();
Expand All @@ -51,13 +55,11 @@ test.describe("composition", () => {
page
.locator('iframe[title="storybook-ref-storybook\\@8\\.0\\.0"]')
.contentFrame()
.getByRole("button")
.getByRole('button')
).toBeVisible({ timeout: 15000 });
});

test("should filter and render composed stories on mobile", async ({
page,
}) => {
test('should filter and render composed stories on mobile', async ({ page }) => {
page.setViewportSize({ width: 320, height: 800 });
await page.goto(STORYBOOK_URL);
await new SbPage(page, expect).waitUntilLoaded();
Expand All @@ -66,47 +68,41 @@ test.describe("composition", () => {

// scroll down to the bottom of the element getByText('Skip to canvasStorybookSearch')

await page.getByTitle("Storybook 7.6.18").scrollIntoViewIfNeeded();
await page.getByTitle('Storybook 7.6.18').scrollIntoViewIfNeeded();

// Expect that composed Storybooks are visible
await expect(page.getByTitle("Storybook 8.0.0")).toBeVisible();
await expect(page.getByTitle("Storybook 7.6.18")).toBeVisible();
await expect(page.getByTitle('Storybook 8.0.0')).toBeVisible();
await expect(page.getByTitle('Storybook 7.6.18')).toBeVisible();

// Expect composed stories to be available in the sidebar
await expect(
page.locator('[id="storybook\\@8\\.0\\.0_components-badge"]')
).toBeVisible();
await expect(page.locator('[id="storybook\\@8\\.0\\.0_components-badge"]')).toBeVisible();
await page.locator('[id="storybook\\@8\\.0\\.0_components-badge"]').click();
await expect(
page.locator('[id="storybook\\@8\\.0\\.0_components-badge--default"]')
).toBeVisible();

await page
.locator('[id="storybook\\@7\\.6\\.18_components-badge"]')
.click();
await page
.locator('[id="storybook\\@7\\.6\\.18_components-badge--default"]')
.click();
await page.locator('[id="storybook\\@7\\.6\\.18_components-badge"]').click();
await page.locator('[id="storybook\\@7\\.6\\.18_components-badge--default"]').click();
await expect(
page
.locator('iframe[title="storybook-ref-storybook\\@7\\.6\\.18"]')
.contentFrame()
.locator("#storybook-root")
.getByText("Default")
.locator('#storybook-root')
.getByText('Default')
).toBeVisible({ timeout: 15000 });

await page.click('button[aria-label="Open navigation menu"]');

// Expect composed stories `to be available in the search
await page.getByPlaceholder("Find components").fill("Button primary");
await page.getByPlaceholder('Find components').fill('Button primary');
await expect(
page.getByRole("option", {
name: "Primary Storybook 7.6.18 / @components / Button",
page.getByRole('option', {
name: 'Primary Storybook 7.6.18 / @components / Button',
})
).toBeVisible();

const buttonStory = page.getByRole("option", {
name: "Primary Storybook 8.0.0 / @blocks / examples / Button",
const buttonStory = page.getByRole('option', {
name: 'Primary Storybook 8.0.0 / @blocks / examples / Button',
});
await expect(buttonStory).toBeVisible();
await buttonStory.click();
Expand All @@ -116,7 +112,7 @@ test.describe("composition", () => {
page
.locator('iframe[title="storybook-ref-storybook\\@8\\.0\\.0"]')
.contentFrame()
.getByRole("button")
.getByRole('button')
).toBeVisible({ timeout: 15000 });
});
});
Loading