Skip to content

CLI: Update upgrade message#33182

Merged
yannbf merged 1 commit into
nextfrom
yann/minor-message-update
Nov 26, 2025
Merged

CLI: Update upgrade message#33182
yannbf merged 1 commit into
nextfrom
yann/minor-message-update

Conversation

@yannbf
Copy link
Copy Markdown
Member

@yannbf yannbf commented Nov 26, 2025

Closes #

What I did

Checklist for Contributors

Testing

The changes in this PR are covered in the following automated tests:

  • stories
  • unit tests
  • integration tests
  • end-to-end tests

Manual testing

This section is mandatory for all contributions. If you believe no manual test is necessary, please state so explicitly. Thanks!

Documentation

  • Add or update documentation reflecting your changes
  • If you are deprecating/removing a feature, make sure to update
    MIGRATION.MD

Checklist for Maintainers

  • When this PR is ready for testing, make sure to add ci:normal, ci:merged or ci:daily GH label to it to run a specific set of sandboxes. The particular set of sandboxes can be found in code/lib/cli-storybook/src/sandbox-templates.ts

  • Make sure this PR contains one of the labels below:

    Available labels
    • bug: Internal changes that fixes incorrect behavior.
    • maintenance: User-facing maintenance tasks.
    • dependencies: Upgrading (sometimes downgrading) dependencies.
    • build: Internal-facing build tooling & test updates. Will not show up in release changelog.
    • cleanup: Minor cleanup style change. Will not show up in release changelog.
    • documentation: Documentation only changes. Will not show up in release changelog.
    • feature request: Introducing a new feature.
    • BREAKING CHANGE: Changes that break compatibility in some way with current major version.
    • other: Changes that don't fit in the above categories.

🦋 Canary release

This PR does not have a canary release associated. You can request a canary release of this pull request by mentioning the @storybookjs/core team here.

core team members can create a canary release here or locally with gh workflow run --repo storybookjs/storybook publish.yml --field pr=<PR_NUMBER>

Summary by CodeRabbit

  • Style
    • Updated formatting of upgrade result output to display automigration links immediately following the header without extra spacing.

✏️ Tip: You can customize this high-level summary in your review settings.

@yannbf yannbf self-assigned this Nov 26, 2025
@yannbf yannbf added maintenance User-facing maintenance tasks ci:docs Run the CI jobs for documentation checks only. labels Nov 26, 2025
@yannbf yannbf merged commit 6f4c32a into next Nov 26, 2025
9 checks passed
@yannbf yannbf deleted the yann/minor-message-update branch November 26, 2025 09:58
@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented Nov 26, 2025

Caution

Review failed

The pull request is closed.

📝 Walkthrough

Walkthrough

Removed a trailing newline from the automigration links header in the CLI upgrade results logging function so the header text no longer renders with an extra blank line.

Changes

Cohort / File(s) Change Summary
Message formatting adjustment
code/lib/cli-storybook/src/upgrade.ts
Removed trailing newline (\n) from the automigration links message header in logUpgradeResults

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

  • Single-line, non-functional formatting change; review can focus on the one modified string.

Possibly related PRs

✨ Finishing touches
  • 📝 Generate docstrings

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 13d4773 and 94ea6b3.

📒 Files selected for processing (1)
  • code/lib/cli-storybook/src/upgrade.ts (1 hunks)

Comment @coderabbitai help to get the list of available commands and usage tips.

@nx-cloud
Copy link
Copy Markdown

nx-cloud Bot commented Nov 26, 2025

View your CI Pipeline Execution ↗ for commit 94ea6b3

Command Status Duration Result
nx run-many -t build --parallel=3 ✅ Succeeded 48s View ↗

☁️ Nx Cloud last updated this comment at 2025-11-26 10:20:18 UTC

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci:docs Run the CI jobs for documentation checks only. maintenance User-facing maintenance tasks

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant