Skip to content

Chore: Upgrade Chromatic CLI#33176

Merged
yannbf merged 7 commits into
nextfrom
upgrade-chromatic-cli
Dec 2, 2025
Merged

Chore: Upgrade Chromatic CLI#33176
yannbf merged 7 commits into
nextfrom
upgrade-chromatic-cli

Conversation

@ghengeveld
Copy link
Copy Markdown
Member

@ghengeveld ghengeveld commented Nov 25, 2025

What I did

Chromatic has been complaining for a while about our outdated dependency. So I upgraded it.
I checked the breaking changes in v12 and v13, none of them apply to us.

Screenshot 2025-11-26 at 00 44 50

Checklist for Contributors

Testing

The changes in this PR are covered in the following automated tests:

  • stories
  • unit tests
  • integration tests
  • end-to-end tests

Manual testing

This section is mandatory for all contributions. If you believe no manual test is necessary, please state so explicitly. Thanks!

Documentation

  • Add or update documentation reflecting your changes
  • If you are deprecating/removing a feature, make sure to update
    MIGRATION.MD

Checklist for Maintainers

  • When this PR is ready for testing, make sure to add ci:normal, ci:merged or ci:daily GH label to it to run a specific set of sandboxes. The particular set of sandboxes can be found in code/lib/cli-storybook/src/sandbox-templates.ts

  • Make sure this PR contains one of the labels below:

    Available labels
    • bug: Internal changes that fixes incorrect behavior.
    • maintenance: User-facing maintenance tasks.
    • dependencies: Upgrading (sometimes downgrading) dependencies.
    • build: Internal-facing build tooling & test updates. Will not show up in release changelog.
    • cleanup: Minor cleanup style change. Will not show up in release changelog.
    • documentation: Documentation only changes. Will not show up in release changelog.
    • feature request: Introducing a new feature.
    • BREAKING CHANGE: Changes that break compatibility in some way with current major version.
    • other: Changes that don't fit in the above categories.

🦋 Canary release

This PR does not have a canary release associated. You can request a canary release of this pull request by mentioning the @storybookjs/core team here.

core team members can create a canary release here or locally with gh workflow run --repo storybookjs/storybook publish.yml --field pr=<PR_NUMBER>

Summary by CodeRabbit

  • Chores
    • Updated build tool dependencies to latest stable versions for improved compatibility and maintenance.

✏️ Tip: You can customize this high-level summary in your review settings.

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented Nov 25, 2025

📝 Walkthrough

Walkthrough

A dependency version bump in scripts/package.json updates the chromatic package from ^11.28.2 to ^13.3.4. No other dependencies, scripts, or behavioral changes were made.

Changes

Cohort / File(s) Summary
Dependency version update
scripts/package.json
Chromatic package version bumped from ^11.28.2 to ^13.3.4

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes


📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between f0f5d63 and 1b6f7ce.

⛔ Files ignored due to path filters (1)
  • yarn.lock is excluded by !**/yarn.lock, !**/*.lock
📒 Files selected for processing (1)
  • scripts/package.json (1 hunks)
🚧 Files skipped from review as they are similar to previous changes (1)
  • scripts/package.json
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (3)
  • GitHub Check: normal
  • GitHub Check: nx
  • GitHub Check: Core Unit Tests, windows-latest

Comment @coderabbitai help to get the list of available commands and usage tips.

@nx-cloud
Copy link
Copy Markdown

nx-cloud Bot commented Nov 25, 2025

View your CI Pipeline Execution ↗ for commit 1b6f7ce

Command Status Duration Result
nx run-many -t compile --parallel=3 ✅ Succeeded 44s View ↗

☁️ Nx Cloud last updated this comment at 2025-12-02 11:59:36 UTC

Comment thread code/core/src/manager/components/sidebar/ChecklistWidget.tsx Outdated
@yannbf yannbf merged commit 833fced into next Dec 2, 2025
67 of 68 checks passed
@yannbf yannbf deleted the upgrade-chromatic-cli branch December 2, 2025 14:04
@github-actions github-actions Bot mentioned this pull request Dec 2, 2025
18 tasks
@shilman shilman added build Internal-facing build tooling & test updates and removed dependencies labels Jan 21, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

build Internal-facing build tooling & test updates ci:normal

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants