-
-
Notifications
You must be signed in to change notification settings - Fork 10.1k
Docs: Update install docs for --type with current project type values #33122
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
valentinpalkovic
merged 3 commits into
next
from
valentin/edit-install-instruction-cli-flags
Nov 24, 2025
Merged
Changes from all commits
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Some comments aren't visible on the classic Files Changed page.
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
π§© Analysis chain
Clarify the distinction between
react_native_webandreact_native_and_rnwproject types.Both type values (lines 182 and 183) have identical framework descriptions: "React Native Web". This creates ambiguity about when to use each type. If these are functionally different project types, their descriptions should clarify the distinction or the use case for each.
Can you confirm whether these two types serve different purposes? If so, please update their descriptions to clarify when developers should select each option. For example:
react_native_webβ React Native Web (web-only)react_native_and_rnwβ React Native with Web support (monorepo/multi-target)Or similar distinctions if that's not accurate.
Length of output: 27
π Script executed:
Length of output: 4917
π Script executed:
Length of output: 0
Length of output: 8108
π Script executed:
Length of output: 1373
π Script executed:
Length of output: 6275
Length of output: 589
π Script executed:
Length of output: 6989
π Script executed:
Length of output: 0
Length of output: 3110
π Script executed:
Length of output: 7599
Clarify the distinction between
react_native_webandreact_native_and_rnwproject types (lines 182β183).Both entries currently map to "React Native Web" but serve different purposes in the codebase. The
react_native_webtype configures a web-only setup, whilereact_native_and_rnwcombines React Native and React Native Web generators for dual-target monorepo setups. Update the descriptions to reflect this distinction, for example:react_native_webβ React Native Web (web target)react_native_and_rnwβ React Native and Web (dual targets)π€ Prompt for AI Agents